From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.115; helo=mga14.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0F3D72096106E for ; Mon, 7 May 2018 05:14:20 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 May 2018 05:14:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,373,1520924400"; d="scan'208";a="52154293" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga004.fm.intel.com with ESMTP; 07 May 2018 05:14:20 -0700 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 7 May 2018 05:14:20 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 7 May 2018 05:14:19 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.240]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.6]) with mapi id 14.03.0319.002; Mon, 7 May 2018 20:14:18 +0800 From: "Gao, Liming" To: "Marvin.Haeuser@outlook.com" , "edk2-devel@lists.01.org" CC: "Kinney, Michael D" Thread-Topic: [PATCH v2 2/2] IntelFrameworkPkg/FrameworkUefiLib: Add 'OUT' decorator where necessary. Thread-Index: AQHT5HyyIOpt6i6kpki08Z5WVenNAKQkMNmw Date: Mon, 7 May 2018 12:14:17 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E225E34@SHSMSX104.ccr.corp.intel.com> References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v2 2/2] IntelFrameworkPkg/FrameworkUefiLib: Add 'OUT' decorator where necessary. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 May 2018 12:14:21 -0000 Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ma= rvin H?user > Sent: Saturday, May 5, 2018 10:24 PM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Gao, Liming > Subject: [edk2] [PATCH v2 2/2] IntelFrameworkPkg/FrameworkUefiLib: Add 'O= UT' decorator where necessary. >=20 > The functions AddUnicodeString() and AddUnicodeString2() might return > a new value into their parameter UnicodeStringTable, hence add the > appropiate 'OUT' decorator. >=20 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Marvin Haeuser > --- > IntelFrameworkPkg/Library/FrameworkUefiLib/UefiLib.c | 19 +++++++++-----= ----- > 1 file changed, 9 insertions(+), 10 deletions(-) >=20 > diff --git a/IntelFrameworkPkg/Library/FrameworkUefiLib/UefiLib.c b/Intel= FrameworkPkg/Library/FrameworkUefiLib/UefiLib.c > index 895ff39fc140..61a32e297606 100644 > --- a/IntelFrameworkPkg/Library/FrameworkUefiLib/UefiLib.c > +++ b/IntelFrameworkPkg/Library/FrameworkUefiLib/UefiLib.c > @@ -865,11 +865,10 @@ LookupUnicodeString2 ( > **/ > EFI_STATUS > EFIAPI > -AddUnicodeString ( > - IN CONST CHAR8 *Language, > - IN CONST CHAR8 *SupportedLanguages, > - IN EFI_UNICODE_STRING_TABLE **UnicodeStringTable, > - IN CONST CHAR16 *UnicodeString > + IN CONST CHAR8 *Language, > + IN CONST CHAR8 *SupportedLanguages, > + IN OUT EFI_UNICODE_STRING_TABLE **UnicodeStringTable, > + IN CONST CHAR16 *UnicodeString > ) > { > UINTN NumberOfEntries; > @@ -1043,11 +1042,11 @@ AddUnicodeString ( > EFI_STATUS > EFIAPI > AddUnicodeString2 ( > - IN CONST CHAR8 *Language, > - IN CONST CHAR8 *SupportedLanguages, > - IN EFI_UNICODE_STRING_TABLE **UnicodeStringTable, > - IN CONST CHAR16 *UnicodeString, > - IN BOOLEAN Iso639Language > + IN CONST CHAR8 *Language, > + IN CONST CHAR8 *SupportedLanguages, > + IN OUT EFI_UNICODE_STRING_TABLE **UnicodeStringTable, > + IN CONST CHAR16 *UnicodeString, > + IN BOOLEAN Iso639Language > ) > { > UINTN NumberOfEntries; > -- > 2.17.0.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel