From: "Gao, Liming" <liming.gao@intel.com>
To: Supreeth Venkatesh <supreeth.venkatesh@arm.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Kinney, Michael D" <michael.d.kinney@intel.com>,
"Yao, Jiewen" <jiewen.yao@intel.com>,
"achin.gupta@arm.com" <achin.gupta@arm.com>,
"leif.lindholm@linaro.org" <leif.lindholm@linaro.org>,
"ard.biesheuvel@linaro.org" <ard.biesheuvel@linaro.org>
Subject: Re: [PATCH v2 17/17] BaseTools/AutoGen: Update header file for MM modules.
Date: Mon, 7 May 2018 15:11:20 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E225F04@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20180504204109.3354-18-supreeth.venkatesh@arm.com>
Hi,
This change should map to PiMm.h. I see the version 1 patch uses PiMm.h.
+ SUP_MODULE_MM_STANDALONE : ["PiSmm.h", "Library/BaseLib.h", "Library/DebugLib.h", "Library/StandaloneMmDriverEntryPoint.h"],
+ SUP_MODULE_MM_CORE_STANDALONE : ["PiSmm.h", "Library/BaseLib.h", "Library/DebugLib.h", "Library/StandaloneMmCoreEntryPoint.h"],
> -----Original Message-----
> From: Supreeth Venkatesh [mailto:supreeth.venkatesh@arm.com]
> Sent: Saturday, May 5, 2018 4:41 AM
> To: edk2-devel@lists.01.org
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>;
> achin.gupta@arm.com; leif.lindholm@linaro.org; ard.biesheuvel@linaro.org; Supreeth Venkatesh <supreeth.venkatesh@arm.com>
> Subject: [PATCH v2 17/17] BaseTools/AutoGen: Update header file for MM modules.
>
> This patch corrects the Module Type Header file for Management Mode(MM)
> as specified in PI v1.6 Specification. Also, it updates parameter for
> auto generated template functions from EFI_SMM_SYSTEM_TABLE2 to
> EFI_MM_SYSTEM_TABLE.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
> Reviewed-by: Jiewen Yao <jiewen.yao@intel.com>
> ---
> BaseTools/Source/Python/AutoGen/GenC.py | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/BaseTools/Source/Python/AutoGen/GenC.py b/BaseTools/Source/Python/AutoGen/GenC.py
> index d062588882..42753af62e 100644
> --- a/BaseTools/Source/Python/AutoGen/GenC.py
> +++ b/BaseTools/Source/Python/AutoGen/GenC.py
> @@ -265,7 +265,7 @@ EFI_STATUS
> EFIAPI
> ${Function} (
> IN EFI_HANDLE ImageHandle,
> - IN EFI_SMM_SYSTEM_TABLE2 *MmSystemTable
> + IN EFI_MM_SYSTEM_TABLE *MmSystemTable
> );
> ${END}
> """)
> @@ -278,7 +278,7 @@ EFI_STATUS
> EFIAPI
> ProcessModuleEntryPointList (
> IN EFI_HANDLE ImageHandle,
> - IN EFI_SMM_SYSTEM_TABLE2 *MmSystemTable
> + IN EFI_MM_SYSTEM_TABLE *MmSystemTable
> )
>
> {
> @@ -292,7 +292,7 @@ EFI_STATUS
> EFIAPI
> ProcessModuleEntryPointList (
> IN EFI_HANDLE ImageHandle,
> - IN EFI_SMM_SYSTEM_TABLE2 *MmSystemTable
> + IN EFI_MM_SYSTEM_TABLE *MmSystemTable
> )
>
> {
> @@ -307,7 +307,7 @@ EFI_STATUS
> EFIAPI
> ProcessModuleEntryPointList (
> IN EFI_HANDLE ImageHandle,
> - IN EFI_SMM_SYSTEM_TABLE2 *MmSystemTable
> + IN EFI_MM_SYSTEM_TABLE *MmSystemTable
> )
>
> {
> @@ -675,7 +675,7 @@ EFI_STATUS
> EFIAPI
> ${Function} (
> IN EFI_HANDLE ImageHandle,
> - IN EFI_SMM_SYSTEM_TABLE2 *MmSystemTable
> + IN EFI_MM_SYSTEM_TABLE *MmSystemTable
> );${END}
> """),
> }
> @@ -755,7 +755,7 @@ VOID
> EFIAPI
> ProcessLibrary${Type}List (
> IN EFI_HANDLE ImageHandle,
> - IN EFI_SMM_SYSTEM_TABLE2 *MmSystemTable
> + IN EFI_MM_SYSTEM_TABLE *MmSystemTable
> )
> {
> ${BEGIN} EFI_STATUS Status;
> @@ -779,8 +779,8 @@ gModuleTypeHeaderFile = {
> SUP_MODULE_UEFI_DRIVER : ["Uefi.h", "Library/BaseLib.h", "Library/DebugLib.h",
> "Library/UefiBootServicesTableLib.h", "Library/UefiDriverEntryPoint.h"],
> SUP_MODULE_UEFI_APPLICATION : ["Uefi.h", "Library/BaseLib.h", "Library/DebugLib.h",
> "Library/UefiBootServicesTableLib.h", "Library/UefiApplicationEntryPoint.h"],
> SUP_MODULE_SMM_CORE : ["PiDxe.h", "Library/BaseLib.h", "Library/DebugLib.h",
> "Library/UefiDriverEntryPoint.h"],
> - SUP_MODULE_MM_STANDALONE : ["PiSmm.h", "Library/BaseLib.h", "Library/DebugLib.h",
> "Library/SmmDriverStandaloneEntryPoint.h"],
> - SUP_MODULE_MM_CORE_STANDALONE : ["PiSmm.h", "Library/BaseLib.h", "Library/DebugLib.h",
> "Library/SmmCoreStandaloneEntryPoint.h"],
> + SUP_MODULE_MM_STANDALONE : ["PiSmm.h", "Library/BaseLib.h", "Library/DebugLib.h",
> "Library/StandaloneMmDriverEntryPoint.h"],
> + SUP_MODULE_MM_CORE_STANDALONE : ["PiSmm.h", "Library/BaseLib.h", "Library/DebugLib.h",
> "Library/StandaloneMmCoreEntryPoint.h"],
> SUP_MODULE_USER_DEFINED : [gBasicHeaderFile]
> }
>
> --
> 2.16.2
next prev parent reply other threads:[~2018-05-07 15:11 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-04 20:40 [PATCH v2 00/17] *** Standalone Management Mode Core Interface for AARCH64 Platforms *** Supreeth Venkatesh
2018-05-04 20:40 ` [PATCH v2 01/17] ArmPkg: Add PCDs needed for MM communication driver Supreeth Venkatesh
2018-05-04 20:40 ` [PATCH v2 02/17] ArmPkg/Drivers: Add EFI_MM_COMMUNICATION_PROTOCOL DXE driver Supreeth Venkatesh
2018-05-09 20:52 ` Udit Kumar
2018-05-10 19:46 ` Supreeth Venkatesh
2018-05-04 20:40 ` [PATCH v2 03/17] ArmPkg/Include: Add MM interface SVC return codes Supreeth Venkatesh
2018-05-09 20:57 ` Udit Kumar
2018-05-10 19:06 ` Supreeth Venkatesh
2018-05-04 20:40 ` [PATCH v2 04/17] ArmPkg/ArmMmuLib: Add MMU Library suitable for use in S-EL0 Supreeth Venkatesh
2018-05-09 21:09 ` Udit Kumar
2018-05-10 19:02 ` Supreeth Venkatesh
2018-05-04 20:40 ` [PATCH v2 05/17] ArmPkg/ArmMmuLib: Add MMU library inf file " Supreeth Venkatesh
2018-05-04 20:40 ` [PATCH v2 06/17] StandaloneMmPkg: Delete StandaloneMmPkg file Supreeth Venkatesh
2018-05-04 20:40 ` [PATCH v2 07/17] StandaloneMmPkg/FvLib: Add a common FV Library for management mode Supreeth Venkatesh
2018-05-04 20:41 ` [PATCH v2 08/17] StandaloneMmPkg/MemLib: Add Standalone MM instance of memory check library Supreeth Venkatesh
2018-05-04 20:41 ` [PATCH v2 09/17] StandaloneMmPkg/MemoryAllocationLib: Add MM memory allocation library Supreeth Venkatesh
2018-05-04 20:41 ` [PATCH v2 10/17] StandaloneMmPkg/HobLib: Add HOB Library for management mode Supreeth Venkatesh
2018-05-04 20:41 ` [PATCH v2 11/17] StandaloneMmPkg: MM driver entry point library Supreeth Venkatesh
2018-05-04 20:41 ` [PATCH v2 12/17] StandaloneMmPkg/Core: Implementation of Standalone MM Core Module Supreeth Venkatesh
2018-05-04 20:41 ` [PATCH v2 13/17] StandaloneMmPkg: Add an AArch64 specific entry point library Supreeth Venkatesh
2018-05-04 20:41 ` [PATCH v2 14/17] StandaloneMmPkg: Add CPU driver suitable for ARM Platforms Supreeth Venkatesh
2018-05-04 20:41 ` [PATCH v2 15/17] StandaloneMmPkg: Describe the declaration and definition files Supreeth Venkatesh
2018-05-04 20:41 ` [PATCH v2 16/17] ArmPkg: Extra action to update permissions for S-ELO MM Image Supreeth Venkatesh
2018-05-04 20:41 ` [PATCH v2 17/17] BaseTools/AutoGen: Update header file for MM modules Supreeth Venkatesh
2018-05-07 15:11 ` Gao, Liming [this message]
2018-05-07 19:16 ` Supreeth Venkatesh
2018-06-04 22:16 ` Supreeth Venkatesh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E225F04@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox