From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.151; helo=mga17.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 83D0F20961073 for ; Mon, 7 May 2018 08:11:24 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 May 2018 08:11:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,374,1520924400"; d="scan'208";a="39062101" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga007.jf.intel.com with ESMTP; 07 May 2018 08:11:23 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 7 May 2018 08:11:22 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.240]) by shsmsx102.ccr.corp.intel.com ([169.254.2.79]) with mapi id 14.03.0319.002; Mon, 7 May 2018 23:11:21 +0800 From: "Gao, Liming" To: Supreeth Venkatesh , "edk2-devel@lists.01.org" CC: "Kinney, Michael D" , "Yao, Jiewen" , "achin.gupta@arm.com" , "leif.lindholm@linaro.org" , "ard.biesheuvel@linaro.org" Thread-Topic: [PATCH v2 17/17] BaseTools/AutoGen: Update header file for MM modules. Thread-Index: AQHT4+huqTbyz4y+iUO4jykZ4eF/CKQkYxqQ Date: Mon, 7 May 2018 15:11:20 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E225F04@SHSMSX104.ccr.corp.intel.com> References: <20180504204109.3354-1-supreeth.venkatesh@arm.com> <20180504204109.3354-18-supreeth.venkatesh@arm.com> In-Reply-To: <20180504204109.3354-18-supreeth.venkatesh@arm.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v2 17/17] BaseTools/AutoGen: Update header file for MM modules. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 May 2018 15:11:24 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi,=20 This change should map to PiMm.h. I see the version 1 patch uses PiMm.h. + SUP_MODULE_MM_STANDALONE : ["PiSmm.h", "Library/BaseLib.h", "Lib= rary/DebugLib.h", "Library/StandaloneMmDriverEntryPoint.h"], + SUP_MODULE_MM_CORE_STANDALONE : ["PiSmm.h", "Library/BaseLib.h", "Lib= rary/DebugLib.h", "Library/StandaloneMmCoreEntryPoint.h"], > -----Original Message----- > From: Supreeth Venkatesh [mailto:supreeth.venkatesh@arm.com] > Sent: Saturday, May 5, 2018 4:41 AM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Gao, Liming ; Yao, Jiewen ; > achin.gupta@arm.com; leif.lindholm@linaro.org; ard.biesheuvel@linaro.org;= Supreeth Venkatesh > Subject: [PATCH v2 17/17] BaseTools/AutoGen: Update header file for MM mo= dules. >=20 > This patch corrects the Module Type Header file for Management Mode(MM) > as specified in PI v1.6 Specification. Also, it updates parameter for > auto generated template functions from EFI_SMM_SYSTEM_TABLE2 to > EFI_MM_SYSTEM_TABLE. >=20 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Supreeth Venkatesh > Reviewed-by: Jiewen Yao > --- > BaseTools/Source/Python/AutoGen/GenC.py | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) >=20 > diff --git a/BaseTools/Source/Python/AutoGen/GenC.py b/BaseTools/Source/P= ython/AutoGen/GenC.py > index d062588882..42753af62e 100644 > --- a/BaseTools/Source/Python/AutoGen/GenC.py > +++ b/BaseTools/Source/Python/AutoGen/GenC.py > @@ -265,7 +265,7 @@ EFI_STATUS > EFIAPI > ${Function} ( > IN EFI_HANDLE ImageHandle, > - IN EFI_SMM_SYSTEM_TABLE2 *MmSystemTable > + IN EFI_MM_SYSTEM_TABLE *MmSystemTable > ); > ${END} > """) > @@ -278,7 +278,7 @@ EFI_STATUS > EFIAPI > ProcessModuleEntryPointList ( > IN EFI_HANDLE ImageHandle, > - IN EFI_SMM_SYSTEM_TABLE2 *MmSystemTable > + IN EFI_MM_SYSTEM_TABLE *MmSystemTable > ) >=20 > { > @@ -292,7 +292,7 @@ EFI_STATUS > EFIAPI > ProcessModuleEntryPointList ( > IN EFI_HANDLE ImageHandle, > - IN EFI_SMM_SYSTEM_TABLE2 *MmSystemTable > + IN EFI_MM_SYSTEM_TABLE *MmSystemTable > ) >=20 > { > @@ -307,7 +307,7 @@ EFI_STATUS > EFIAPI > ProcessModuleEntryPointList ( > IN EFI_HANDLE ImageHandle, > - IN EFI_SMM_SYSTEM_TABLE2 *MmSystemTable > + IN EFI_MM_SYSTEM_TABLE *MmSystemTable > ) >=20 > { > @@ -675,7 +675,7 @@ EFI_STATUS > EFIAPI > ${Function} ( > IN EFI_HANDLE ImageHandle, > - IN EFI_SMM_SYSTEM_TABLE2 *MmSystemTable > + IN EFI_MM_SYSTEM_TABLE *MmSystemTable > );${END} > """), > } > @@ -755,7 +755,7 @@ VOID > EFIAPI > ProcessLibrary${Type}List ( > IN EFI_HANDLE ImageHandle, > - IN EFI_SMM_SYSTEM_TABLE2 *MmSystemTable > + IN EFI_MM_SYSTEM_TABLE *MmSystemTable > ) > { > ${BEGIN} EFI_STATUS Status; > @@ -779,8 +779,8 @@ gModuleTypeHeaderFile =3D { > SUP_MODULE_UEFI_DRIVER : ["Uefi.h", "Library/BaseLib.h", "L= ibrary/DebugLib.h", > "Library/UefiBootServicesTableLib.h", "Library/UefiDriverEntryPoint.h"], > SUP_MODULE_UEFI_APPLICATION : ["Uefi.h", "Library/BaseLib.h", "L= ibrary/DebugLib.h", > "Library/UefiBootServicesTableLib.h", "Library/UefiApplicationEntryPoint.= h"], > SUP_MODULE_SMM_CORE : ["PiDxe.h", "Library/BaseLib.h", "L= ibrary/DebugLib.h", > "Library/UefiDriverEntryPoint.h"], > - SUP_MODULE_MM_STANDALONE : ["PiSmm.h", "Library/BaseLib.h", "L= ibrary/DebugLib.h", > "Library/SmmDriverStandaloneEntryPoint.h"], > - SUP_MODULE_MM_CORE_STANDALONE : ["PiSmm.h", "Library/BaseLib.h", "L= ibrary/DebugLib.h", > "Library/SmmCoreStandaloneEntryPoint.h"], > + SUP_MODULE_MM_STANDALONE : ["PiSmm.h", "Library/BaseLib.h", "L= ibrary/DebugLib.h", > "Library/StandaloneMmDriverEntryPoint.h"], > + SUP_MODULE_MM_CORE_STANDALONE : ["PiSmm.h", "Library/BaseLib.h", "L= ibrary/DebugLib.h", > "Library/StandaloneMmCoreEntryPoint.h"], > SUP_MODULE_USER_DEFINED : [gBasicHeaderFile] > } >=20 > -- > 2.16.2