From: "Gao, Liming" <liming.gao@intel.com>
To: "Bi, Dandan" <dandan.bi@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [patch] IntelFrameworkPkg/UefiLib: Fix build fail caused by commit b6d5def2fa
Date: Mon, 21 May 2018 07:15:29 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E22CB01@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20180518061506.111068-1-dandan.bi@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
>-----Original Message-----
>From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
>Dandan Bi
>Sent: Friday, May 18, 2018 2:15 PM
>To: edk2-devel@lists.01.org
>Cc: Gao, Liming <liming.gao@intel.com>
>Subject: [edk2] [patch] IntelFrameworkPkg/UefiLib: Fix build fail caused by
>commit b6d5def2fa
>
>In commit b6d5def2faf56334128ea2f056356d7e3852831e
>when adding 'OUT' decorator for the parameter in AddUnicodeString(),
>it delete the function name by mistake. This patch is to fix this
>issue.
>
>CC: Marvin Haeuser <Marvin.Haeuser@outlook.com>
>CC: Liming Gao <liming.gao@intel.com>
>Contributed-under: TianoCore Contribution Agreement 1.1
>Signed-off-by: Dandan Bi <dandan.bi@intel.com>
>---
> IntelFrameworkPkg/Library/FrameworkUefiLib/UefiLib.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/IntelFrameworkPkg/Library/FrameworkUefiLib/UefiLib.c
>b/IntelFrameworkPkg/Library/FrameworkUefiLib/UefiLib.c
>index 61a32e29760..443a7391721 100644
>--- a/IntelFrameworkPkg/Library/FrameworkUefiLib/UefiLib.c
>+++ b/IntelFrameworkPkg/Library/FrameworkUefiLib/UefiLib.c
>@@ -863,10 +863,11 @@ LookupUnicodeString2 (
> member of SupportedLanguages.
>
> **/
> EFI_STATUS
> EFIAPI
>+AddUnicodeString (
> IN CONST CHAR8 *Language,
> IN CONST CHAR8 *SupportedLanguages,
> IN OUT EFI_UNICODE_STRING_TABLE **UnicodeStringTable,
> IN CONST CHAR16 *UnicodeString
> )
>--
>2.14.3.windows.1
>
>_______________________________________________
>edk2-devel mailing list
>edk2-devel@lists.01.org
>https://lists.01.org/mailman/listinfo/edk2-devel
prev parent reply other threads:[~2018-05-21 7:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-18 6:15 [patch] IntelFrameworkPkg/UefiLib: Fix build fail caused by commit b6d5def2fa Dandan Bi
2018-05-21 7:15 ` Gao, Liming [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E22CB01@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox