public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gao, Liming" <liming.gao@intel.com>
To: "Zhu, Yonghong" <yonghong.zhu@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Kinney, Michael D" <michael.d.kinney@intel.com>,
	"Shaw, Kevin W" <kevin.w.shaw@intel.com>
Subject: Re: [Patch] Build spec: Add module scoped `<Pcd*>` section override scope statement
Date: Wed, 23 May 2018 04:50:27 +0000	[thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E22F2EB@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <1527047060-5028-1-git-send-email-yonghong.zhu@intel.com>

Reviewed-by: Liming Gao <liming.gao@intel.com>

>-----Original Message-----
>From: Zhu, Yonghong
>Sent: Wednesday, May 23, 2018 11:44 AM
>To: edk2-devel@lists.01.org
>Cc: Gao, Liming <liming.gao@intel.com>; Kinney, Michael D
><michael.d.kinney@intel.com>; Shaw, Kevin W <kevin.w.shaw@intel.com>
>Subject: [Patch] Build spec: Add module scoped `<Pcd*>` section override
>scope statement
>
>Cc: Liming Gao <liming.gao@intel.com>
>Cc: Michael Kinney <michael.d.kinney@intel.com>
>Cc: Kevin W Shaw <kevin.w.shaw@intel.com>
>Contributed-under: TianoCore Contribution Agreement 1.1
>Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
>---
> 8_pre-build_autogen_stage/82_auto-generation_process.md | 7 ++++++-
> README.md                                               | 1 +
> 2 files changed, 7 insertions(+), 1 deletion(-)
>
>diff --git a/8_pre-build_autogen_stage/82_auto-generation_process.md
>b/8_pre-build_autogen_stage/82_auto-generation_process.md
>index b4b59db..8f8f29b 100644
>--- a/8_pre-build_autogen_stage/82_auto-generation_process.md
>+++ b/8_pre-build_autogen_stage/82_auto-generation_process.md
>@@ -258,11 +258,11 @@ From the DSC file, the build tools collect the mapping
>between library classes
> and library instances (INF files), PCD data for the whole platform, the list of
> modules (INF files) specified for the platform, and the build output directory.
> Optionally, the name of the flash image layout description (FDF) file and build
> options specific to the platform are also obtained. Parsing FDF file at this
> time is just for the PCD information which might be used by some modules,
>and
>-merge these PDC values into the information set of PCDs in DSC file.
>+merge these PCD values into the information set of PCDs in DSC file.
>
> A PCD entry must only be listed once per section in the DSC or FDF files.
>
> Multiple library class instances for a single library class must not be
> specified in the same `[LibraryClasses]` or `<LibraryClasses>` section in the
>@@ -839,10 +839,15 @@ default method.
>   listed in a `PcdsDynamicEx` section, then use DynamicEx.
>
> * If not listed in any of the previous sections, and the PCD is listed in the
>   `PcdsDynamic` section, then use Dynamic.
>
>+If the Platform Integrator does not specify the format, and the PCD state is
>+in Platform DSC file `[Components]` section module scoped `<Pcd*>` section,
>+then the PCD used in `[Components]` section module or its linked library INF
>+files will use the module scoped `<Pcd*>` type as default type.
>+
> Build tools are required to process PCD values for `VOID*` PCDs into byte
> arrays, C format GUIDs or as C format strings (either ASCII or [L]"string")
> prior to autogenerating the code.
>
> PCD values stored in VPD regions are processed prior to completing the final
>diff --git a/README.md b/README.md
>index 9fb7e93..18e46c9 100644
>--- a/README.md
>+++ b/README.md
>@@ -223,5 +223,6 @@ Copyright (c) 2008-2017, Intel Corporation. All rights
>reserved.
> |            | [#775](https://bugzilla.tianocore.org/show_bug.cgi?id=775) Build
>spec: Add description about auto detect thread number
>|               |
> |            | Add Flexible PCD value format into spec
>|               |
> |            | Update PCD value and SKU, DefaultStore info in build report
>|               |
> |            | Clarify structure PCD field value assignment precedence
>|               |
> |            | Update description for build handles PCDs for SKU support
>|               |
>+|            | Add statement about module scoped `<Pcd*>` section override
>scope
>|               |
>--
>2.6.1.windows.1



      reply	other threads:[~2018-05-23  4:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-23  3:44 [Patch] Build spec: Add module scoped `<Pcd*>` section override scope statement Yonghong Zhu
2018-05-23  4:50 ` Gao, Liming [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E22F2EB@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox