Re: [PATCH] MdeModulePkg PeiCore: Check error status when processing boot FV

["Gao, Liming" <liming.gao@intel.com>]

I agree to add this checker. 

Reviewed-by: Liming Gao <liming.gao@intel.com>

> -----Original Message-----
> From: Marcin Wojtas [mailto:mw@semihalf.com]
> Sent: Friday, June 1, 2018 9:58 PM
> To: edk2-devel@lists.01.org
> Cc: Tian, Feng <feng.tian@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>;
> leif.lindholm@linaro.org; ard.biesheuvel@linaro.org; jsd@semihalf.com; Marcin Wojtas <mw@semihalf.com>
> Subject: [PATCH] MdeModulePkg PeiCore: Check error status when processing boot FV
> 
> Until now the possible errors returned from processing
> boot firmware volume were not checked, which could cause
> misbehavior in further booting stages. Add relevant assert.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Marcin Wojtas <mw@semihalf.com>
> Signed-off-by: Jan Dabros <jsd@semihalf.com>
> ---
>  MdeModulePkg/Core/Pei/FwVol/FwVol.c | 13 +++++++------
>  1 file changed, 7 insertions(+), 6 deletions(-)
> 
> diff --git a/MdeModulePkg/Core/Pei/FwVol/FwVol.c b/MdeModulePkg/Core/Pei/FwVol/FwVol.c
> index 8009546..4150b33 100644
> --- a/MdeModulePkg/Core/Pei/FwVol/FwVol.c
> +++ b/MdeModulePkg/Core/Pei/FwVol/FwVol.c
> @@ -495,12 +495,13 @@ PeiInitializeFv (
>    //
>    // Get handle of BFV
>    //
> -  FvPpi->ProcessVolume (
> -           FvPpi,
> -           SecCoreData->BootFirmwareVolumeBase,
> -           (UINTN)BfvHeader->FvLength,
> -           &FvHandle
> -           );
> +  Status = FvPpi->ProcessVolume (
> +                    FvPpi,
> +                    SecCoreData->BootFirmwareVolumeBase,
> +                    (UINTN)BfvHeader->FvLength,
> +                    &FvHandle
> +                    );
> +  ASSERT_EFI_ERROR (Status);
> 
>    //
>    // Update internal PEI_CORE_FV array.
> --
> 2.7.4