public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gao, Liming" <liming.gao@intel.com>
To: "Zhu, Yonghong" <yonghong.zhu@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Kinney, Michael D" <michael.d.kinney@intel.com>,
	"Shaw, Kevin W" <kevin.w.shaw@intel.com>
Subject: Re: [Patch 1/5] Build Spec: Add !error statement support
Date: Thu, 7 Jun 2018 08:00:28 +0000	[thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E294132@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <1527728184-1736-1-git-send-email-yonghong.zhu@intel.com>

Reviewed-by: Liming Gao <liming.gao@intel.com>

>-----Original Message-----
>From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
>Yonghong Zhu
>Sent: Thursday, May 31, 2018 8:56 AM
>To: edk2-devel@lists.01.org
>Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Shaw, Kevin W
><kevin.w.shaw@intel.com>; Gao, Liming <liming.gao@intel.com>
>Subject: [edk2] [Patch 1/5] Build Spec: Add !error statement support
>
>Cc: Liming Gao <liming.gao@intel.com>
>Cc: Michael Kinney <michael.d.kinney@intel.com>
>Cc: Kevin W Shaw <kevin.w.shaw@intel.com>
>Contributed-under: TianoCore Contribution Agreement 1.1
>Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
>---
> 8_pre-build_autogen_stage/82_auto-generation_process.md | 6 ++++++
> README.md                                               | 3 ++-
> 2 files changed, 8 insertions(+), 1 deletion(-)
>
>diff --git a/8_pre-build_autogen_stage/82_auto-generation_process.md
>b/8_pre-build_autogen_stage/82_auto-generation_process.md
>index 8f8f29b..abfa55c 100644
>--- a/8_pre-build_autogen_stage/82_auto-generation_process.md
>+++ b/8_pre-build_autogen_stage/82_auto-generation_process.md
>@@ -1058,10 +1058,16 @@ hash value file into the directory specified by
>binary-destination at the build
> When --hash and --binary-source are specified, build tool will try to get the
>binary
> files from the binary source directory at the build phase. If the cached binary
>has
> the same hash value, it will be directly used. Otherwise, build tool will compile
>the
> source files and generate the binary files.
>
>+#### 8.2.4.16 !error Statement
>+
>+The DSC and FDF file can use `!error` statement. The argument of this
>statement is an
>+error message, it causes build tool to stop at the location where the
>statement is
>+encountered and error message following the `!error` statement is output as
>a message.
>+
> ### 8.2.5 Post processing
>
> Once all files are parsed, the build tools will do following work for each EDK
> II module:
>
>diff --git a/README.md b/README.md
>index 18e46c9..9ca8733 100644
>--- a/README.md
>+++ b/README.md
>@@ -223,6 +223,7 @@ Copyright (c) 2008-2017, Intel Corporation. All rights
>reserved.
> |            | [#775](https://bugzilla.tianocore.org/show_bug.cgi?id=775) Build
>spec: Add description about auto detect thread number
>|               |
> |            | Add Flexible PCD value format into spec
>|               |
> |            | Update PCD value and SKU, DefaultStore info in build report
>|               |
> |            | Clarify structure PCD field value assignment precedence
>|               |
> |            | Update description for build handles PCDs for SKU support
>|               |
>-|            | Add statement about module scoped `<Pcd*>` section override
>scope
>|               |
>+|            | Add statement about module scoped `<Pcd*>` section override
>scope
>|               |
>+|            | Add !error statement section
>|               |
>--
>2.6.1.windows.1
>
>_______________________________________________
>edk2-devel mailing list
>edk2-devel@lists.01.org
>https://lists.01.org/mailman/listinfo/edk2-devel


      parent reply	other threads:[~2018-06-07  8:00 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-31  0:56 [Patch 1/5] Build Spec: Add !error statement support Yonghong Zhu
2018-05-31  0:56 ` [Patch 2/5] DEC Spec: !error statement is not permitted in DEC file Yonghong Zhu
2018-05-31  0:56 ` [Patch 3/5] DSC Spec: Add !error statement support Yonghong Zhu
2018-05-31  0:56 ` [Patch 4/5] FDF " Yonghong Zhu
2018-05-31  0:56 ` [Patch 5/5] INF Spec: !error statement is not permitted in INF file Yonghong Zhu
2018-05-31 10:27 ` [Patch 1/5] Build Spec: Add !error statement support Laszlo Ersek
2018-06-01  0:15   ` Zhu, Yonghong
2018-06-04 20:05 ` Kinney, Michael D
2018-06-05 12:36   ` Zhu, Yonghong
2018-06-07  8:00 ` Gao, Liming [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E294132@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox