Re: [patch 3/3] ShellPkg/Dp: Make the help info align with code

["Gao, Liming" <liming.gao@intel.com>]

Dandan:
  I find there is still some code related to -T, -P flags. If they are not implemented, I suggest to remove them from source code also. 

Thanks
Liming
>-----Original Message-----
>From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
>Dandan Bi
>Sent: Tuesday, June 05, 2018 4:33 PM
>To: edk2-devel@lists.01.org
>Cc: Ni, Ruiyu <ruiyu.ni@intel.com>; Carsey, Jaben <jaben.carsey@intel.com>;
>Gao, Liming <liming.gao@intel.com>
>Subject: [edk2] [patch 3/3] ShellPkg/Dp: Make the help info align with code
>
>Remove -T, -P, -h flags in the help info of DP to
>align with current code implementation.
>
>Cc: Liming Gao <liming.gao@intel.com>
>Cc: Ruiyu Ni <ruiyu.ni@intel.com>
>Cc: Jaben Carsey <jaben.carsey@intel.com>
>Contributed-under: TianoCore Contribution Agreement 1.1
>Signed-off-by: Dandan Bi <dandan.bi@intel.com>
>---
> ShellPkg/DynamicCommand/DpDynamicCommand/Dp.uni | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
>diff --git a/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.uni
>b/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.uni
>index c7eb0fbd71e..ede59069b79 100644
>--- a/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.uni
>+++ b/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.uni
>@@ -96,21 +96,19 @@
> #string STR_GET_HELP_DP         #language en-US ""
> ".TH dp 0 "Display performance metrics"\r\n"
> ".SH NAME\r\n"
> "Displays performance metrics that are stored in memory.\r\n"
> ".SH SYNOPSIS\r\n"
>-"DP [-b] [-v] [-x] [-s | -A | -R] [-T] [-P] [-t value] [-n count] [-c [token]][-i] [-h
>| -?]\r\n"
>+"DP [-b] [-v] [-x] [-s | -A | -R] [-t value] [-n count] [-c [token]][-i] [-?]\r\n"
> ".SH OPTIONS\r\n"
> " \r\n"
> "  -b       - Displays on multiple pages\r\n"
> "  -v       - Displays additional information\r\n"
> "  -x       - Prevents display of individual measurements for cumulative
>items\r\n"
> "  -s       - Displays summary information only\r\n"
> "  -A       - Displays all measurements in a list\r\n"
> "  -R       - Displays all measurements in raw format\r\n"
>-"  -T       - Displays trace measurements only\r\n"
>-"  -P       - Displays profile measurements only\r\n"
> "  -t VALUE - Sets display threshold to VALUE microseconds\r\n"
> "  -n COUNT - Limits display to COUNT lines in All and Raw modes\r\n"
> "  -i       - Displays identifier\r\n"
> "  -c TOKEN - Display pre-defined and custom cumulative data\r\n"
> "             Pre-defined cumulative token are:\r\n"
>--
>2.14.3.windows.1
>
>_______________________________________________
>edk2-devel mailing list
>edk2-devel@lists.01.org
>https://lists.01.org/mailman/listinfo/edk2-devel