From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.24; helo=mga09.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 436E221123E1A for ; Sun, 10 Jun 2018 20:10:24 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jun 2018 20:10:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,500,1520924400"; d="scan'208";a="56286869" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by FMSMGA003.fm.intel.com with ESMTP; 10 Jun 2018 20:10:23 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 10 Jun 2018 20:10:23 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.87]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.70]) with mapi id 14.03.0319.002; Mon, 11 Jun 2018 11:10:21 +0800 From: "Gao, Liming" To: "Bi, Dandan" , "edk2-devel@lists.01.org" CC: "Ni, Ruiyu" , "Carsey, Jaben" Thread-Topic: [edk2] [patch 3/3] ShellPkg/Dp: Make the help info align with code Thread-Index: AQHT/KffCBGnv81iKU2hQaJa3wo0fKRaaZ+g Date: Mon, 11 Jun 2018 03:10:20 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E295494@SHSMSX104.ccr.corp.intel.com> References: <20180605083243.81276-1-dandan.bi@intel.com> <20180605083243.81276-3-dandan.bi@intel.com> In-Reply-To: <20180605083243.81276-3-dandan.bi@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [patch 3/3] ShellPkg/Dp: Make the help info align with code X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Jun 2018 03:10:24 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Dandan: I find there is still some code related to -T, -P flags. If they are not = implemented, I suggest to remove them from source code also.=20 Thanks Liming >-----Original Message----- >From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of >Dandan Bi >Sent: Tuesday, June 05, 2018 4:33 PM >To: edk2-devel@lists.01.org >Cc: Ni, Ruiyu ; Carsey, Jaben = ; >Gao, Liming >Subject: [edk2] [patch 3/3] ShellPkg/Dp: Make the help info align with cod= e > >Remove -T, -P, -h flags in the help info of DP to >align with current code implementation. > >Cc: Liming Gao >Cc: Ruiyu Ni >Cc: Jaben Carsey >Contributed-under: TianoCore Contribution Agreement 1.1 >Signed-off-by: Dandan Bi >--- > ShellPkg/DynamicCommand/DpDynamicCommand/Dp.uni | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > >diff --git a/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.uni >b/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.uni >index c7eb0fbd71e..ede59069b79 100644 >--- a/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.uni >+++ b/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.uni >@@ -96,21 +96,19 @@ > #string STR_GET_HELP_DP #language en-US "" > ".TH dp 0 "Display performance metrics"\r\n" > ".SH NAME\r\n" > "Displays performance metrics that are stored in memory.\r\n" > ".SH SYNOPSIS\r\n" >-"DP [-b] [-v] [-x] [-s | -A | -R] [-T] [-P] [-t value] [-n count] [-c [to= ken]][-i] [-h >| -?]\r\n" >+"DP [-b] [-v] [-x] [-s | -A | -R] [-t value] [-n count] [-c [token]][-i] = [-?]\r\n" > ".SH OPTIONS\r\n" > " \r\n" > " -b - Displays on multiple pages\r\n" > " -v - Displays additional information\r\n" > " -x - Prevents display of individual measurements for cumulative >items\r\n" > " -s - Displays summary information only\r\n" > " -A - Displays all measurements in a list\r\n" > " -R - Displays all measurements in raw format\r\n" >-" -T - Displays trace measurements only\r\n" >-" -P - Displays profile measurements only\r\n" > " -t VALUE - Sets display threshold to VALUE microseconds\r\n" > " -n COUNT - Limits display to COUNT lines in All and Raw modes\r\n" > " -i - Displays identifier\r\n" > " -c TOKEN - Display pre-defined and custom cumulative data\r\n" > " Pre-defined cumulative token are:\r\n" >-- >2.14.3.windows.1 > >_______________________________________________ >edk2-devel mailing list >edk2-devel@lists.01.org >https://lists.01.org/mailman/listinfo/edk2-devel