From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.115; helo=mga14.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id ABF39211BFCAE for ; Mon, 11 Jun 2018 21:21:47 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Jun 2018 21:21:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,213,1526367600"; d="scan'208";a="47037373" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga008.fm.intel.com with ESMTP; 11 Jun 2018 21:21:46 -0700 Received: from fmsmsx116.amr.corp.intel.com (10.18.116.20) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 11 Jun 2018 21:21:46 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx116.amr.corp.intel.com (10.18.116.20) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 11 Jun 2018 21:21:46 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.87]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.51]) with mapi id 14.03.0319.002; Tue, 12 Jun 2018 12:21:43 +0800 From: "Gao, Liming" To: "Bi, Dandan" , "edk2-devel@lists.01.org" CC: "Ni, Ruiyu" , "Carsey, Jaben" Thread-Topic: [patch V2 3/3] ShellPkg/Dp: Make the help info align with code Thread-Index: AQHUAV7HIwHHwrv5oUeH1tuawW9y2qRcBuaw Date: Tue, 12 Jun 2018 04:21:43 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E29608E@SHSMSX104.ccr.corp.intel.com> References: <20180611083206.106804-1-dandan.bi@intel.com> <20180611083206.106804-3-dandan.bi@intel.com> In-Reply-To: <20180611083206.106804-3-dandan.bi@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMjk0MTNhNDYtMGY0ZS00MTIyLThjZGQtNGFmMGQ3YzllODM4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiNHJVYWJuZE9zOXd1STZLMGtPaGdOYVU5UThOeFNFdlJWMmVhY3pONkk2RFdlSjJ4ZUE3UE5QMTQ1QjJpdFJNZSJ9 dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [patch V2 3/3] ShellPkg/Dp: Make the help info align with code X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Jun 2018 04:21:47 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao > -----Original Message----- > From: Bi, Dandan > Sent: Monday, June 11, 2018 4:32 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming ; Ni, Ruiyu ; C= arsey, Jaben > Subject: [patch V2 3/3] ShellPkg/Dp: Make the help info align with code >=20 > Currently in DP, the Trace mode is enabled by default. > And the profile mode is not implemented. but the help info > of DP tool doesn't match current implementation. Which will > make user confused. So now remove the unused source code > related to the profile mode and update the help information > of DP tool. >=20 > V2: Remove the unused code related to profile mode. >=20 > Cc: Liming Gao > Cc: Ruiyu Ni > Cc: Jaben Carsey > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Dandan Bi > --- > ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c | 96 ++++++---------= ----- > ShellPkg/DynamicCommand/DpDynamicCommand/Dp.h | 7 -- > ShellPkg/DynamicCommand/DpDynamicCommand/Dp.uni | 6 +- > ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.inf | 1 - > .../DpDynamicCommand/DpDynamicCommand.inf | 1 - > .../DynamicCommand/DpDynamicCommand/DpInternal.h | 48 ---------- > .../DynamicCommand/DpDynamicCommand/DpProfile.c | 100 ---------------= ------ > 7 files changed, 26 insertions(+), 233 deletions(-) > delete mode 100644 ShellPkg/DynamicCommand/DpDynamicCommand/DpProfile.c >=20 > diff --git a/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c b/ShellPkg/Dyn= amicCommand/DpDynamicCommand/Dp.c > index d8451dbf59f..38766613175 100644 > --- a/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c > +++ b/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c > @@ -82,14 +82,10 @@ UINT32 const NumCum =3D sizeof(CumData) / sizeof= (PERF_CUM_DATA); > STATIC CONST SHELL_PARAM_ITEM ParamList[] =3D { > {L"-v", TypeFlag}, // -v Verbose Mode > {L"-A", TypeFlag}, // -A All, Cooked > {L"-R", TypeFlag}, // -R RAW All > {L"-s", TypeFlag}, // -s Summary > -#if PROFILING_IMPLEMENTED > - {L"-P", TypeFlag}, // -P Dump Profile Data > - {L"-T", TypeFlag}, // -T Dump Trace Data > -#endif // PROFILING_IMPLEMENTED > {L"-x", TypeFlag}, // -x eXclude Cumulative Items > {L"-i", TypeFlag}, // -i Display Identifier > {L"-c", TypeValue}, // -c Display cumulative data. > {L"-n", TypeValue}, // -n # Number of records to display for A and R > {L"-t", TypeValue}, // -t # Threshold of interest > @@ -114,13 +110,10 @@ DumpStatistics( void ) > ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN (STR_DP_STATS_NUMINCOMPLET= E), mDpHiiHandle, SummaryData.NumIncomplete); > ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN (STR_DP_STATS_NUMPHASES), = mDpHiiHandle, SummaryData.NumSummary); > ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN (STR_DP_STATS_NUMHANDLES),= mDpHiiHandle, SummaryData.NumHandles, > SummaryData.NumTrace - SummaryData.NumHandles); > ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN (STR_DP_STATS_NUMPEIMS), m= DpHiiHandle, SummaryData.NumPEIMs); > ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN (STR_DP_STATS_NUMGLOBALS),= mDpHiiHandle, SummaryData.NumGlobal); > -#if PROFILING_IMPLEMENTED > - ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN (STR_DP_STATS_NUMPROFILE),= mDpHiiHandle, SummaryData.NumProfile); > -#endif // PROFILING_IMPLEMENTED > SHELL_FREE_NON_NULL (StringPtr); > SHELL_FREE_NON_NULL (StringPtrUnknown); > } >=20 > /** > @@ -682,11 +675,10 @@ VOID > InitSummaryData ( > VOID > ) > { > SummaryData.NumTrace =3D 0; > - SummaryData.NumProfile =3D 0 ; > SummaryData.NumIncomplete =3D 0; > SummaryData.NumSummary =3D 0; > SummaryData.NumHandles =3D 0; > SummaryData.NumPEIMs =3D 0; > SummaryData.NumGlobal =3D 0; > @@ -719,12 +711,10 @@ RunDp ( > EFI_STRING StringPtr; > BOOLEAN SummaryMode; > BOOLEAN VerboseMode; > BOOLEAN AllMode; > BOOLEAN RawMode; > - BOOLEAN TraceMode; > - BOOLEAN ProfileMode; > BOOLEAN ExcludeMode; > BOOLEAN CumulativeMode; > CONST CHAR16 *CustomCumulativeToken; > PERF_CUM_DATA *CustomCumulativeData; > UINTN NameSize; > @@ -734,12 +724,10 @@ RunDp ( > StringPtr =3D NULL; > SummaryMode =3D FALSE; > VerboseMode =3D FALSE; > AllMode =3D FALSE; > RawMode =3D FALSE; > - TraceMode =3D FALSE; > - ProfileMode =3D FALSE; > ExcludeMode =3D FALSE; > CumulativeMode =3D FALSE; > CustomCumulativeData =3D NULL; > ShellStatus =3D SHELL_SUCCESS; >=20 > @@ -763,14 +751,10 @@ RunDp ( > // > VerboseMode =3D ShellCommandLineGetFlag (ParamPackage, L"-v"); > SummaryMode =3D (BOOLEAN) (ShellCommandLineGetFlag (ParamPackage, L"-S= ") || ShellCommandLineGetFlag (ParamPackage, > L"-s")); > AllMode =3D ShellCommandLineGetFlag (ParamPackage, L"-A"); > RawMode =3D ShellCommandLineGetFlag (ParamPackage, L"-R"); > -#if PROFILING_IMPLEMENTED > - TraceMode =3D ShellCommandLineGetFlag (ParamPackage, L"-T"); > - ProfileMode =3D ShellCommandLineGetFlag (ParamPackage, L"-P"); > -#endif // PROFILING_IMPLEMENTED > ExcludeMode =3D ShellCommandLineGetFlag (ParamPackage, L"-x"); > mShowId =3D ShellCommandLineGetFlag (ParamPackage, L"-i"); > CumulativeMode =3D ShellCommandLineGetFlag (ParamPackage, L"-c"); >=20 > // Options with Values > @@ -789,18 +773,10 @@ RunDp ( > mInterestThreshold =3D DEFAULT_THRESHOLD; // 1ms :=3D 1,000 us > } else { > mInterestThreshold =3D StrDecimalToUint64(CmdLineArg); > } >=20 > - // Handle Flag combinations and default behaviors > - // If both TraceMode and ProfileMode are FALSE, set them both to TRUE > - if ((! TraceMode) && (! ProfileMode)) { > - TraceMode =3D TRUE; > -#if PROFILING_IMPLEMENTED > - ProfileMode =3D TRUE; > -#endif // PROFILING_IMPLEMENTED > - } >=20 > // > // DP dump performance data by parsing FPDT table in ACPI table. > // Folloing 3 steps are to get the measurement form the FPDT table. > // > @@ -917,71 +893,49 @@ RunDp ( > **** n Number2Display Used by All and Raw mode. Otherwise ignored. > **** A All -- R and S options are ignored > **** R Raw -- S option is ignored > **** s Summary -- Modifies "Cooked" output only > **** Cooked (Default) > -**** > -**** The All, Raw, and Cooked modes are modified by the Trace and Profi= le > -**** options. > -**** !T && !P :=3D (0) Default, Both are displayed > -**** T && !P :=3D (1) Only Trace records are displayed > -**** !T && P :=3D (2) Only Profile records are displayed > -**** T && P :=3D (3) Same as Default, both are displayed > ************************************************************************= ****/ > GatherStatistics (CustomCumulativeData); > if (CumulativeMode) { > ProcessCumulative (CustomCumulativeData); > } else if (AllMode) { > - if (TraceMode) { > - Status =3D DumpAllTrace( Number2Display, ExcludeMode); > + Status =3D DumpAllTrace( Number2Display, ExcludeMode); > + if (Status =3D=3D EFI_ABORTED) { > + ShellStatus =3D SHELL_ABORTED; > + goto Done; > + } > + } else if (RawMode) { > + Status =3D DumpRawTrace( Number2Display, ExcludeMode); > + if (Status =3D=3D EFI_ABORTED) { > + ShellStatus =3D SHELL_ABORTED; > + goto Done; > + } > + } else { > + //------------- Begin Cooked Mode Processing > + ProcessPhases (); > + if ( ! SummaryMode) { > + Status =3D ProcessHandles ( ExcludeMode); > if (Status =3D=3D EFI_ABORTED) { > ShellStatus =3D SHELL_ABORTED; > goto Done; > } > - } > - if (ProfileMode) { > - DumpAllProfile( Number2Display, ExcludeMode); > - } > - } else if (RawMode) { > - if (TraceMode) { > - Status =3D DumpRawTrace( Number2Display, ExcludeMode); > + > + Status =3D ProcessPeims (); > if (Status =3D=3D EFI_ABORTED) { > ShellStatus =3D SHELL_ABORTED; > goto Done; > } > - } > - if (ProfileMode) { > - DumpRawProfile( Number2Display, ExcludeMode); > - } > - } else { > - //------------- Begin Cooked Mode Processing > - if (TraceMode) { > - ProcessPhases (); > - if ( ! SummaryMode) { > - Status =3D ProcessHandles ( ExcludeMode); > - if (Status =3D=3D EFI_ABORTED) { > - ShellStatus =3D SHELL_ABORTED; > - goto Done; > - } > - > - Status =3D ProcessPeims (); > - if (Status =3D=3D EFI_ABORTED) { > - ShellStatus =3D SHELL_ABORTED; > - goto Done; > - } > - > - Status =3D ProcessGlobal (); > - if (Status =3D=3D EFI_ABORTED) { > - ShellStatus =3D SHELL_ABORTED; > - goto Done; > - } > - > - ProcessCumulative (NULL); > + > + Status =3D ProcessGlobal (); > + if (Status =3D=3D EFI_ABORTED) { > + ShellStatus =3D SHELL_ABORTED; > + goto Done; > } > - } > - if (ProfileMode) { > - DumpAllProfile( Number2Display, ExcludeMode); > + > + ProcessCumulative (NULL); > } > } //------------- End of Cooked Mode Processing > if ( VerboseMode || SummaryMode) { > DumpStatistics(); > } > diff --git a/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.h b/ShellPkg/Dyn= amicCommand/DpDynamicCommand/Dp.h > index 9fd88578720..aae021334d6 100644 > --- a/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.h > +++ b/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.h > @@ -51,16 +51,10 @@ extern EFI_HANDLE mDpHiiHandle; > * The value assigned to DP_DEBUG controls which debug output > * is generated. Set it to ZERO to disable. > **/ > #define DP_DEBUG 0 >=20 > -/** > - * Set to 1 once Profiling has been implemented in order to enable > - * profiling related options and report output. > -**/ > -#define PROFILING_IMPLEMENTED 0 > - > #define DEFAULT_THRESHOLD 1000 ///< One millisecond. > #define DEFAULT_DISPLAYCOUNT 50 > #define MAXIMUM_DISPLAYCOUNT 999999 ///< Arbitrary maximum reasonabl= e number. >=20 > #define PERF_MAXDUR 0xFFFFFFFFFFFFFFFFULL > @@ -95,11 +89,10 @@ typedef struct { > UINT32 Count; ///< Total number of measurements accumulated. > } PERF_CUM_DATA; >=20 > typedef struct { > UINT32 NumTrace; ///< Number of recorded TRACE = performance measurements. > - UINT32 NumProfile; ///< Number of recorded PROFIL= E performance measurements. > UINT32 NumIncomplete; ///< Number of measurements wi= th no END value. > UINT32 NumSummary; ///< Number of summary section= measurements. > UINT32 NumHandles; ///< Number of measurements wi= th handles. > UINT32 NumPEIMs; ///< Number of measurements of= PEIMs. > UINT32 NumGlobal; ///< Number of measurements wi= th END value and NULL handle. > diff --git a/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.uni b/ShellPkg/D= ynamicCommand/DpDynamicCommand/Dp.uni > index c7eb0fbd71e..ced8a487428 100644 > --- a/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.uni > +++ b/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.uni > @@ -70,19 +70,17 @@ > #string STR_DP_STATS_NUMPHASES #language en-US "%,8d are major = execution phases.\n" > #string STR_DP_STATS_NUMHANDLES #language en-US "%,8d have non-N= ULL handles, %d are NULL.\n" > #string STR_DP_STATS_NUMPEIMS #language en-US "%,8d are PEIMs.= \n" > #string STR_DP_STATS_NUMGLOBALS #language en-US "%,8d are genera= l measurements.\n" > #string STR_DP_STATS_NUMPROFILE #language en-US "%,8d are profil= ing records.\n" > -#string STR_DP_SECTION_PROFILE #language en-US "Sequential Prof= ile Records" > #string STR_DP_SECTION_ALL #language en-US "Sequential Trac= e Records" > #string STR_DP_ALL_HEADR #language en-US "\nIndex Ha= ndle Module > Token Time(us)\n" > #string STR_DP_ALL_VARS #language en-US "%5d:%3s0x%08p %= 36s %13s %L8d\n" > #string STR_DP_ALL_DASHES2 #language en-US > "------------------------------------------------------------------------= -------------\n" > #string STR_DP_ALL_HEADR2 #language en-US "\nIndex Ha= ndle Module > Token Time(us) ID\n" > #string STR_DP_ALL_VARS2 #language en-US "%5d:%3s0x%08p %= 36s %13s %L8d %5d\n" > #string STR_DP_SECTION_RAWTRACE #language en-US "RAW Trace" > -#string STR_DP_SECTION_RAWPROFILE #language en-US "RAW Profile" > #string STR_DP_RAW_DASHES #language en-US > "------------------------------------------------------------------------= ---------------------------------------------------\n" > #string STR_DP_RAW_VARS #language en-US "%5d: %16LX %16L= X %16LX %31a %31a\n" > #string STR_DP_RAW_HEADR #language en-US "\nIndex H= andle Start Count End Count > Token Module\n" > #string STR_DP_RAW_DASHES2 #language en-US > "------------------------------------------------------------------------= ---------------------------------------------------------\n" > #string STR_DP_RAW_VARS2 #language en-US "%5d: %16LX %16L= X %16LX %31a %31a %5d\n" > @@ -96,21 +94,19 @@ > #string STR_GET_HELP_DP #language en-US "" > ".TH dp 0 "Display performance metrics"\r\n" > ".SH NAME\r\n" > "Displays performance metrics that are stored in memory.\r\n" > ".SH SYNOPSIS\r\n" > -"DP [-b] [-v] [-x] [-s | -A | -R] [-T] [-P] [-t value] [-n count] [-c [t= oken]][-i] [-h | -?]\r\n" > +"DP [-b] [-v] [-x] [-s | -A | -R] [-t value] [-n count] [-c [token]][-i]= [-?]\r\n" > ".SH OPTIONS\r\n" > " \r\n" > " -b - Displays on multiple pages\r\n" > " -v - Displays additional information\r\n" > " -x - Prevents display of individual measurements for cumulative= items\r\n" > " -s - Displays summary information only\r\n" > " -A - Displays all measurements in a list\r\n" > " -R - Displays all measurements in raw format\r\n" > -" -T - Displays trace measurements only\r\n" > -" -P - Displays profile measurements only\r\n" > " -t VALUE - Sets display threshold to VALUE microseconds\r\n" > " -n COUNT - Limits display to COUNT lines in All and Raw modes\r\n" > " -i - Displays identifier\r\n" > " -c TOKEN - Display pre-defined and custom cumulative data\r\n" > " Pre-defined cumulative token are:\r\n" > diff --git a/ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.inf > b/ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.inf > index 54fe0017541..cedb333b285 100644 > --- a/ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.inf > +++ b/ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.inf > @@ -31,11 +31,10 @@ > Literals.h > Literals.c > DpInternal.h > DpUtilities.c > DpTrace.c > - DpProfile.c > DpApp.c >=20 > [Packages] > MdePkg/MdePkg.dec > ShellPkg/ShellPkg.dec > diff --git a/ShellPkg/DynamicCommand/DpDynamicCommand/DpDynamicCommand.in= f > b/ShellPkg/DynamicCommand/DpDynamicCommand/DpDynamicCommand.inf > index e906870bd5e..8fd3bbd5df8 100644 > --- a/ShellPkg/DynamicCommand/DpDynamicCommand/DpDynamicCommand.inf > +++ b/ShellPkg/DynamicCommand/DpDynamicCommand/DpDynamicCommand.inf > @@ -32,11 +32,10 @@ > Literals.h > Literals.c > DpInternal.h > DpUtilities.c > DpTrace.c > - DpProfile.c > DpDynamicCommand.c >=20 > [Packages] > MdePkg/MdePkg.dec > ShellPkg/ShellPkg.dec > diff --git a/ShellPkg/DynamicCommand/DpDynamicCommand/DpInternal.h > b/ShellPkg/DynamicCommand/DpDynamicCommand/DpInternal.h > index eedc377cded..8dd3076cc71 100644 > --- a/ShellPkg/DynamicCommand/DpDynamicCommand/DpInternal.h > +++ b/ShellPkg/DynamicCommand/DpDynamicCommand/DpInternal.h > @@ -302,54 +302,6 @@ ProcessGlobal( > VOID > ProcessCumulative( > IN PERF_CUM_DATA *CustomCumulativeData OPTIONAL > ); >=20 > -/** > - Gather and print ALL Profiling Records. > - > - Displays all "interesting" Profile measurements in order. > - The number of records displayed is controlled by: > - - records with a duration less than mInterestThreshold microseconds= are not displayed. > - - No more than Limit records are displayed. A Limit of zero will n= ot limit the output. > - - If the ExcludeFlag is TRUE, records matching entries in the CumDa= ta array are not > - displayed. > - > - @pre The mInterestThreshold global variable is set to the shortest = duration to be printed. > - The mGaugeString and mUnicodeToken global arrays are used for= temporary string storage. > - They must not be in use by a calling function. > - > - @param[in] Limit The number of records to print. Zero is A= LL. > - @param[in] ExcludeFlag TRUE to exclude individual Cumulative item= s from display. > - > -**/ > -VOID > -DumpAllProfile( > - IN UINTN Limit, > - IN BOOLEAN ExcludeFlag > - ); > - > -/** > - Gather and print Raw Profile Records. > - > - All Profile measurements with a duration greater than or equal to > - mInterestThreshold are printed without interpretation. > - > - The number of records displayed is controlled by: > - - records with a duration less than mInterestThreshold microseconds= are not displayed. > - - No more than Limit records are displayed. A Limit of zero will n= ot limit the output. > - - If the ExcludeFlag is TRUE, records matching entries in the CumDa= ta array are not > - displayed. > - > - @pre The mInterestThreshold global variable is set to the shortest = duration to be printed. > - > - @param[in] Limit The number of records to print. Zero is A= LL. > - @param[in] ExcludeFlag TRUE to exclude individual Cumulative item= s from display. > - > -**/ > -VOID > -DumpRawProfile( > - IN UINTN Limit, > - IN BOOLEAN ExcludeFlag > - ); > - > #endif > diff --git a/ShellPkg/DynamicCommand/DpDynamicCommand/DpProfile.c > b/ShellPkg/DynamicCommand/DpDynamicCommand/DpProfile.c > deleted file mode 100644 > index af25217daef..00000000000 > --- a/ShellPkg/DynamicCommand/DpDynamicCommand/DpProfile.c > +++ /dev/null > @@ -1,100 +0,0 @@ > -/** @file > - Measured Profiling reporting for the Dp utility. > - > - Copyright (c) 2009 - 2017, Intel Corporation. All rights reserved. > - This program and the accompanying materials > - are licensed and made available under the terms and conditions of the = BSD License > - which accompanies this distribution. The full text of the license may= be found at > - http://opensource.org/licenses/bsd-license.php > - > - THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > - WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR I= MPLIED. > -**/ > - > -#include > -#include > -#include > -#include > -#include > -#include > -#include > -#include > -#include > -#include > - > -#include > - > -#include "Dp.h" > -#include "Literals.h" > -#include "DpInternal.h" > - > -/** > - Gather and print ALL Profiling Records. > - > - Displays all "interesting" Profile measurements in order. > - The number of records displayed is controlled by: > - - records with a duration less than mInterestThreshold microseconds= are not displayed. > - - No more than Limit records are displayed. A Limit of zero will n= ot limit the output. > - - If the ExcludeFlag is TRUE, records matching entries in the CumDa= ta array are not > - displayed. > - > - @pre The mInterestThreshold global variable is set to the shortest = duration to be printed. > - The mGaugeString and mUnicodeToken global arrays are used for= temporary string storage. > - They must not be in use by a calling function. > - > - @param[in] Limit The number of records to print. Zero is A= LL. > - @param[in] ExcludeFlag TRUE to exclude individual Cumulative item= s from display. > - > -**/ > -VOID > -DumpAllProfile( > - IN UINTN Limit, > - IN BOOLEAN ExcludeFlag > - ) > -{ > - EFI_STRING StringPtr; > - EFI_STRING StringPtrUnknown; > - > - StringPtrUnknown =3D HiiGetString (mDpHiiHandle, STRING_TOKEN (STR_ALI= T_UNKNOWN), NULL); > - StringPtr =3D HiiGetString (mDpHiiHandle, STRING_TOKEN (STR_DP_SECTION= _PROFILE), NULL); > - > - ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN (STR_DP_SECTION_HEADER), m= DpHiiHandle, > - (StringPtr =3D=3D NULL) ? StringPtrUnknown: StringPtr); > - FreePool (StringPtr); > - FreePool (StringPtrUnknown); > -} > - > -/** > - Gather and print Raw Profile Records. > - > - All Profile measurements with a duration greater than or equal to > - mInterestThreshold are printed without interpretation. > - > - The number of records displayed is controlled by: > - - records with a duration less than mInterestThreshold microseconds= are not displayed. > - - No more than Limit records are displayed. A Limit of zero will n= ot limit the output. > - - If the ExcludeFlag is TRUE, records matching entries in the CumDa= ta array are not > - displayed. > - > - @pre The mInterestThreshold global variable is set to the shortest = duration to be printed. > - > - @param[in] Limit The number of records to print. Zero is A= LL. > - @param[in] ExcludeFlag TRUE to exclude individual Cumulative item= s from display. > - > -**/ > -VOID > -DumpRawProfile( > - IN UINTN Limit, > - IN BOOLEAN ExcludeFlag > - ) > -{ > - EFI_STRING StringPtr; > - EFI_STRING StringPtrUnknown; > - > - StringPtrUnknown =3D HiiGetString (mDpHiiHandle, STRING_TOKEN (STR_ALI= T_UNKNOWN), NULL); > - StringPtr =3D HiiGetString (mDpHiiHandle, STRING_TOKEN (STR_DP_SECTION= _RAWPROFILE), NULL); > - ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN (STR_DP_SECTION_HEADER), m= DpHiiHandle, > - (StringPtr =3D=3D NULL) ? StringPtrUnknown: StringPtr); > - FreePool (StringPtr); > - FreePool (StringPtrUnknown); > -} > -- > 2.14.3.windows.1