From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.93; helo=mga11.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 4DD67211B76A3 for ; Wed, 13 Jun 2018 23:11:28 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Jun 2018 23:11:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,222,1526367600"; d="scan'208";a="48889794" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga007.jf.intel.com with ESMTP; 13 Jun 2018 23:11:27 -0700 Received: from fmsmsx101.amr.corp.intel.com (10.18.124.199) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 13 Jun 2018 23:11:27 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx101.amr.corp.intel.com (10.18.124.199) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 13 Jun 2018 23:11:26 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.87]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.70]) with mapi id 14.03.0319.002; Thu, 14 Jun 2018 14:11:19 +0800 From: "Gao, Liming" To: "Zhu, Yonghong" , "edk2-devel@lists.01.org" Thread-Topic: [edk2] [Patch] BaseTools: remove including Base.h if the module type is not BASE Thread-Index: AQHUAhhHqpGMAZ1w/UGn6nbXVCKIFaRfSMjA Date: Thu, 14 Jun 2018 06:11:18 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E297658@SHSMSX104.ccr.corp.intel.com> References: <1528785626-12904-1-git-send-email-yonghong.zhu@intel.com> In-Reply-To: <1528785626-12904-1-git-send-email-yonghong.zhu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzlhZjJhMzAtNWVhYy00NmVmLTg5ZjctNzBhYzI3NjIyOTRlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiWE1RWEpuRFRPZVNsNm9ScVZWT0VnK0ZldkdlZHJKWkFPRVZvZElPbFp1Y25IME9JaHNkWTB1V1ZWRFVSaXVwNSJ9 dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] BaseTools: remove including Base.h if the module type is not BASE X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Jun 2018 06:11:28 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Yo= nghong Zhu > Sent: Tuesday, June 12, 2018 2:40 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [Patch] BaseTools: remove including Base.h if the module = type is not BASE >=20 > According the module type to include the header file. >=20 > Fixes: https://bugzilla.tianocore.org/show_bug.cgi?id=3D867 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Yonghong Zhu > --- > BaseTools/Source/Python/AutoGen/GenC.py | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) >=20 > diff --git a/BaseTools/Source/Python/AutoGen/GenC.py b/BaseTools/Source/P= ython/AutoGen/GenC.py > index 1be27d2..19ed196 100644 > --- a/BaseTools/Source/Python/AutoGen/GenC.py > +++ b/BaseTools/Source/Python/AutoGen/GenC.py > @@ -2011,13 +2011,11 @@ def CreateHeaderCode(Info, AutoGenC, AutoGenH): > # header file Prologue > AutoGenH.Append(gAutoGenHPrologueString.Replace({'File':'AUTOGENH','= Guid':Info.Guid.replace('-','_')})) > AutoGenH.Append(gAutoGenHCppPrologueString) > if Info.AutoGenVersion >=3D 0x00010005: > # header files includes > - AutoGenH.Append("#include <%s>\n" % gBasicHeaderFile) > - if Info.ModuleType in gModuleTypeHeaderFile \ > - and gModuleTypeHeaderFile[Info.ModuleType][0] !=3D gBasicHead= erFile: > + if Info.ModuleType in gModuleTypeHeaderFile: > AutoGenH.Append("#include <%s>\n" % gModuleTypeHeaderFile[In= fo.ModuleType][0]) > # > # if either PcdLib in [LibraryClasses] sections or there exist P= cd section, add PcdLib.h > # As if modules only uses FixedPcd, then PcdLib is not needed in= [LibraryClasses] section. > # > -- > 2.6.1.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel