From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.20; helo=mga02.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id BFD82210C1ED9 for ; Mon, 18 Jun 2018 07:47:40 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Jun 2018 07:47:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,239,1526367600"; d="scan'208";a="48613230" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga008.fm.intel.com with ESMTP; 18 Jun 2018 07:47:39 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 18 Jun 2018 07:47:39 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.87]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.116]) with mapi id 14.03.0319.002; Mon, 18 Jun 2018 22:47:36 +0800 From: "Gao, Liming" To: Laszlo Ersek , Ard Biesheuvel , "edk2-devel@lists.01.org" Thread-Topic: [edk2] [PATCH] BaseTools/tools_def IA32: drop -no-pie linker option for GCC49 Thread-Index: AQHUBt5BBkWCIuuxc0SK9gL8UBKp3aRlcFUAgACniPA= Date: Mon, 18 Jun 2018 14:47:35 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E29839E@SHSMSX104.ccr.corp.intel.com> References: <20180618082748.30067-1-ard.biesheuvel@linaro.org> <66c6420b-b874-4ac0-880b-3e83f63ef81b@redhat.com> In-Reply-To: <66c6420b-b874-4ac0-880b-3e83f63ef81b@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiY2RiM2Y5ZDItMzZjZC00MmI5LTg3ZGItZTU5MGU2OTk0NGE2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoicktLd3dZNnNLNGxuK0lIQVVsb00yaEtSQ3JkSERcL3VUMzBWQnFmWmFTY0dyOXZCWThtQWJpWjRsTjdGZXJzbU8ifQ== dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] BaseTools/tools_def IA32: drop -no-pie linker option for GCC49 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Jun 2018 14:47:40 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Our build machine uses GCC4.9.2. I expect GCC49 can work on all GCC49 versi= on.=20 Reviewed-by: Liming Gao Thanks Liming > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of La= szlo Ersek > Sent: Monday, June 18, 2018 8:44 PM > To: Ard Biesheuvel ; edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: Re: [edk2] [PATCH] BaseTools/tools_def IA32: drop -no-pie linker= option for GCC49 >=20 > On 06/18/18 10:27, Ard Biesheuvel wrote: > > As reported by Liming, GCC 4.9.2 does not support the -no-pie > > linker option that we added to the GCC49 and GCC5 toolchain > > profiles in commit c25d3905523a ("BaseTools/tools_def IA32: > > disable PIE code generation explicitly") to work around issues > > with recent distro toolchains that enable PIE code generation > > by default. > > > > So rollback the changes for GCC49 but preserve them for GCC5 > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Ard Biesheuvel > > --- > > BaseTools/Conf/tools_def.template | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_d= ef.template > > index 733c6ec71709..ab57f9c706e3 100755 > > --- a/BaseTools/Conf/tools_def.template > > +++ b/BaseTools/Conf/tools_def.template > > @@ -4648,7 +4648,7 @@ DEFINE GCC48_AARCH64_DLINK2_FLAGS =3D DEF(GCC4= 7_AARCH64_DLINK2_FLAGS) > > DEFINE GCC48_ARM_ASLDLINK_FLAGS =3D DEF(GCC47_ARM_ASLDLINK_FLAGS) > > DEFINE GCC48_AARCH64_ASLDLINK_FLAGS =3D DEF(GCC47_AARCH64_ASLDLINK_FL= AGS) > > > > -DEFINE GCC49_IA32_CC_FLAGS =3D DEF(GCC48_IA32_CC_FLAGS) -fno= -pic -fno-pie > > +DEFINE GCC49_IA32_CC_FLAGS =3D DEF(GCC48_IA32_CC_FLAGS) > > DEFINE GCC49_X64_CC_FLAGS =3D DEF(GCC48_X64_CC_FLAGS) > > DEFINE GCC49_IA32_X64_DLINK_COMMON =3D -nostdlib -Wl,-n,-q,--gc-sect= ions -z common-page-size=3D0x40 > > DEFINE GCC49_IA32_X64_ASLDLINK_FLAGS =3D DEF(GCC49_IA32_X64_DLINK_COMM= ON) -Wl,--entry,ReferenceAcpiTable -u > ReferenceAcpiTable > > @@ -4670,7 +4670,7 @@ DEFINE GCC49_AARCH64_DLINK2_FLAGS =3D DEF(GCC4= 8_AARCH64_DLINK2_FLAGS) > > DEFINE GCC49_ARM_ASLDLINK_FLAGS =3D DEF(GCC48_ARM_ASLDLINK_FLAGS) > > DEFINE GCC49_AARCH64_ASLDLINK_FLAGS =3D DEF(GCC48_AARCH64_ASLDLINK_FL= AGS) > > > > -DEFINE GCC5_IA32_CC_FLAGS =3D DEF(GCC49_IA32_CC_FLAGS) > > +DEFINE GCC5_IA32_CC_FLAGS =3D DEF(GCC49_IA32_CC_FLAGS) -fno= -pic -fno-pie > > DEFINE GCC5_X64_CC_FLAGS =3D DEF(GCC49_X64_CC_FLAGS) > > DEFINE GCC5_IA32_X64_DLINK_COMMON =3D DEF(GCC49_IA32_X64_DLINK_COMM= ON) > > DEFINE GCC5_IA32_X64_ASLDLINK_FLAGS =3D DEF(GCC49_IA32_X64_ASLDLINK_F= LAGS) > > @@ -5357,10 +5357,10 @@ RELEASE_GCC48_AARCH64_CC_FLAGS =3D DEF(GCC48_= AARCH64_CC_FLAGS) -Wno-unused-but-s > > *_GCC49_IA32_RC_PATH =3D DEF(GCC49_IA32_PREFIX)objcopy > > > > *_GCC49_IA32_ASLCC_FLAGS =3D DEF(GCC_ASLCC_FLAGS) -m32 > > -*_GCC49_IA32_ASLDLINK_FLAGS =3D DEF(GCC49_IA32_X64_ASLDLINK_FLAG= S) -Wl,-m,elf_i386 -no-pie > > +*_GCC49_IA32_ASLDLINK_FLAGS =3D DEF(GCC49_IA32_X64_ASLDLINK_FLAG= S) -Wl,-m,elf_i386 > > *_GCC49_IA32_ASM_FLAGS =3D DEF(GCC49_ASM_FLAGS) -m32 -march= =3Di386 > > *_GCC49_IA32_DLINK_FLAGS =3D DEF(GCC49_IA32_X64_DLINK_FLAGS) = -Wl,-m,elf_i386,--oformat=3Delf32-i386 > > -*_GCC49_IA32_DLINK2_FLAGS =3D DEF(GCC49_IA32_DLINK2_FLAGS) -no= -pie > > +*_GCC49_IA32_DLINK2_FLAGS =3D DEF(GCC49_IA32_DLINK2_FLAGS) > > *_GCC49_IA32_RC_FLAGS =3D DEF(GCC_IA32_RC_FLAGS) > > *_GCC49_IA32_OBJCOPY_FLAGS =3D > > *_GCC49_IA32_NASM_FLAGS =3D -f elf32 > > >=20 > The latest release in the gcc-4.9 series is 4.9.4, according to the > online docs, not 4.9.2. Perhaps rechecking with 4.9.4 would make sense; > I'm not sure. Anyway, >=20 > Acked-by: Laszlo Ersek >=20 > Thanks! > Laszlo > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel