From: "Gao, Liming" <liming.gao@intel.com>
To: "Marvin.Haeuser@outlook.com" <Marvin.Haeuser@outlook.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [PATCH] MdePkg/UefiDebugLibConOut: Explicitely consume UefiLib.
Date: Mon, 18 Jun 2018 14:57:03 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E2983B1@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <VI1PR0801MB1790949CC8DD70F39AE00C4680730@VI1PR0801MB1790.eurprd08.prod.outlook.com>
UefiDebugLibConOut depends on PrintLib. It doesn't call any API in UefiLib.
> -----Original Message-----
> From: Marvin Häuser [mailto:Marvin.Haeuser@outlook.com]
> Sent: Sunday, June 17, 2018 12:15 AM
> To: edk2-devel@lists.01.org
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>
> Subject: [PATCH] MdePkg/UefiDebugLibConOut: Explicitely consume UefiLib.
>
> UefiDebugLibConOut does currently not consume UefiLib, from which it
> uses the Print() function. This commit adds an explicit dependency.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Marvin Haeuser <Marvin.Haeuser@outlook.com>
> ---
> MdePkg/Library/UefiDebugLibConOut/UefiDebugLibConOut.inf | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/MdePkg/Library/UefiDebugLibConOut/UefiDebugLibConOut.inf
> b/MdePkg/Library/UefiDebugLibConOut/UefiDebugLibConOut.inf
> index 583872f54e81..64651c4169a8 100644
> --- a/MdePkg/Library/UefiDebugLibConOut/UefiDebugLibConOut.inf
> +++ b/MdePkg/Library/UefiDebugLibConOut/UefiDebugLibConOut.inf
> @@ -46,6 +46,7 @@ [LibraryClasses]
> PrintLib
> UefiBootServicesTableLib
> DebugPrintErrorLevelLib
> + UefiLib
>
> [Pcd]
> gEfiMdePkgTokenSpaceGuid.PcdDebugClearMemoryValue ## SOMETIMES_CONSUMES
> --
> 2.17.1.windows.2
next prev parent reply other threads:[~2018-06-18 14:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <82083b2c0427eb12806fb9e1ba5e806ea21e5b50.1529165460.git.Marvin.Haeuser@outlook.com>
2018-06-16 16:15 ` [PATCH] MdePkg/UefiDebugLibConOut: Explicitely consume UefiLib Marvin Häuser
2018-06-18 14:57 ` Gao, Liming [this message]
2018-06-18 15:49 ` Marvin Häuser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E2983B1@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox