From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.20; helo=mga02.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 263EE20974132 for ; Mon, 18 Jun 2018 21:48:51 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Jun 2018 21:48:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,241,1526367600"; d="scan'208";a="65283663" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga001.fm.intel.com with ESMTP; 18 Jun 2018 21:48:50 -0700 Received: from fmsmsx151.amr.corp.intel.com (10.18.125.4) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 18 Jun 2018 21:48:50 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX151.amr.corp.intel.com (10.18.125.4) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 18 Jun 2018 21:48:43 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.87]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.51]) with mapi id 14.03.0319.002; Tue, 19 Jun 2018 12:48:42 +0800 From: "Gao, Liming" To: "Wu, Hao A" , "edk2-devel@lists.01.org" CC: "Wu, Hao A" , "Kinney, Michael D" , Younas Khan , "Yao, Jiewen" Thread-Topic: [edk2] [RFC PATCH v1 0/2] Update and refine the IPMI header files Thread-Index: AQHT/HwjD/1faqdm6EOhGzeH3nTNH6RnGJSw Date: Tue, 19 Jun 2018 04:48:41 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E2989CE@SHSMSX104.ccr.corp.intel.com> References: <20180605032010.25104-1-hao.a.wu@intel.com> In-Reply-To: <20180605032010.25104-1-hao.a.wu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [RFC PATCH v1 0/2] Update and refine the IPMI header files X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Jun 2018 04:48:51 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao >-----Original Message----- >From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Hao >Wu >Sent: Tuesday, June 05, 2018 11:20 AM >To: edk2-devel@lists.01.org >Cc: Wu, Hao A ; Kinney, Michael D >; Younas Khan >; Yao, Jiewen ; >Gao, Liming >Subject: [edk2] [RFC PATCH v1 0/2] Update and refine the IPMI header files > >This series will: >a. Update the IPMI header files with the spec Intelligent Platform > Management Interface Specification Second Generation v2.0 Document > Revision 1.1 (October 1, 2013). >b. Refine those header files to use 'union' types for bitmap fields within > structure definitions, so that both bit-level and byte/word-level > accesses are provided. > >The series is also available at: >https://github.com/hwu25/edk2/tree/ipmi_header_update > > >Please note that this series makes some incompatible changes: > >a. For structure definition IPMI_EMP_DESTINATION_COM_SETTING: >Removes fields 'SaveSetting', 'SetComPort' and 'Reserved3' according to >IPMI v2.0 spec Table 25-4. > >b. For structure definition >IPMI_SET_SERIAL_MODEM_MUX_COMMAND_RESPONSE: >Add missing field 'CompletionCode' according to IPMI v2.0 spec Table 25-5. > >c. For structure definition IPMI_BOOT_OPTIONS_RESPONSE_PARAMETER_5: >Update data 1, 4 and 5 according to IPMI v2.0 spec Table 28-14. > >d. Add byte-word-level access for structures with bitmap fields. > >But we cannot find any active users for those IPMI header files, and we >are lacking of means to perform functional tests for the changes within >this series. > >If there is active users for these header files, help for the functional >test for this patch series will be very appreciated. > >Cc: Younas Khan >Cc: Michael Kinney >Cc: Liming Gao >Cc: Jiewen Yao > >Hao Wu (2): > MdePkg/IndustryStandard/Ipmi: Update IPMI header files > MdePkg/IndustryStandard/Ipmi: Use union for bitmap fields > > MdePkg/Include/IndustryStandard/Ipmi.h | 34 +- > MdePkg/Include/IndustryStandard/IpmiFruInformationStorage.h | 92 +++ > MdePkg/Include/IndustryStandard/IpmiNetFnApp.h | 546 >++++++++++++++++-- > MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h | 327 >++++++++--- > MdePkg/Include/IndustryStandard/IpmiNetFnStorage.h | 579 >+++++++++++++------ > MdePkg/Include/IndustryStandard/IpmiNetFnTransport.h | 603 >+++++++++++++++----- > 6 files changed, 1734 insertions(+), 447 deletions(-) > create mode 100644 >MdePkg/Include/IndustryStandard/IpmiFruInformationStorage.h > >-- >2.12.0.windows.1 > >_______________________________________________ >edk2-devel mailing list >edk2-devel@lists.01.org >https://lists.01.org/mailman/listinfo/edk2-devel