From: "Gao, Liming" <liming.gao@intel.com>
To: "Feng, Bob C" <bob.c.feng@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [Patch] BaseTool: Fixed the bug of Boolean Hii Pcd packing.
Date: Tue, 19 Jun 2018 08:15:20 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E298D00@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20180614030123.55508-1-bob.c.feng@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
>-----Original Message-----
>From: Feng, Bob C
>Sent: Thursday, June 14, 2018 11:01 AM
>To: edk2-devel@lists.01.org
>Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <liming.gao@intel.com>
>Subject: [Patch] BaseTool: Fixed the bug of Boolean Hii Pcd packing.
>
>When packing HiiPcd into PcdNvStoreDefaultValueBuffer,
>The boolean type pcd value packing incorrect.
>
>Contributed-under: TianoCore Contribution Agreement 1.1
>Signed-off-by: Bob Feng <bob.c.feng@intel.com>
>Cc: Liming Gao <liming.gao@intel.com>
>---
> BaseTools/Source/Python/AutoGen/GenVar.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/BaseTools/Source/Python/AutoGen/GenVar.py
>b/BaseTools/Source/Python/AutoGen/GenVar.py
>index 3675be8de9..bf3d225c21 100644
>--- a/BaseTools/Source/Python/AutoGen/GenVar.py
>+++ b/BaseTools/Source/Python/AutoGen/GenVar.py
>@@ -294,11 +294,11 @@ class VariableMgr(object):
> if tail:
> for value_char in tail.split(","):
> Buffer += pack("=B",int(value_char,16))
> data_len += len(tail.split(","))
> elif data_type == "BOOLEAN":
>- Buffer += pack("=B",True) if var_value.upper() == "TRUE" else
>pack("=B",False)
>+ Buffer += pack("=B",True) if var_value.upper() in ["TRUE","1"] else
>pack("=B",False)
> data_len += 1
> elif data_type == DataType.TAB_UINT8:
> Buffer += pack("=B",GetIntegerValue(var_value))
> data_len += 1
> elif data_type == DataType.TAB_UINT16:
>--
>2.16.2.windows.1
prev parent reply other threads:[~2018-06-19 8:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-14 3:01 [Patch] BaseTool: Fixed the bug of Boolean Hii Pcd packing BobCF
2018-06-19 8:15 ` Gao, Liming [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E298D00@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox