From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.115; helo=mga14.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2839C211DB426 for ; Thu, 21 Jun 2018 01:00:26 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Jun 2018 01:00:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,251,1526367600"; d="scan'208";a="59035259" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by FMSMGA003.fm.intel.com with ESMTP; 21 Jun 2018 01:00:25 -0700 Received: from fmsmsx157.amr.corp.intel.com (10.18.116.73) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 21 Jun 2018 01:00:25 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX157.amr.corp.intel.com (10.18.116.73) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 21 Jun 2018 01:00:25 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.87]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.116]) with mapi id 14.03.0319.002; Thu, 21 Jun 2018 16:00:23 +0800 From: "Gao, Liming" To: "Zhu, Yonghong" , "edk2-devel@lists.01.org" Thread-Topic: [edk2] [Patch] BaseTools: remove the unneeded code Thread-Index: AQHUArPBnUiGIAlY20yvAnArlpPI/6RqZmLg Date: Thu, 21 Jun 2018 08:00:22 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E29C3C3@SHSMSX104.ccr.corp.intel.com> References: <1528852396-11312-1-git-send-email-yonghong.zhu@intel.com> In-Reply-To: <1528852396-11312-1-git-send-email-yonghong.zhu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] BaseTools: remove the unneeded code X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Jun 2018 08:00:27 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao >-----Original Message----- >From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Zhu= , >Yonghong >Sent: Wednesday, June 13, 2018 9:13 AM >To: edk2-devel@lists.01.org >Subject: [edk2] [Patch] BaseTools: remove the unneeded code > >Do a clean up to remove the unneeded code. > >Contributed-under: TianoCore Contribution Agreement 1.1 >Signed-off-by: Yonghong Zhu >--- > BaseTools/Source/Python/Workspace/MetaFileParser.py | 17 ----------------= - > 1 file changed, 17 deletions(-) > >diff --git a/BaseTools/Source/Python/Workspace/MetaFileParser.py >b/BaseTools/Source/Python/Workspace/MetaFileParser.py >index a2ded0c..71da731 100644 >--- a/BaseTools/Source/Python/Workspace/MetaFileParser.py >+++ b/BaseTools/Source/Python/Workspace/MetaFileParser.py >@@ -1549,27 +1549,10 @@ class DscParser(MetaFileParser): > Parser =3D DscParser(IncludedFile1, self._FileType, self._Arc= h, >IncludedFileTable, > Owner=3DOwner, From=3DFromItem) > > self.IncludedFiles.add (IncludedFile1) > >- # todo: rework the nested include checking logic >- # Current nested include checking rely on dsc file order insi= de build.db. >- # It is not reliable and will lead to build fail in some case= . >- # >- # When project A and B include a common dsc file C. >- # Build project A. It give dsc file A =3D ID 1 in build.db, a= nd C ID =3D 2. >- # Build project B. It give dsc file B ID =3D 3, and C ID stil= l =3D 2. >- # Then, we build project B fail, unless we clean build.db. >- # In oldder BaseTools, the project B ID will still be 1, >- # that's why it work before. >- >- # Does not allow lower level included file to include upper l= evel >included file >- #if Parser._From !=3D Owner and int(Owner) > int (Parser._Fro= m): >- # EdkLogger.error('parser', FILE_ALREADY_EXIST, >File=3Dself._FileWithError, >- # Line=3Dself._LineIndex + 1, ExtraData=3D"{0} is alrea= dy included at a >higher level.".format(IncludedFile1)) >- >- > # set the parser status with current status > Parser._SectionName =3D self._SectionName > if self._InSubsection: > Parser._SectionType =3D self._SubsectionType > else: >-- >2.6.1.windows.1 > >_______________________________________________ >edk2-devel mailing list >edk2-devel@lists.01.org >https://lists.01.org/mailman/listinfo/edk2-devel