From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.100; helo=mga07.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id AAAE6210DA78C for ; Thu, 21 Jun 2018 18:56:10 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Jun 2018 18:56:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,255,1526367600"; d="scan'208";a="49625738" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga008.fm.intel.com with ESMTP; 21 Jun 2018 18:56:09 -0700 Received: from fmsmsx115.amr.corp.intel.com (10.18.116.19) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 21 Jun 2018 18:56:09 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx115.amr.corp.intel.com (10.18.116.19) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 21 Jun 2018 18:56:09 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.87]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.70]) with mapi id 14.03.0319.002; Fri, 22 Jun 2018 09:56:07 +0800 From: "Gao, Liming" To: Chris Co , "edk2-devel@lists.01.org" CC: "Zhu, Yonghong" , Leif Lindholm Thread-Topic: [PATCH v1 1/1] BaseTools/tools_def: Add WINGCC49 support Thread-Index: AQHUCCT9nmcT+HCc9k2mgXh7GcNeB6RqJPUQgADVPwCAAI2YsA== Date: Fri, 22 Jun 2018 01:56:07 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E29C980@SHSMSX104.ccr.corp.intel.com> References: <20180619232602.2200-1-christopher.co@microsoft.com> <20180619232602.2200-2-christopher.co@microsoft.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E29C0F7@SHSMSX104.ccr.corp.intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNGUyNTExNzQtMmQ1MS00NTczLWE4YmUtN2M5MzAxNDRlOTA2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiMHlqTmUyZEdheVhzdTc2Q1dhVUxMUVwvTXNwc2YwdjAxK1FObFVUdCtIXC9LVUYwSlFRUjQyTTNQK3pYS3ZIM2kxIn0= dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v1 1/1] BaseTools/tools_def: Add WINGCC49 support X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Jun 2018 01:56:10 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Yes. GCC49_ARM_PREFIX can be reused. The difference in GCC49 and GCC49xASL = is ASL compiler. Their GCC part is same.=20 > -----Original Message----- > From: Chris Co [mailto:Christopher.Co@microsoft.com] > Sent: Friday, June 22, 2018 9:28 AM > To: Gao, Liming ; edk2-devel@lists.01.org > Cc: Zhu, Yonghong ; Leif Lindholm > Subject: RE: [PATCH v1 1/1] BaseTools/tools_def: Add WINGCC49 support >=20 > > -----Original Message----- > > From: Gao, Liming > > Sent: Wednesday, June 20, 2018 9:56 PM > > To: Chris Co ; edk2-devel@lists.01.org > > Cc: Zhu, Yonghong ; Leif Lindholm > > > > Subject: RE: [PATCH v1 1/1] BaseTools/tools_def: Add WINGCC49 support > > > > Chris: > > I suggest to name this tool chain as GCC49xASL and align to other ASL= tool > > chain, such as VS2015xASL. > > And, ASL_PATH can be set to DEF(WIN_ASL_BIN). WINGCC49_ARM_PREFIX > > is not required. GCC49_ARM_PREFIX can still be used. > > > > Besides, please add this tool chain introduction in file header, like > > VS2015xASL. Then, other people can know how to set up the environment > > and use this tool chain. > > >=20 > Thanks for the feedback Liming. > Just confirming - should I still use GCC49_ARM_PREFIX? I thought the con= vention was {TOOL_CHAIN_TAG}_{ARCHITECTURE}_PREFIX > where TOOL_CHAIN_TAG=3DGCC49xASL. >=20 > > Thanks > > Liming > > >-----Original Message----- > > >From: Chris Co [mailto:Christopher.Co@microsoft.com] > > >Sent: Wednesday, June 20, 2018 7:27 AM > > >To: edk2-devel@lists.01.org > > >Cc: Zhu, Yonghong ; Gao, Liming > > >; Leif Lindholm > > >Subject: [PATCH v1 1/1] BaseTools/tools_def: Add WINGCC49 support > > > > > >From: Chris Co > > > > > >This patch adds a build option for invoking GCC49 ARM cross compiler i= n > > >the Windows environment to build firmware for Windows 10 IoT devices > > >using NXP i.MX6 and i.MX7 SoCs. > > > > > >In addition, this build option targets the Microsoft ASL compiler > > >instead of iasl. The Microsoft ASL compiler is necessary to expose > > >Windows-specific Pin Function Config Descriptors on Windows IoT > > >devices. > > > > > >Contributed-under: TianoCore Contribution Agreement 1.1 > > >Signed-off-by: Christopher Co > > >Cc: Yonghong Zhu > > >Cc: Liming Gao > > >Cc: Leif Lindholm > > >--- > > > BaseTools/Conf/tools_def.template | 55 ++++++++++++++++++++ > > > 1 file changed, 55 insertions(+) > > > > > >diff --git a/BaseTools/Conf/tools_def.template > > >b/BaseTools/Conf/tools_def.template > > >index 11a79029b890..192732a677af 100755 > > >--- a/BaseTools/Conf/tools_def.template > > >+++ b/BaseTools/Conf/tools_def.template > > >@@ -5468,6 +5468,61 @@ RELEASE_GCC49_AARCH64_DLINK_FLAGS =3D > > >DEF(GCC49_AARCH64_DLINK_FLAGS) > > > > > > > > >######################################################### > > ## > > >######################### > > > # > > >+# WINGCC 4.9 - This configuration is used to compile under Windows to > > >produce > > >+# PE/COFF binaries using GCC 4.9. > > >+# > > >+######################################################## > > ## > > >########################## > > >+*_WINGCC49_*_*_FAMILY =3D GCC > > >+ > > >+*_WINGCC49_*_MAKE_PATH =3D DEF(GCC_HOST_PREFIX)mak= e > > >+*_WINGCC49_*_*_DLL =3D ENV(GCC49_DLL) > > >+*_WINGCC49_*_ASL_PATH =3D asl.exe > > >+ > > >+*_WINGCC49_*_PP_FLAGS =3D DEF(GCC_PP_FLAGS) > > >+*_WINGCC49_*_ASLPP_FLAGS =3D DEF(GCC_ASLPP_FLAGS) > > >+*_WINGCC49_*_ASLCC_FLAGS =3D DEF(GCC_ASLCC_FLAGS) > > >+*_WINGCC49_*_VFRPP_FLAGS =3D DEF(GCC_VFRPP_FLAGS) > > >+*_WINGCC49_*_APP_FLAGS =3D > > >+*_WINGCC49_*_ASL_FLAGS =3D /MsftInternal > > >+*_WINGCC49_*_ASL_OUTFLAGS =3D DEF(MS_ASL_OUTFLAGS) > > >+ > > >+################## > > >+# WINGCC49 ARM definitions > > >+################## > > >+*_WINGCC49_ARM_OBJCOPY_PATH =3D noop > > >+*_WINGCC49_ARM_CC_PATH =3D ENV(WINGCC49_ARM_PREFIX)gcc > > >+*_WINGCC49_ARM_SLINK_PATH =3D ENV(WINGCC49_ARM_PREFIX)ar > > >+*_WINGCC49_ARM_DLINK_PATH =3D > > ENV(WINGCC49_ARM_PREFIX)gcc > > >+*_WINGCC49_ARM_ASLDLINK_PATH =3D > > >ENV(WINGCC49_ARM_PREFIX)gcc > > >+*_WINGCC49_ARM_ASM_PATH =3D > > ENV(WINGCC49_ARM_PREFIX)gcc > > >+*_WINGCC49_ARM_PP_PATH =3D ENV(WINGCC49_ARM_PREFIX)gcc > > >+*_WINGCC49_ARM_VFRPP_PATH =3D > > ENV(WINGCC49_ARM_PREFIX)gcc > > >+*_WINGCC49_ARM_ASLCC_PATH =3D > > ENV(WINGCC49_ARM_PREFIX)gcc > > >+*_WINGCC49_ARM_ASLPP_PATH =3D > > ENV(WINGCC49_ARM_PREFIX)gcc > > >+*_WINGCC49_ARM_RC_PATH =3D > > >ENV(WINGCC49_ARM_PREFIX)objcopy > > >+*_WINGCC49_ARM_SYMRENAME_PATH =3D noop > > >+ > > >+*_WINGCC49_ARM_ARCHCC_FLAGS =3D -mthumb > > >+*_WINGCC49_ARM_PLATFORM_FLAGS =3D -march=3Darmv7-a > > >+ > > >+*_WINGCC49_ARM_ASLCC_FLAGS =3D DEF(GCC_ASLCC_FLAGS) > > >+*_WINGCC49_ARM_ASLDLINK_FLAGS =3D > > >DEF(GCC49_ARM_ASLDLINK_FLAGS) > > >+*_WINGCC49_ARM_ASM_FLAGS =3D DEF(GCC49_ARM_ASM_FLAGS) > > >+*_WINGCC49_ARM_DLINK_FLAGS =3D > > DEF(GCC49_ARM_DLINK_FLAGS) > > >+*_WINGCC49_ARM_DLINK2_FLAGS =3D > > DEF(GCC49_ARM_DLINK2_FLAGS) > > >+*_WINGCC49_ARM_DTCPP_FLAGS =3D DEF(GCC_DTCPP_FLAGS) > > >+*_WINGCC49_ARM_PLATFORM_FLAGS =3D -march=3Darmv7-a > > >+*_WINGCC49_ARM_PP_FLAGS =3D $(ARCHCC_FLAGS) > > >$(PLATFORM_FLAGS) DEF(GCC_PP_FLAGS) > > >+*_WINGCC49_ARM_RC_FLAGS =3D DEF(GCC_ARM_RC_FLAGS) > > >+*_WINGCC49_ARM_VFRPP_FLAGS =3D $(ARCHCC_FLAGS) > > >$(PLATFORM_FLAGS) DEF(GCC_VFRPP_FLAGS) > > >+*_WINGCC49_ARM_CC_XIPFLAGS =3D > > DEF(GCC49_ARM_CC_XIPFLAGS) > > >+ > > >+ DEBUG_WINGCC49_ARM_CC_FLAGS =3D DEF(GCC49_ARM_CC_FLAGS) > > - > > >O0 > > >+RELEASE_WINGCC49_ARM_CC_FLAGS =3D DEF(GCC49_ARM_CC_FLAGS) > > - > > >Wno-unused-but-set-variable -Wno-unused-const-variable > > >+ NOOPT_WINGCC49_ARM_CC_FLAGS =3D DEF(GCC49_ARM_CC_FLAGS) > > - > > >O0 > > >+ > > >+######################################################## > > ## > > >########################## > > >+# > > > # GCC 5 - This configuration is used to compile under Linux to produc= e > > > # PE/COFF binaries using GCC 5 > > > # > > >-- > > >2.7.4