Re: [PATCH v2 1/1] BaseTools/tools_def: Add GCC49xASL Toolchain support

["Gao, Liming" <liming.gao@intel.com>]

Ard:
  The commit log message says that the Microsoft ASL compiler is necessary to expose Windows-specific Pin Function Config Descriptors on Windows IoT devices.

  Besides, there is no ways to configure tool chain with the parameter in build command. But, tool chain ASL path and flag can be overridden in [BuildOptions] of platform DSC file. Another way is to provide the generic DSC file to include MS ASL option setting in [BuildOptions] section. Platform DSC can decide to include it or not. 

Thanks
Liming
>-----Original Message-----
>From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]
>Sent: Monday, June 25, 2018 3:34 PM
>To: Gao, Liming <liming.gao@intel.com>
>Cc: Chris Co <Christopher.Co@microsoft.com>; edk2-devel@lists.01.org; Leif
>Lindholm <leif.lindholm@linaro.org>; Charles Garcia-Tobin <Charles.Garcia-
>Tobin@arm.com>
>Subject: Re: [edk2] [PATCH v2 1/1] BaseTools/tools_def: Add GCC49xASL
>Toolchain support
>
>(+ Charles)
>
>On 25 June 2018 at 03:38, Gao, Liming <liming.gao@intel.com> wrote:
>> Chris:
>>    GCC 4.9 targeting arm-none-eabi. This GCC4.9 should run in Windows OS.
>So, could you give some info where windows GCC49 is from.
>>
>
>OK, so first of all, could you elaborate on why we need a different
>ASL compiler? We have spent the past 5 years in conference calls and
>meeting rooms to standardize ACPI on ARM, so I am rather disappointed
>that we have this discrepancy.
>
>Then, could you explain why you chose GCC49? We have GCC5 now as well,
>which enables LTO and generally results in smaller code. Also, is
>there any way we could parameterize the existing GCCx toolchains to
>allow a different ASL compiler to be selected?
>
>Thanks,
>Ard.
>
>
>>>-----Original Message-----
>>>From: Chris Co [mailto:Christopher.Co@microsoft.com]
>>>Sent: Saturday, June 23, 2018 8:58 AM
>>>To: edk2-devel@lists.01.org
>>>Cc: Zhu, Yonghong <yonghong.zhu@intel.com>; Gao, Liming
>>><liming.gao@intel.com>; Leif Lindholm <leif.lindholm@linaro.org>
>>>Subject: [PATCH v2 1/1] BaseTools/tools_def: Add GCC49xASL Toolchain
>>>support
>>>
>>>From: Chris Co <chrco@microsoft.com>
>>>
>>>This patch adds a build option for invoking GCC49 ARM cross
>>>compiler in the Windows environment to build firmware for
>>>Windows 10 IoT devices using NXP i.MX6 and i.MX7 SoCs.
>>>
>>>In addition, this build option targets the Microsoft ASL
>>>compiler instead of iasl.  The Microsoft ASL compiler is
>>>necessary to expose Windows-specific Pin Function Config
>>>Descriptors on Windows IoT devices.
>>>
>>>Contributed-under: TianoCore Contribution Agreement 1.1
>>>Signed-off-by: Christopher Co <christopher.co@microsoft.com>
>>>Cc: Yonghong Zhu <yonghong.zhu@intel.com>
>>>Cc: Liming Gao <liming.gao@intel.com>
>>>Cc: Leif Lindholm <leif.lindholm@linaro.org>
>>>---
>>> BaseTools/Conf/tools_def.template | 61 ++++++++++++++++++++
>>> 1 file changed, 61 insertions(+)
>>>
>>>diff --git a/BaseTools/Conf/tools_def.template
>>>b/BaseTools/Conf/tools_def.template
>>>index 11a79029b890..f7a375ebaf1e 100755
>>>--- a/BaseTools/Conf/tools_def.template
>>>+++ b/BaseTools/Conf/tools_def.template
>>>@@ -393,6 +393,12 @@ DEFINE DTC_BIN                 = ENV(DTC_PREFIX)dtc
>>> #                             Required to build platforms or ACPI tables:
>>> #                               Intel(r) ACPI Compiler from
>>> #                               https://acpica.org/downloads
>>>+#   GCC49xASL   -Windows-  Requires:
>>>+#                             GCC 4.9 targeting arm-none-eabi
>>>+#                        Optional:
>>>+#                             Required to build platforms or ACPI tables:
>>>+#                               Microsoft ASL ACPI Compiler (asl.exe) from Windows
>WDK
>>>+#                               https://docs.microsoft.com/en-us/windows-
>>>hardware/drivers/download-the-wdk
>>> #   GCC5        -Linux,Windows-  Requires:
>>> #                             GCC 5 with LTO support, targeting x86_64-linux-gnu,
>aarch64-
>>>linux-gnu, or arm-linux-gnueabi
>>> #                        Optional:
>>>@@ -5466,6 +5472,61 @@ RELEASE_GCC49_AARCH64_DLINK_FLAGS  =
>>>DEF(GCC49_AARCH64_DLINK_FLAGS)
>>>   NOOPT_GCC49_AARCH64_DLINK_FLAGS  =
>>>DEF(GCC49_AARCH64_DLINK_FLAGS) -z common-page-size=0x1000 -O0
>>>   NOOPT_GCC49_AARCH64_DLINK_XIPFLAGS = -z common-page-size=0x20
>-
>>>O0
>>>
>>>+########################################################
>##
>>>##########################
>>>+#
>>>+# GCC49xASL - This configuration is used to compile under Windows to
>>>produce
>>>+#           PE/COFF binaries using GCC 4.9.
>>>+#
>>>+########################################################
>##
>>>##########################
>>>+*_GCC49xASL_*_*_FAMILY               = GCC
>>>+
>>>+*_GCC49xASL_*_MAKE_PATH                    = DEF(GCC_HOST_PREFIX)make
>>>+*_GCC49xASL_*_*_DLL                        = ENV(GCC49_DLL)
>>>+*_GCC49xASL_*_ASL_PATH                     = DEF(WIN_ASL_BIN)
>>>+
>>>+*_GCC49xASL_*_PP_FLAGS                     = DEF(GCC_PP_FLAGS)
>>>+*_GCC49xASL_*_ASLPP_FLAGS                  = DEF(GCC_ASLPP_FLAGS)
>>>+*_GCC49xASL_*_ASLCC_FLAGS                  = DEF(GCC_ASLCC_FLAGS)
>>>+*_GCC49xASL_*_VFRPP_FLAGS                  = DEF(GCC_VFRPP_FLAGS)
>>>+*_GCC49xASL_*_APP_FLAGS                    =
>>>+*_GCC49xASL_*_ASL_FLAGS                    = /MsftInternal
>>>+*_GCC49xASL_*_ASL_OUTFLAGS                 = DEF(MS_ASL_OUTFLAGS)
>>>+
>>>+##################
>>>+# GCC49xASL ARM definitions
>>>+##################
>>>+*_GCC49xASL_ARM_OBJCOPY_PATH         = noop
>>>+*_GCC49xASL_ARM_CC_PATH              = ENV(GCC49_ARM_PREFIX)gcc
>>>+*_GCC49xASL_ARM_SLINK_PATH           = ENV(GCC49_ARM_PREFIX)ar
>>>+*_GCC49xASL_ARM_DLINK_PATH           = ENV(GCC49_ARM_PREFIX)gcc
>>>+*_GCC49xASL_ARM_ASLDLINK_PATH        = ENV(GCC49_ARM_PREFIX)gcc
>>>+*_GCC49xASL_ARM_ASM_PATH             = ENV(GCC49_ARM_PREFIX)gcc
>>>+*_GCC49xASL_ARM_PP_PATH              = ENV(GCC49_ARM_PREFIX)gcc
>>>+*_GCC49xASL_ARM_VFRPP_PATH           = ENV(GCC49_ARM_PREFIX)gcc
>>>+*_GCC49xASL_ARM_ASLCC_PATH           = ENV(GCC49_ARM_PREFIX)gcc
>>>+*_GCC49xASL_ARM_ASLPP_PATH           = ENV(GCC49_ARM_PREFIX)gcc
>>>+*_GCC49xASL_ARM_RC_PATH              =
>ENV(GCC49_ARM_PREFIX)objcopy
>>>+*_GCC49xASL_ARM_SYMRENAME_PATH       = noop
>>>+
>>>+*_GCC49xASL_ARM_ARCHCC_FLAGS         = -mthumb
>>>+*_GCC49xASL_ARM_PLATFORM_FLAGS       = -march=armv7-a
>>>+
>>>+*_GCC49xASL_ARM_ASLCC_FLAGS          = DEF(GCC_ASLCC_FLAGS)
>>>+*_GCC49xASL_ARM_ASLDLINK_FLAGS       =
>>>DEF(GCC49_ARM_ASLDLINK_FLAGS)
>>>+*_GCC49xASL_ARM_ASM_FLAGS            = DEF(GCC49_ARM_ASM_FLAGS)
>>>+*_GCC49xASL_ARM_DLINK_FLAGS          =
>DEF(GCC49_ARM_DLINK_FLAGS)
>>>+*_GCC49xASL_ARM_DLINK2_FLAGS         =
>DEF(GCC49_ARM_DLINK2_FLAGS)
>>>+*_GCC49xASL_ARM_DTCPP_FLAGS          = DEF(GCC_DTCPP_FLAGS)
>>>+*_GCC49xASL_ARM_PLATFORM_FLAGS       = -march=armv7-a
>>>+*_GCC49xASL_ARM_PP_FLAGS             = $(ARCHCC_FLAGS)
>>>$(PLATFORM_FLAGS) DEF(GCC_PP_FLAGS)
>>>+*_GCC49xASL_ARM_RC_FLAGS             = DEF(GCC_ARM_RC_FLAGS)
>>>+*_GCC49xASL_ARM_VFRPP_FLAGS          = $(ARCHCC_FLAGS)
>>>$(PLATFORM_FLAGS) DEF(GCC_VFRPP_FLAGS)
>>>+*_GCC49xASL_ARM_CC_XIPFLAGS          = DEF(GCC49_ARM_CC_XIPFLAGS)
>>>+
>>>+  DEBUG_GCC49xASL_ARM_CC_FLAGS       = DEF(GCC49_ARM_CC_FLAGS)
>-
>>>O0
>>>+RELEASE_GCC49xASL_ARM_CC_FLAGS       = DEF(GCC49_ARM_CC_FLAGS)
>-
>>>Wno-unused-but-set-variable -Wno-unused-const-variable
>>>+  NOOPT_GCC49xASL_ARM_CC_FLAGS       = DEF(GCC49_ARM_CC_FLAGS)
>-
>>>O0
>>>+
>>>
>>>#########################################################
>##
>>>#########################
>>> #
>>> # GCC 5 - This configuration is used to compile under Linux to produce
>>>--
>>>2.16.2.gvfs.1.33.gf5370f1
>>
>> _______________________________________________
>> edk2-devel mailing list
>> edk2-devel@lists.01.org
>> https://lists.01.org/mailman/listinfo/edk2-devel