public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gao, Liming" <liming.gao@intel.com>
To: "Bi, Dandan" <dandan.bi@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Zeng, Star" <star.zeng@intel.com>
Subject: Re: [patch] MdeModulePkg/PiSmmCore: Remove SMM Perf entry
Date: Wed, 27 Jun 2018 06:59:29 +0000	[thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E29EB57@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20180627061623.169516-1-dandan.bi@intel.com>

Reviewed-by: Liming Gao <liming.gao@intel.com>

>-----Original Message-----
>From: Bi, Dandan
>Sent: Wednesday, June 27, 2018 2:16 PM
>To: edk2-devel@lists.01.org
>Cc: Gao, Liming <liming.gao@intel.com>; Zeng, Star <star.zeng@intel.com>
>Subject: [patch] MdeModulePkg/PiSmmCore: Remove SMM Perf entry
>
>The perf measurement entry in SmmEntryPoint function
>doesn't have significant meaning. So remove it now.
>
>Cc: Liming Gao <liming.gao@intel.com>
>Cc: Star Zeng <star.zeng@intel.com>
>Contributed-under: TianoCore Contribution Agreement 1.1
>Signed-off-by: Dandan Bi <dandan.bi@intel.com>
>---
> MdeModulePkg/Core/PiSmmCore/PiSmmCore.c | 4 ----
> 1 file changed, 4 deletions(-)
>
>diff --git a/MdeModulePkg/Core/PiSmmCore/PiSmmCore.c
>b/MdeModulePkg/Core/PiSmmCore/PiSmmCore.c
>index 45f40e0e60c..2fb401e47e7 100644
>--- a/MdeModulePkg/Core/PiSmmCore/PiSmmCore.c
>+++ b/MdeModulePkg/Core/PiSmmCore/PiSmmCore.c
>@@ -642,12 +642,10 @@ SmmEntryPoint (
>   BOOLEAN                     InLegacyBoot;
>   BOOLEAN                     IsOverlapped;
>   VOID                        *CommunicationBuffer;
>   UINTN                       BufferSize;
>
>-  PERF_INMODULE_BEGIN ("SMM");
>-
>   //
>   // Update SMST with contents of the SmmEntryContext structure
>   //
>   gSmmCoreSmst.SmmStartupThisAp      = SmmEntryContext-
>>SmmStartupThisAp;
>   gSmmCoreSmst.CurrentlyExecutingCpu = SmmEntryContext-
>>CurrentlyExecutingCpu;
>@@ -736,12 +734,10 @@ SmmEntryPoint (
>     //
>     // Clear the InSmm flag as we are going to leave SMM
>     //
>     gSmmCorePrivate->InSmm = FALSE;
>   }
>-
>-  PERF_INMODULE_END ("SMM");
> }
>
> /**
>   Install LoadedImage protocol for SMM Core.
> **/
>--
>2.14.3.windows.1



      parent reply	other threads:[~2018-06-27  6:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-27  6:16 [patch] MdeModulePkg/PiSmmCore: Remove SMM Perf entry Dandan Bi
2018-06-27  6:16 ` [patch] MdeModulePkg/PerformanceLib: Add NULL pointer check Dandan Bi
2018-06-27  7:22   ` Wu, Hao A
2018-06-27  6:59 ` Gao, Liming [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E29EB57@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox