From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.120; helo=mga04.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0680D211F8898 for ; Tue, 26 Jun 2018 23:59:32 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Jun 2018 23:59:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,278,1526367600"; d="scan'208";a="60485179" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by FMSMGA003.fm.intel.com with ESMTP; 26 Jun 2018 23:59:32 -0700 Received: from fmsmsx152.amr.corp.intel.com (10.18.125.5) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 26 Jun 2018 23:59:32 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX152.amr.corp.intel.com (10.18.125.5) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 26 Jun 2018 23:59:32 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.87]) by shsmsx102.ccr.corp.intel.com ([169.254.2.223]) with mapi id 14.03.0319.002; Wed, 27 Jun 2018 14:59:30 +0800 From: "Gao, Liming" To: "Bi, Dandan" , "edk2-devel@lists.01.org" CC: "Zeng, Star" Thread-Topic: [patch] MdeModulePkg/PiSmmCore: Remove SMM Perf entry Thread-Index: AQHUDd6qxBtvQpr+pk+NtfJroH3BgqRzrQbQ Date: Wed, 27 Jun 2018 06:59:29 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E29EB57@SHSMSX104.ccr.corp.intel.com> References: <20180627061623.169516-1-dandan.bi@intel.com> In-Reply-To: <20180627061623.169516-1-dandan.bi@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [patch] MdeModulePkg/PiSmmCore: Remove SMM Perf entry X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Jun 2018 06:59:33 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao >-----Original Message----- >From: Bi, Dandan >Sent: Wednesday, June 27, 2018 2:16 PM >To: edk2-devel@lists.01.org >Cc: Gao, Liming ; Zeng, Star >Subject: [patch] MdeModulePkg/PiSmmCore: Remove SMM Perf entry > >The perf measurement entry in SmmEntryPoint function >doesn't have significant meaning. So remove it now. > >Cc: Liming Gao >Cc: Star Zeng >Contributed-under: TianoCore Contribution Agreement 1.1 >Signed-off-by: Dandan Bi >--- > MdeModulePkg/Core/PiSmmCore/PiSmmCore.c | 4 ---- > 1 file changed, 4 deletions(-) > >diff --git a/MdeModulePkg/Core/PiSmmCore/PiSmmCore.c >b/MdeModulePkg/Core/PiSmmCore/PiSmmCore.c >index 45f40e0e60c..2fb401e47e7 100644 >--- a/MdeModulePkg/Core/PiSmmCore/PiSmmCore.c >+++ b/MdeModulePkg/Core/PiSmmCore/PiSmmCore.c >@@ -642,12 +642,10 @@ SmmEntryPoint ( > BOOLEAN InLegacyBoot; > BOOLEAN IsOverlapped; > VOID *CommunicationBuffer; > UINTN BufferSize; > >- PERF_INMODULE_BEGIN ("SMM"); >- > // > // Update SMST with contents of the SmmEntryContext structure > // > gSmmCoreSmst.SmmStartupThisAp =3D SmmEntryContext- >>SmmStartupThisAp; > gSmmCoreSmst.CurrentlyExecutingCpu =3D SmmEntryContext- >>CurrentlyExecutingCpu; >@@ -736,12 +734,10 @@ SmmEntryPoint ( > // > // Clear the InSmm flag as we are going to leave SMM > // > gSmmCorePrivate->InSmm =3D FALSE; > } >- >- PERF_INMODULE_END ("SMM"); > } > > /** > Install LoadedImage protocol for SMM Core. > **/ >-- >2.14.3.windows.1