From: "Gao, Liming" <liming.gao@intel.com>
To: "Zeng, Star" <star.zeng@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Bi, Dandan" <dandan.bi@intel.com>, "Zeng, Star" <star.zeng@intel.com>
Subject: Re: [PATCH] MdeModulePkg Variable: Add/Correct GetHobVariableStore para description
Date: Mon, 2 Jul 2018 08:58:00 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E2A0CF8@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <1530521814-190816-1-git-send-email-star.zeng@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
>-----Original Message-----
>From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Star
>Zeng
>Sent: Monday, July 02, 2018 4:57 PM
>To: edk2-devel@lists.01.org
>Cc: Bi, Dandan <dandan.bi@intel.com>; Gao, Liming <liming.gao@intel.com>;
>Zeng, Star <star.zeng@intel.com>
>Subject: [edk2] [PATCH] MdeModulePkg Variable: Add/Correct
>GetHobVariableStore para description
>
>It is caused by 09808bd39b0c76559354253639766458ec24da79.
>
>Cc: Liming Gao <liming.gao@intel.com>
>Cc: Dandan Bi <dandan.bi@intel.com>
>Contributed-under: TianoCore Contribution Agreement 1.1
>Signed-off-by: Star Zeng <star.zeng@intel.com>
>---
> MdeModulePkg/Universal/Variable/Pei/Variable.c | 3 +++
> MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c | 2 +-
> 2 files changed, 4 insertions(+), 1 deletion(-)
>
>diff --git a/MdeModulePkg/Universal/Variable/Pei/Variable.c
>b/MdeModulePkg/Universal/Variable/Pei/Variable.c
>index d75a13e2b079..96a52f23d1c1 100644
>--- a/MdeModulePkg/Universal/Variable/Pei/Variable.c
>+++ b/MdeModulePkg/Universal/Variable/Pei/Variable.c
>@@ -498,6 +498,9 @@ CompareWithValidVariable (
> /**
> Get HOB variable store.
>
>+ @param[out] StoreInfo Return the store info.
>+ @param[out] VariableStoreHeader Return variable store header.
>+
> **/
> VOID
> GetHobVariableStore (
>diff --git a/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c
>b/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c
>index 42b0bfda570d..1ea2f84dda68 100644
>--- a/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c
>+++ b/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c
>@@ -4173,7 +4173,7 @@ ConvertNormalVarStorageToAuthVarStorage (
> /**
> Get HOB variable store.
>
>- @param[out] VariableGuid NV variable store signature.
>+ @param[in] VariableGuid NV variable store signature.
>
> @retval EFI_SUCCESS Function successfully executed.
> @retval EFI_OUT_OF_RESOURCES Fail to allocate enough memory resource.
>--
>2.7.0.windows.1
>
>_______________________________________________
>edk2-devel mailing list
>edk2-devel@lists.01.org
>https://lists.01.org/mailman/listinfo/edk2-devel
next prev parent reply other threads:[~2018-07-02 8:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-02 8:56 [PATCH] MdeModulePkg Variable: Add/Correct GetHobVariableStore para description Star Zeng
2018-07-02 8:58 ` Gao, Liming [this message]
2018-07-03 0:51 ` Bi, Dandan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E2A0CF8@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox