* [PATCH] MdeModulePkg Variable: Add/Correct GetHobVariableStore para description
@ 2018-07-02 8:56 Star Zeng
2018-07-02 8:58 ` Gao, Liming
2018-07-03 0:51 ` Bi, Dandan
0 siblings, 2 replies; 3+ messages in thread
From: Star Zeng @ 2018-07-02 8:56 UTC (permalink / raw)
To: edk2-devel; +Cc: Star Zeng, Liming Gao, Dandan Bi
It is caused by 09808bd39b0c76559354253639766458ec24da79.
Cc: Liming Gao <liming.gao@intel.com>
Cc: Dandan Bi <dandan.bi@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng <star.zeng@intel.com>
---
MdeModulePkg/Universal/Variable/Pei/Variable.c | 3 +++
MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c | 2 +-
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/MdeModulePkg/Universal/Variable/Pei/Variable.c b/MdeModulePkg/Universal/Variable/Pei/Variable.c
index d75a13e2b079..96a52f23d1c1 100644
--- a/MdeModulePkg/Universal/Variable/Pei/Variable.c
+++ b/MdeModulePkg/Universal/Variable/Pei/Variable.c
@@ -498,6 +498,9 @@ CompareWithValidVariable (
/**
Get HOB variable store.
+ @param[out] StoreInfo Return the store info.
+ @param[out] VariableStoreHeader Return variable store header.
+
**/
VOID
GetHobVariableStore (
diff --git a/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c b/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c
index 42b0bfda570d..1ea2f84dda68 100644
--- a/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c
+++ b/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c
@@ -4173,7 +4173,7 @@ ConvertNormalVarStorageToAuthVarStorage (
/**
Get HOB variable store.
- @param[out] VariableGuid NV variable store signature.
+ @param[in] VariableGuid NV variable store signature.
@retval EFI_SUCCESS Function successfully executed.
@retval EFI_OUT_OF_RESOURCES Fail to allocate enough memory resource.
--
2.7.0.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] MdeModulePkg Variable: Add/Correct GetHobVariableStore para description
2018-07-02 8:56 [PATCH] MdeModulePkg Variable: Add/Correct GetHobVariableStore para description Star Zeng
@ 2018-07-02 8:58 ` Gao, Liming
2018-07-03 0:51 ` Bi, Dandan
1 sibling, 0 replies; 3+ messages in thread
From: Gao, Liming @ 2018-07-02 8:58 UTC (permalink / raw)
To: Zeng, Star, edk2-devel@lists.01.org; +Cc: Bi, Dandan, Zeng, Star
Reviewed-by: Liming Gao <liming.gao@intel.com>
>-----Original Message-----
>From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Star
>Zeng
>Sent: Monday, July 02, 2018 4:57 PM
>To: edk2-devel@lists.01.org
>Cc: Bi, Dandan <dandan.bi@intel.com>; Gao, Liming <liming.gao@intel.com>;
>Zeng, Star <star.zeng@intel.com>
>Subject: [edk2] [PATCH] MdeModulePkg Variable: Add/Correct
>GetHobVariableStore para description
>
>It is caused by 09808bd39b0c76559354253639766458ec24da79.
>
>Cc: Liming Gao <liming.gao@intel.com>
>Cc: Dandan Bi <dandan.bi@intel.com>
>Contributed-under: TianoCore Contribution Agreement 1.1
>Signed-off-by: Star Zeng <star.zeng@intel.com>
>---
> MdeModulePkg/Universal/Variable/Pei/Variable.c | 3 +++
> MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c | 2 +-
> 2 files changed, 4 insertions(+), 1 deletion(-)
>
>diff --git a/MdeModulePkg/Universal/Variable/Pei/Variable.c
>b/MdeModulePkg/Universal/Variable/Pei/Variable.c
>index d75a13e2b079..96a52f23d1c1 100644
>--- a/MdeModulePkg/Universal/Variable/Pei/Variable.c
>+++ b/MdeModulePkg/Universal/Variable/Pei/Variable.c
>@@ -498,6 +498,9 @@ CompareWithValidVariable (
> /**
> Get HOB variable store.
>
>+ @param[out] StoreInfo Return the store info.
>+ @param[out] VariableStoreHeader Return variable store header.
>+
> **/
> VOID
> GetHobVariableStore (
>diff --git a/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c
>b/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c
>index 42b0bfda570d..1ea2f84dda68 100644
>--- a/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c
>+++ b/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c
>@@ -4173,7 +4173,7 @@ ConvertNormalVarStorageToAuthVarStorage (
> /**
> Get HOB variable store.
>
>- @param[out] VariableGuid NV variable store signature.
>+ @param[in] VariableGuid NV variable store signature.
>
> @retval EFI_SUCCESS Function successfully executed.
> @retval EFI_OUT_OF_RESOURCES Fail to allocate enough memory resource.
>--
>2.7.0.windows.1
>
>_______________________________________________
>edk2-devel mailing list
>edk2-devel@lists.01.org
>https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] MdeModulePkg Variable: Add/Correct GetHobVariableStore para description
2018-07-02 8:56 [PATCH] MdeModulePkg Variable: Add/Correct GetHobVariableStore para description Star Zeng
2018-07-02 8:58 ` Gao, Liming
@ 2018-07-03 0:51 ` Bi, Dandan
1 sibling, 0 replies; 3+ messages in thread
From: Bi, Dandan @ 2018-07-03 0:51 UTC (permalink / raw)
To: Zeng, Star, edk2-devel@lists.01.org; +Cc: Gao, Liming, Zeng, Star
Reviewed-by: Dandan Bi <dandan.bi@intel.com>
Thanks,
Dandan
-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Star Zeng
Sent: Monday, July 2, 2018 4:57 PM
To: edk2-devel@lists.01.org
Cc: Bi, Dandan <dandan.bi@intel.com>; Gao, Liming <liming.gao@intel.com>; Zeng, Star <star.zeng@intel.com>
Subject: [edk2] [PATCH] MdeModulePkg Variable: Add/Correct GetHobVariableStore para description
It is caused by 09808bd39b0c76559354253639766458ec24da79.
Cc: Liming Gao <liming.gao@intel.com>
Cc: Dandan Bi <dandan.bi@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng <star.zeng@intel.com>
---
MdeModulePkg/Universal/Variable/Pei/Variable.c | 3 +++
MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c | 2 +-
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/MdeModulePkg/Universal/Variable/Pei/Variable.c b/MdeModulePkg/Universal/Variable/Pei/Variable.c
index d75a13e2b079..96a52f23d1c1 100644
--- a/MdeModulePkg/Universal/Variable/Pei/Variable.c
+++ b/MdeModulePkg/Universal/Variable/Pei/Variable.c
@@ -498,6 +498,9 @@ CompareWithValidVariable (
/**
Get HOB variable store.
+ @param[out] StoreInfo Return the store info.
+ @param[out] VariableStoreHeader Return variable store header.
+
**/
VOID
GetHobVariableStore (
diff --git a/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c b/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c
index 42b0bfda570d..1ea2f84dda68 100644
--- a/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c
+++ b/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c
@@ -4173,7 +4173,7 @@ ConvertNormalVarStorageToAuthVarStorage (
/**
Get HOB variable store.
- @param[out] VariableGuid NV variable store signature.
+ @param[in] VariableGuid NV variable store signature.
@retval EFI_SUCCESS Function successfully executed.
@retval EFI_OUT_OF_RESOURCES Fail to allocate enough memory resource.
--
2.7.0.windows.1
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-07-03 0:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-02 8:56 [PATCH] MdeModulePkg Variable: Add/Correct GetHobVariableStore para description Star Zeng
2018-07-02 8:58 ` Gao, Liming
2018-07-03 0:51 ` Bi, Dandan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox