From: "Gao, Liming" <liming.gao@intel.com>
To: Supreeth Venkatesh <supreeth.venkatesh@arm.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Yao, Jiewen" <jiewen.yao@intel.com>
Subject: Re: [PATCH] BaseTools/AutoGen: Update header file for MM modules.
Date: Tue, 3 Jul 2018 11:56:51 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E2A165B@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <1530612035-9996-2-git-send-email-supreeth.venkatesh@arm.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Supreeth Venkatesh
> Sent: Tuesday, July 3, 2018 6:01 PM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen <jiewen.yao@intel.com>
> Subject: [edk2] [PATCH] BaseTools/AutoGen: Update header file for MM modules.
>
> This patch corrects the Module Type Header file for Management Mode(MM)
> as specified in PI v1.6 Specification. Also, it updates parameter for
> auto generated template functions from EFI_SMM_SYSTEM_TABLE2 to
> EFI_MM_SYSTEM_TABLE.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
> Reviewed-by: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> ---
> BaseTools/Source/Python/AutoGen/GenC.py | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/BaseTools/Source/Python/AutoGen/GenC.py b/BaseTools/Source/Python/AutoGen/GenC.py
> index 5c3552a..55bcaba 100644
> --- a/BaseTools/Source/Python/AutoGen/GenC.py
> +++ b/BaseTools/Source/Python/AutoGen/GenC.py
> @@ -265,7 +265,7 @@ EFI_STATUS
> EFIAPI
> ${Function} (
> IN EFI_HANDLE ImageHandle,
> - IN EFI_SMM_SYSTEM_TABLE2 *MmSystemTable
> + IN EFI_MM_SYSTEM_TABLE *MmSystemTable
> );
> ${END}
> """)
> @@ -278,7 +278,7 @@ EFI_STATUS
> EFIAPI
> ProcessModuleEntryPointList (
> IN EFI_HANDLE ImageHandle,
> - IN EFI_SMM_SYSTEM_TABLE2 *MmSystemTable
> + IN EFI_MM_SYSTEM_TABLE *MmSystemTable
> )
>
> {
> @@ -292,7 +292,7 @@ EFI_STATUS
> EFIAPI
> ProcessModuleEntryPointList (
> IN EFI_HANDLE ImageHandle,
> - IN EFI_SMM_SYSTEM_TABLE2 *MmSystemTable
> + IN EFI_MM_SYSTEM_TABLE *MmSystemTable
> )
>
> {
> @@ -307,7 +307,7 @@ EFI_STATUS
> EFIAPI
> ProcessModuleEntryPointList (
> IN EFI_HANDLE ImageHandle,
> - IN EFI_SMM_SYSTEM_TABLE2 *MmSystemTable
> + IN EFI_MM_SYSTEM_TABLE *MmSystemTable
> )
>
> {
> @@ -675,7 +675,7 @@ EFI_STATUS
> EFIAPI
> ${Function} (
> IN EFI_HANDLE ImageHandle,
> - IN EFI_SMM_SYSTEM_TABLE2 *MmSystemTable
> + IN EFI_MM_SYSTEM_TABLE *MmSystemTable
> );${END}
> """),
> }
> @@ -755,7 +755,7 @@ VOID
> EFIAPI
> ProcessLibrary${Type}List (
> IN EFI_HANDLE ImageHandle,
> - IN EFI_SMM_SYSTEM_TABLE2 *MmSystemTable
> + IN EFI_MM_SYSTEM_TABLE *MmSystemTable
> )
> {
> ${BEGIN} EFI_STATUS Status;
> @@ -779,8 +779,8 @@ gModuleTypeHeaderFile = {
> SUP_MODULE_UEFI_DRIVER : ["Uefi.h", "Library/BaseLib.h", "Library/DebugLib.h",
> "Library/UefiBootServicesTableLib.h", "Library/UefiDriverEntryPoint.h"],
> SUP_MODULE_UEFI_APPLICATION : ["Uefi.h", "Library/BaseLib.h", "Library/DebugLib.h",
> "Library/UefiBootServicesTableLib.h", "Library/UefiApplicationEntryPoint.h"],
> SUP_MODULE_SMM_CORE : ["PiDxe.h", "Library/BaseLib.h", "Library/DebugLib.h",
> "Library/UefiDriverEntryPoint.h"],
> - SUP_MODULE_MM_STANDALONE : ["PiSmm.h", "Library/BaseLib.h", "Library/DebugLib.h",
> "Library/SmmDriverStandaloneEntryPoint.h"],
> - SUP_MODULE_MM_CORE_STANDALONE : ["PiSmm.h", "Library/BaseLib.h", "Library/DebugLib.h",
> "Library/SmmCoreStandaloneEntryPoint.h"],
> + SUP_MODULE_MM_STANDALONE : ["PiMm.h", "Library/BaseLib.h", "Library/DebugLib.h",
> "Library/StandaloneMmDriverEntryPoint.h"],
> + SUP_MODULE_MM_CORE_STANDALONE : ["PiMm.h", "Library/BaseLib.h", "Library/DebugLib.h",
> "Library/StandaloneMmCoreEntryPoint.h"],
> SUP_MODULE_USER_DEFINED : [gBasicHeaderFile]
> }
>
> --
> 2.7.4
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
next prev parent reply other threads:[~2018-07-03 11:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-03 10:00 [PATCH 0/1] BaseTools changes for Management Mode modules Supreeth Venkatesh
2018-07-03 10:00 ` [PATCH] BaseTools/AutoGen: Update header file for MM modules Supreeth Venkatesh
2018-07-03 11:56 ` Gao, Liming [this message]
2018-07-23 3:13 ` Gao, Liming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E2A165B@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox