From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.93; helo=mga11.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 300A9202E53E4 for ; Sun, 8 Jul 2018 19:20:50 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Jul 2018 19:20:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,328,1526367600"; d="scan'208";a="244016108" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga006.fm.intel.com with ESMTP; 08 Jul 2018 19:20:49 -0700 Received: from fmsmsx121.amr.corp.intel.com (10.18.125.36) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 8 Jul 2018 19:20:49 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx121.amr.corp.intel.com (10.18.125.36) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 8 Jul 2018 19:20:49 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.81]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.17]) with mapi id 14.03.0319.002; Mon, 9 Jul 2018 10:20:47 +0800 From: "Gao, Liming" To: "Tomas Pilar (tpilar)" , "edk2-devel@lists.01.org" CC: "Kinney, Michael D" Thread-Topic: [edk2] [PATCH v4] MdePkg/BaseLib: Add bit field population calculating methods Thread-Index: AQHUFS74FFa76KniR02bf3GLOqdBz6SGLFpA Date: Mon, 9 Jul 2018 02:20:46 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E2B7794@SHSMSX104.ccr.corp.intel.com> References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v4] MdePkg/BaseLib: Add bit field population calculating methods X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Jul 2018 02:20:50 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao >-----Original Message----- >From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of >Tomas Pilar (tpilar) >Sent: Friday, July 06, 2018 9:41 PM >To: edk2-devel@lists.01.org >Cc: Kinney, Michael D ; Gao, Liming > >Subject: [edk2] [PATCH v4] MdePkg/BaseLib: Add bit field population >calculating methods > >Hopefully this should tidy the conversion warnings. > >---- > >Add 32-bit and 64-bit functions that count number of set bits in a bitfiel= d >using a divide-and-count method. > >Contributed-under: TianoCore Contribution Agreement 1.1 >Signed-off-by: Tomas Pilar >Cc: Liming Gao >Cc: Michael D Kinney >--- > MdePkg/Include/Library/BaseLib.h | 56 +++++++++++++++++++++++++ > MdePkg/Library/BaseLib/BitField.c | 86 >+++++++++++++++++++++++++++++++++++++++ > 2 files changed, 142 insertions(+) > >diff --git a/MdePkg/Include/Library/BaseLib.h >b/MdePkg/Include/Library/BaseLib.h >index 1db3a04..123ae19 100644 >--- a/MdePkg/Include/Library/BaseLib.h >+++ b/MdePkg/Include/Library/BaseLib.h >@@ -4609,6 +4609,62 @@ BitFieldAndThenOr64 ( > IN UINT64 OrData > ); > >+/** >+ Reads a bit field from a 32-bit value, counts and returns >+ the number of set bits. >+ >+ Counts the number of set bits in the bit field specified by >+ StartBit and EndBit in Operand. The count is returned. >+ >+ If StartBit is greater than 31, then ASSERT(). >+ If EndBit is greater than 31, then ASSERT(). >+ If EndBit is less than StartBit, then ASSERT(). >+ >+ @param Operand Operand on which to perform the bitfield operation. >+ @param StartBit The ordinal of the least significant bit in the bit f= ield. >+ Range 0..31. >+ @param EndBit The ordinal of the most significant bit in the bit fi= eld. >+ Range 0..31. >+ >+ @return The number of bits set between StartBit and EndBit. >+ >+**/ >+UINT8 >+EFIAPI >+BitFieldCountOnes32 ( >+ IN UINT32 Operand, >+ IN UINTN StartBit, >+ IN UINTN EndBit >+ ); >+ >+/** >+ Reads a bit field from a 64-bit value, counts and returns >+ the number of set bits. >+ >+ Counts the number of set bits in the bit field specified by >+ StartBit and EndBit in Operand. The count is returned. >+ >+ If StartBit is greater than 63, then ASSERT(). >+ If EndBit is greater than 63, then ASSERT(). >+ If EndBit is less than StartBit, then ASSERT(). >+ >+ @param Operand Operand on which to perform the bitfield operation. >+ @param StartBit The ordinal of the least significant bit in the bit = field. >+ Range 0..63. >+ @param EndBit The ordinal of the most significant bit in the bit f= ield. >+ Range 0..63. >+ >+ @return The number of bits set between StartBit and EndBit. >+ >+**/ >+UINT8 >+EFIAPI >+BitFieldCountOnes64 ( >+ IN UINT64 Operand, >+ IN UINTN StartBit, >+ IN UINTN EndBit >+ ); >+ > // > // Base Library Checksum Functions > // >diff --git a/MdePkg/Library/BaseLib/BitField.c >b/MdePkg/Library/BaseLib/BitField.c >index d2d3150..645a662 100644 >--- a/MdePkg/Library/BaseLib/BitField.c >+++ b/MdePkg/Library/BaseLib/BitField.c >@@ -920,3 +920,89 @@ BitFieldAndThenOr64 ( > OrData > ); > } >+ >+/** >+ Reads a bit field from a 32-bit value, counts and returns >+ the number of set bits. >+ >+ Counts the number of set bits in the bit field specified by >+ StartBit and EndBit in Operand. The count is returned. >+ >+ If StartBit is greater than 31, then ASSERT(). >+ If EndBit is greater than 31, then ASSERT(). >+ If EndBit is less than StartBit, then ASSERT(). >+ >+ @param Operand Operand on which to perform the bitfield operation. >+ @param StartBit The ordinal of the least significant bit in the bit f= ield. >+ Range 0..31. >+ @param EndBit The ordinal of the most significant bit in the bit fi= eld. >+ Range 0..31. >+ >+ @return The number of bits set between StartBit and EndBit. >+ >+**/ >+UINT8 >+EFIAPI >+BitFieldCountOnes32 ( >+ IN UINT32 Operand, >+ IN UINTN StartBit, >+ IN UINTN EndBit >+ ) >+{ >+ UINT32 Count; >+ >+ ASSERT (EndBit < 32); >+ ASSERT (StartBit <=3D EndBit); >+ >+ Count =3D BitFieldRead32 (Operand, StartBit, EndBit); >+ Count -=3D ((Count >> 1) & 0x55555555); >+ Count =3D (Count & 0x33333333) + ((Count >> 2) & 0x33333333); >+ Count +=3D Count >> 4; >+ Count &=3D 0x0F0F0F0F; >+ Count +=3D Count >> 8; >+ Count +=3D Count >> 16; >+ >+ return (UINT8) Count & 0x3F; >+} >+ >+/** >+ Reads a bit field from a 64-bit value, counts and returns >+ the number of set bits. >+ >+ Counts the number of set bits in the bit field specified by >+ StartBit and EndBit in Operand. The count is returned. >+ >+ If StartBit is greater than 63, then ASSERT(). >+ If EndBit is greater than 63, then ASSERT(). >+ If EndBit is less than StartBit, then ASSERT(). >+ >+ @param Operand Operand on which to perform the bitfield operation. >+ @param StartBit The ordinal of the least significant bit in the bit = field. >+ Range 0..63. >+ @param EndBit The ordinal of the most significant bit in the bit f= ield. >+ Range 0..63. >+ >+ @return The number of bits set between StartBit and EndBit. >+ >+**/ >+UINT8 >+EFIAPI >+BitFieldCountOnes64 ( >+ IN UINT64 Operand, >+ IN UINTN StartBit, >+ IN UINTN EndBit >+ ) >+{ >+ UINT64 BitField; >+ UINT8 Count; >+ >+ ASSERT (EndBit < 64); >+ ASSERT (StartBit <=3D EndBit); >+ >+ BitField =3D BitFieldRead64 (Operand, StartBit, EndBit); >+ Count =3D BitFieldCountOnes32 ((UINT32) BitField, 0, 31); >+ Count +=3D BitFieldCountOnes32 ((UINT32) RShiftU64(BitField, 32), 0, 31= ); >+ >+ return Count; >+} >+ >-- >2.9.5 > >_______________________________________________ >edk2-devel mailing list >edk2-devel@lists.01.org >https://lists.01.org/mailman/listinfo/edk2-devel