From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.20; helo=mga02.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D03E7203B99C2 for ; Wed, 11 Jul 2018 17:41:49 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Jul 2018 17:41:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,339,1526367600"; d="scan'208";a="215306272" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga004.jf.intel.com with ESMTP; 11 Jul 2018 17:41:49 -0700 Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 11 Jul 2018 17:41:49 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX154.amr.corp.intel.com (10.18.116.70) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 11 Jul 2018 17:41:48 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.81]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.57]) with mapi id 14.03.0319.002; Thu, 12 Jul 2018 08:41:46 +0800 From: "Gao, Liming" To: "Feng, Bob C" , "edk2-devel@lists.01.org" Thread-Topic: [PATCH] BaseTool: Fixed the incorrect cache key. Thread-Index: AQHUGGnmoZKiBYeSakyI9MqvryADEaSKwV5g Date: Thu, 12 Jul 2018 00:41:46 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E2BA4F7@SHSMSX104.ccr.corp.intel.com> References: <20180710161924.116716-1-bob.c.feng@intel.com> In-Reply-To: <20180710161924.116716-1-bob.c.feng@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiN2MyYzI5YWUtOTJlYy00NGM0LWE0ZmQtMzQ0YTU1MTBjN2EyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoibTk0UEMxbStBSzJHc1wvckNsMGxrV1Z1NjRrM3dzbjM0eDRDdkpZdkd3cGFBSnhXdG1SM01BWXljdkJcL0huM25WIn0= dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] BaseTool: Fixed the incorrect cache key. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Jul 2018 00:41:50 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao > -----Original Message----- > From: Feng, Bob C > Sent: Wednesday, July 11, 2018 12:19 AM > To: edk2-devel@lists.01.org > Cc: Feng, Bob C ; Gao, Liming > Subject: [PATCH] BaseTool: Fixed the incorrect cache key. >=20 > From: "bob.c.feng@intel.com" >=20 > This patch is to fix the incorrect cache key of > skip ModuleAutoGen cache. >=20 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Bob Feng > Cc: Liming Gao > --- > BaseTools/Source/Python/AutoGen/AutoGen.py | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/BaseTools/Source/Python/AutoGen/AutoGen.py b/BaseTools/Sourc= e/Python/AutoGen/AutoGen.py > index b27290989e..54c6b7330f 100644 > --- a/BaseTools/Source/Python/AutoGen/AutoGen.py > +++ b/BaseTools/Source/Python/AutoGen/AutoGen.py > @@ -4320,7 +4320,7 @@ class ModuleAutoGen(AutoGen): > # If any source file is newer than the module than we cannot skip > # > def CanSkip(self): > - if self.MetaFile in GlobalData.gSikpAutoGenCache: > + if self.MakeFileDir in GlobalData.gSikpAutoGenCache: > return True > if not os.path.exists(self.GetTimeStampPath()): > return False > @@ -4340,7 +4340,7 @@ class ModuleAutoGen(AutoGen): > ModuleAutoGen.TimeDict[source] =3D os.stat(source)[8= ] > if ModuleAutoGen.TimeDict[source] > DstTimeStamp: > return False > - GlobalData.gSikpAutoGenCache.add(self.MetaFile) > + GlobalData.gSikpAutoGenCache.add(self.MakeFileDir) > return True >=20 > def GetTimeStampPath(self): > -- > 2.18.0.windows.1