From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.93; helo=mga11.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C704E2098845C for ; Sun, 15 Jul 2018 19:38:18 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Jul 2018 19:38:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,359,1526367600"; d="scan'208";a="67241599" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga002.fm.intel.com with ESMTP; 15 Jul 2018 19:38:17 -0700 Received: from FMSMSX110.amr.corp.intel.com (10.18.116.10) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 15 Jul 2018 19:38:16 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx110.amr.corp.intel.com (10.18.116.10) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 15 Jul 2018 19:38:16 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.81]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.100]) with mapi id 14.03.0319.002; Mon, 16 Jul 2018 10:38:14 +0800 From: "Gao, Liming" To: AlexeiFedorov , "edk2-devel@lists.01.org" CC: "Ni, Ruiyu" , "Stephanie.Hughes-Fitt@arm.com" , "Carsey, Jaben" , "nd@arm.com" Thread-Topic: [edk2] [PATCH v1] ShellPkg/UefiShellAcpiViewCommandLib: Fix VS2017 compilation errors Thread-Index: AQHUGrykZZgkXiySVka2jIVKEAQScKSRJjFQ Date: Mon, 16 Jul 2018 02:38:14 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E2BBC15@SHSMSX104.ccr.corp.intel.com> References: <20180713151701.20168-1-Alexei.Fedorov@arm.com> In-Reply-To: <20180713151701.20168-1-Alexei.Fedorov@arm.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v1] ShellPkg/UefiShellAcpiViewCommandLib: Fix VS2017 compilation errors X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Jul 2018 02:38:19 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable The fix is good.=20 I suggest you create another patch to add UefiShellAcpiViewCommandLib INF f= ile into [Components] of ShellPkg.dsc. If so, this library can be built in = the package level build.=20 Thanks Liming >-----Original Message----- >From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of >AlexeiFedorov >Sent: Friday, July 13, 2018 11:17 PM >To: edk2-devel@lists.01.org >Cc: Ni, Ruiyu ; Stephanie.Hughes-Fitt@arm.com; Carsey, >Jaben ; nd@arm.com >Subject: [edk2] [PATCH v1] ShellPkg/UefiShellAcpiViewCommandLib: Fix >VS2017 compilation errors > >This patch fixes VS2017 compilation errors for >UefiShellAcpiViewCommandLib\Parsers\Gtdt\GtdtParser.c >and >UefiShellAcpiViewCommandLib\Parsers\Xsdt\XsdtParser.c >reported in >https://bugzilla.tianocore.org/show_bug.cgi?id=3D985 >https://bugzilla.tianocore.org/show_bug.cgi?id=3D986 > >Contributed-under: TianoCore Contribution Agreement 1.1 >Signed-off-by: Alexei Fedorov >--- >All the changes can be reviewed at >https://github.com/AlexeiFedorov/edk2/tree/298_acpiview_fix_v1 > >Notes: > v1: > - GtdtParser.c DumpFTBlock() function: > change UINT16 type of Length parameter to UINT32 > change UINT16 type of GTBlockTimerLength variable to UINT32 > - XsdtParser.c ParseAcpiXsdt() function: > change name of local variable from Ptr to SignaturePtr > > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser.c >| 4 ++-- > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Xsdt/XsdtParser.c | >12 ++++++------ > 2 files changed, 8 insertions(+), 8 deletions(-) > >diff --git >a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser. >c >b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser. >c >index >3a3cee948ad8cd35ef3a6e13fec9d44300dbe73f..0ab460b02c9e062ac181e42e7e >77f875a40c86dc 100644 >--- >a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser. >c >+++ >b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser. >c >@@ -161,12 +161,12 @@ STATIC > VOID > DumpGTBlock ( > IN UINT8* Ptr, >- IN UINT16 Length >+ IN UINT32 Length > ) > { > UINT32 Index; > UINT32 Offset; >- UINT16 GTBlockTimerLength; >+ UINT32 GTBlockTimerLength; > > Offset =3D ParseAcpi ( > TRUE, >diff --git >a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Xsdt/XsdtParser.c >b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Xsdt/XsdtParser.c >index >99521cd67a714065c2eb9e4e5ec0f2e21f4c9da9..a5e1412484b56258c40e0cb4d7 >95157ffbce6826 100644 >--- >a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Xsdt/XsdtParser.c >+++ >b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Xsdt/XsdtParser.c >@@ -96,7 +96,7 @@ ParseAcpiXsdt ( > CONST UINT8* Revision; > > if ((UINT64*)(UINTN)(*TablePointer) !=3D NULL) { >- UINT8* Ptr; >+ UINT8* SignaturePtr; > > ParseAcpiHeader ( > (UINT8*)(UINTN)(*TablePointer), >@@ -105,17 +105,17 @@ ParseAcpiXsdt ( > &Revision > ); > >- Ptr =3D (UINT8*)Signature; >+ SignaturePtr =3D (UINT8*)Signature; > > UnicodeSPrint ( > Buffer, > sizeof (Buffer), > L"Entry[%d] - %c%c%c%c", > EntryIndex++, >- Ptr[0], >- Ptr[1], >- Ptr[2], >- Ptr[3] >+ SignaturePtr[0], >+ SignaturePtr[1], >+ SignaturePtr[2], >+ SignaturePtr[3] > ); > } else { > UnicodeSPrint ( >-- >'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' > > >_______________________________________________ >edk2-devel mailing list >edk2-devel@lists.01.org >https://lists.01.org/mailman/listinfo/edk2-devel