public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gao, Liming" <liming.gao@intel.com>
To: "Zhu, Yonghong" <yonghong.zhu@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [Patch] BaseTools: ElfConvert Tool update VerboseMsg to same with the comment
Date: Mon, 23 Jul 2018 02:10:44 +0000	[thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E2BF6FA@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <1531452733-4352-1-git-send-email-yonghong.zhu@intel.com>

Reviewed-by: Liming Gao <liming.gao@intel.com>

>-----Original Message-----
>From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
>Yonghong Zhu
>Sent: Friday, July 13, 2018 11:32 AM
>To: edk2-devel@lists.01.org
>Subject: [edk2] [Patch] BaseTools: ElfConvert Tool update VerboseMsg to
>same with the comment
>
>Fixes: https://bugzilla.tianocore.org/show_bug.cgi?id=994
>Contributed-under: TianoCore Contribution Agreement 1.0
>Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
>---
> BaseTools/Source/C/GenFw/Elf32Convert.c | 2 +-
> BaseTools/Source/C/GenFw/Elf64Convert.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/BaseTools/Source/C/GenFw/Elf32Convert.c
>b/BaseTools/Source/C/GenFw/Elf32Convert.c
>index af5ff93..3d7de6d 100644
>--- a/BaseTools/Source/C/GenFw/Elf32Convert.c
>+++ b/BaseTools/Source/C/GenFw/Elf32Convert.c
>@@ -688,11 +688,11 @@ WriteSections32 (
>
>       default:
>         //
>         //  Ignore for unkown section type.
>         //
>-        VerboseMsg ("%s unknown section type %x. We directly copy this
>section into Coff file", mInImageName, (unsigned)Shdr->sh_type);
>+        VerboseMsg ("%s unknown section type %x. We ignore this unknown
>section type.", mInImageName, (unsigned)Shdr->sh_type);
>         break;
>       }
>     }
>   }
>
>diff --git a/BaseTools/Source/C/GenFw/Elf64Convert.c
>b/BaseTools/Source/C/GenFw/Elf64Convert.c
>index 15da89c..469979c 100644
>--- a/BaseTools/Source/C/GenFw/Elf64Convert.c
>+++ b/BaseTools/Source/C/GenFw/Elf64Convert.c
>@@ -822,11 +822,11 @@ WriteSections64 (
>
>       default:
>         //
>         //  Ignore for unkown section type.
>         //
>-        VerboseMsg ("%s unknown section type %x. We directly copy this
>section into Coff file", mInImageName, (unsigned)Shdr->sh_type);
>+        VerboseMsg ("%s unknown section type %x. We ignore this unknown
>section type.", mInImageName, (unsigned)Shdr->sh_type);
>         break;
>       }
>     }
>   }
>
>--
>2.6.1.windows.1
>
>_______________________________________________
>edk2-devel mailing list
>edk2-devel@lists.01.org
>https://lists.01.org/mailman/listinfo/edk2-devel


      reply	other threads:[~2018-07-23  2:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-13  3:32 [Patch] BaseTools: ElfConvert Tool update VerboseMsg to same with the comment Yonghong Zhu
2018-07-23  2:10 ` Gao, Liming [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E2BF6FA@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox