public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH 0/1] BaseTools changes for Management Mode modules
@ 2018-07-03 10:00 Supreeth Venkatesh
  2018-07-03 10:00 ` [PATCH] BaseTools/AutoGen: Update header file for MM modules Supreeth Venkatesh
  0 siblings, 1 reply; 4+ messages in thread
From: Supreeth Venkatesh @ 2018-07-03 10:00 UTC (permalink / raw)
  To: edk2-devel

The following patch makes changes in AutoGen scripts for Management
Mode related code.

Note: This patch series needs to be applied after applying
Standalone Management Mode core interface support for aarch64
platforms[1] and ArmPkg related changes for StandaloneMM package[2]

[1] - https://lists.01.org/pipermail/edk2-devel/2018-July/026778.html
[2] - https://lists.01.org/pipermail/edk2-devel/2018-July/026791.html

Supreeth Venkatesh (1):
  BaseTools/AutoGen: Update header file for MM modules.

 BaseTools/Source/Python/AutoGen/GenC.py | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

-- 
2.7.4




^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] BaseTools/AutoGen: Update header file for MM modules.
  2018-07-03 10:00 [PATCH 0/1] BaseTools changes for Management Mode modules Supreeth Venkatesh
@ 2018-07-03 10:00 ` Supreeth Venkatesh
  2018-07-03 11:56   ` Gao, Liming
  0 siblings, 1 reply; 4+ messages in thread
From: Supreeth Venkatesh @ 2018-07-03 10:00 UTC (permalink / raw)
  To: edk2-devel; +Cc: Supreeth Venkatesh, Jiewen Yao

This patch corrects the Module Type Header file for Management Mode(MM)
as specified in PI v1.6 Specification. Also, it updates parameter for
auto generated template functions from EFI_SMM_SYSTEM_TABLE2 to
EFI_MM_SYSTEM_TABLE.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
Reviewed-by: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
---
 BaseTools/Source/Python/AutoGen/GenC.py | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/BaseTools/Source/Python/AutoGen/GenC.py b/BaseTools/Source/Python/AutoGen/GenC.py
index 5c3552a..55bcaba 100644
--- a/BaseTools/Source/Python/AutoGen/GenC.py
+++ b/BaseTools/Source/Python/AutoGen/GenC.py
@@ -265,7 +265,7 @@ EFI_STATUS
 EFIAPI
 ${Function} (
   IN EFI_HANDLE            ImageHandle,
-  IN EFI_SMM_SYSTEM_TABLE2 *MmSystemTable
+  IN EFI_MM_SYSTEM_TABLE   *MmSystemTable
   );
 ${END}
 """)
@@ -278,7 +278,7 @@ EFI_STATUS
 EFIAPI
 ProcessModuleEntryPointList (
   IN EFI_HANDLE            ImageHandle,
-  IN EFI_SMM_SYSTEM_TABLE2 *MmSystemTable
+  IN EFI_MM_SYSTEM_TABLE   *MmSystemTable
   )
 
 {
@@ -292,7 +292,7 @@ EFI_STATUS
 EFIAPI
 ProcessModuleEntryPointList (
   IN EFI_HANDLE            ImageHandle,
-  IN EFI_SMM_SYSTEM_TABLE2 *MmSystemTable
+  IN EFI_MM_SYSTEM_TABLE   *MmSystemTable
   )
 
 {
@@ -307,7 +307,7 @@ EFI_STATUS
 EFIAPI
 ProcessModuleEntryPointList (
   IN EFI_HANDLE            ImageHandle,
-  IN EFI_SMM_SYSTEM_TABLE2 *MmSystemTable
+  IN EFI_MM_SYSTEM_TABLE   *MmSystemTable
   )
 
 {
@@ -675,7 +675,7 @@ EFI_STATUS
 EFIAPI
 ${Function} (
   IN EFI_HANDLE            ImageHandle,
-  IN EFI_SMM_SYSTEM_TABLE2  *MmSystemTable
+  IN EFI_MM_SYSTEM_TABLE   *MmSystemTable
   );${END}
 """),
 }
@@ -755,7 +755,7 @@ VOID
 EFIAPI
 ProcessLibrary${Type}List (
   IN EFI_HANDLE            ImageHandle,
-  IN EFI_SMM_SYSTEM_TABLE2  *MmSystemTable
+  IN EFI_MM_SYSTEM_TABLE   *MmSystemTable
   )
 {
 ${BEGIN}  EFI_STATUS  Status;
@@ -779,8 +779,8 @@ gModuleTypeHeaderFile = {
     SUP_MODULE_UEFI_DRIVER       :   ["Uefi.h",  "Library/BaseLib.h", "Library/DebugLib.h", "Library/UefiBootServicesTableLib.h", "Library/UefiDriverEntryPoint.h"],
     SUP_MODULE_UEFI_APPLICATION  :   ["Uefi.h",  "Library/BaseLib.h", "Library/DebugLib.h", "Library/UefiBootServicesTableLib.h", "Library/UefiApplicationEntryPoint.h"],
     SUP_MODULE_SMM_CORE          :   ["PiDxe.h", "Library/BaseLib.h", "Library/DebugLib.h", "Library/UefiDriverEntryPoint.h"],
-    SUP_MODULE_MM_STANDALONE     :   ["PiSmm.h", "Library/BaseLib.h", "Library/DebugLib.h", "Library/SmmDriverStandaloneEntryPoint.h"],
-    SUP_MODULE_MM_CORE_STANDALONE :  ["PiSmm.h", "Library/BaseLib.h", "Library/DebugLib.h", "Library/SmmCoreStandaloneEntryPoint.h"],
+    SUP_MODULE_MM_STANDALONE     :   ["PiMm.h", "Library/BaseLib.h", "Library/DebugLib.h", "Library/StandaloneMmDriverEntryPoint.h"],
+    SUP_MODULE_MM_CORE_STANDALONE :  ["PiMm.h", "Library/BaseLib.h", "Library/DebugLib.h", "Library/StandaloneMmCoreEntryPoint.h"],
     SUP_MODULE_USER_DEFINED      :   [gBasicHeaderFile]
 }
 
-- 
2.7.4



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] BaseTools/AutoGen: Update header file for MM modules.
  2018-07-03 10:00 ` [PATCH] BaseTools/AutoGen: Update header file for MM modules Supreeth Venkatesh
@ 2018-07-03 11:56   ` Gao, Liming
  2018-07-23  3:13     ` Gao, Liming
  0 siblings, 1 reply; 4+ messages in thread
From: Gao, Liming @ 2018-07-03 11:56 UTC (permalink / raw)
  To: Supreeth Venkatesh, edk2-devel@lists.01.org; +Cc: Yao, Jiewen

Reviewed-by: Liming Gao <liming.gao@intel.com>

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Supreeth Venkatesh
> Sent: Tuesday, July 3, 2018 6:01 PM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen <jiewen.yao@intel.com>
> Subject: [edk2] [PATCH] BaseTools/AutoGen: Update header file for MM modules.
> 
> This patch corrects the Module Type Header file for Management Mode(MM)
> as specified in PI v1.6 Specification. Also, it updates parameter for
> auto generated template functions from EFI_SMM_SYSTEM_TABLE2 to
> EFI_MM_SYSTEM_TABLE.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
> Reviewed-by: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> ---
>  BaseTools/Source/Python/AutoGen/GenC.py | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/BaseTools/Source/Python/AutoGen/GenC.py b/BaseTools/Source/Python/AutoGen/GenC.py
> index 5c3552a..55bcaba 100644
> --- a/BaseTools/Source/Python/AutoGen/GenC.py
> +++ b/BaseTools/Source/Python/AutoGen/GenC.py
> @@ -265,7 +265,7 @@ EFI_STATUS
>  EFIAPI
>  ${Function} (
>    IN EFI_HANDLE            ImageHandle,
> -  IN EFI_SMM_SYSTEM_TABLE2 *MmSystemTable
> +  IN EFI_MM_SYSTEM_TABLE   *MmSystemTable
>    );
>  ${END}
>  """)
> @@ -278,7 +278,7 @@ EFI_STATUS
>  EFIAPI
>  ProcessModuleEntryPointList (
>    IN EFI_HANDLE            ImageHandle,
> -  IN EFI_SMM_SYSTEM_TABLE2 *MmSystemTable
> +  IN EFI_MM_SYSTEM_TABLE   *MmSystemTable
>    )
> 
>  {
> @@ -292,7 +292,7 @@ EFI_STATUS
>  EFIAPI
>  ProcessModuleEntryPointList (
>    IN EFI_HANDLE            ImageHandle,
> -  IN EFI_SMM_SYSTEM_TABLE2 *MmSystemTable
> +  IN EFI_MM_SYSTEM_TABLE   *MmSystemTable
>    )
> 
>  {
> @@ -307,7 +307,7 @@ EFI_STATUS
>  EFIAPI
>  ProcessModuleEntryPointList (
>    IN EFI_HANDLE            ImageHandle,
> -  IN EFI_SMM_SYSTEM_TABLE2 *MmSystemTable
> +  IN EFI_MM_SYSTEM_TABLE   *MmSystemTable
>    )
> 
>  {
> @@ -675,7 +675,7 @@ EFI_STATUS
>  EFIAPI
>  ${Function} (
>    IN EFI_HANDLE            ImageHandle,
> -  IN EFI_SMM_SYSTEM_TABLE2  *MmSystemTable
> +  IN EFI_MM_SYSTEM_TABLE   *MmSystemTable
>    );${END}
>  """),
>  }
> @@ -755,7 +755,7 @@ VOID
>  EFIAPI
>  ProcessLibrary${Type}List (
>    IN EFI_HANDLE            ImageHandle,
> -  IN EFI_SMM_SYSTEM_TABLE2  *MmSystemTable
> +  IN EFI_MM_SYSTEM_TABLE   *MmSystemTable
>    )
>  {
>  ${BEGIN}  EFI_STATUS  Status;
> @@ -779,8 +779,8 @@ gModuleTypeHeaderFile = {
>      SUP_MODULE_UEFI_DRIVER       :   ["Uefi.h",  "Library/BaseLib.h", "Library/DebugLib.h",
> "Library/UefiBootServicesTableLib.h", "Library/UefiDriverEntryPoint.h"],
>      SUP_MODULE_UEFI_APPLICATION  :   ["Uefi.h",  "Library/BaseLib.h", "Library/DebugLib.h",
> "Library/UefiBootServicesTableLib.h", "Library/UefiApplicationEntryPoint.h"],
>      SUP_MODULE_SMM_CORE          :   ["PiDxe.h", "Library/BaseLib.h", "Library/DebugLib.h",
> "Library/UefiDriverEntryPoint.h"],
> -    SUP_MODULE_MM_STANDALONE     :   ["PiSmm.h", "Library/BaseLib.h", "Library/DebugLib.h",
> "Library/SmmDriverStandaloneEntryPoint.h"],
> -    SUP_MODULE_MM_CORE_STANDALONE :  ["PiSmm.h", "Library/BaseLib.h", "Library/DebugLib.h",
> "Library/SmmCoreStandaloneEntryPoint.h"],
> +    SUP_MODULE_MM_STANDALONE     :   ["PiMm.h", "Library/BaseLib.h", "Library/DebugLib.h",
> "Library/StandaloneMmDriverEntryPoint.h"],
> +    SUP_MODULE_MM_CORE_STANDALONE :  ["PiMm.h", "Library/BaseLib.h", "Library/DebugLib.h",
> "Library/StandaloneMmCoreEntryPoint.h"],
>      SUP_MODULE_USER_DEFINED      :   [gBasicHeaderFile]
>  }
> 
> --
> 2.7.4
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] BaseTools/AutoGen: Update header file for MM modules.
  2018-07-03 11:56   ` Gao, Liming
@ 2018-07-23  3:13     ` Gao, Liming
  0 siblings, 0 replies; 4+ messages in thread
From: Gao, Liming @ 2018-07-23  3:13 UTC (permalink / raw)
  To: Gao, Liming, Supreeth Venkatesh, edk2-devel@lists.01.org; +Cc: Yao, Jiewen

Push at 549ae85ce1b00228c3abcf6a9e4022c4f4fba5ed

>-----Original Message-----
>From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Gao,
>Liming
>Sent: Tuesday, July 03, 2018 7:57 PM
>To: Supreeth Venkatesh <supreeth.venkatesh@arm.com>; edk2-
>devel@lists.01.org
>Cc: Yao, Jiewen <jiewen.yao@intel.com>
>Subject: Re: [edk2] [PATCH] BaseTools/AutoGen: Update header file for MM
>modules.
>
>Reviewed-by: Liming Gao <liming.gao@intel.com>
>
>> -----Original Message-----
>> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
>Supreeth Venkatesh
>> Sent: Tuesday, July 3, 2018 6:01 PM
>> To: edk2-devel@lists.01.org
>> Cc: Yao, Jiewen <jiewen.yao@intel.com>
>> Subject: [edk2] [PATCH] BaseTools/AutoGen: Update header file for MM
>modules.
>>
>> This patch corrects the Module Type Header file for Management
>Mode(MM)
>> as specified in PI v1.6 Specification. Also, it updates parameter for
>> auto generated template functions from EFI_SMM_SYSTEM_TABLE2 to
>> EFI_MM_SYSTEM_TABLE.
>>
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
>> Reviewed-by: Jiewen Yao <jiewen.yao@intel.com>
>> Cc: Jiewen Yao <jiewen.yao@intel.com>
>> ---
>>  BaseTools/Source/Python/AutoGen/GenC.py | 16 ++++++++--------
>>  1 file changed, 8 insertions(+), 8 deletions(-)
>>
>> diff --git a/BaseTools/Source/Python/AutoGen/GenC.py
>b/BaseTools/Source/Python/AutoGen/GenC.py
>> index 5c3552a..55bcaba 100644
>> --- a/BaseTools/Source/Python/AutoGen/GenC.py
>> +++ b/BaseTools/Source/Python/AutoGen/GenC.py
>> @@ -265,7 +265,7 @@ EFI_STATUS
>>  EFIAPI
>>  ${Function} (
>>    IN EFI_HANDLE            ImageHandle,
>> -  IN EFI_SMM_SYSTEM_TABLE2 *MmSystemTable
>> +  IN EFI_MM_SYSTEM_TABLE   *MmSystemTable
>>    );
>>  ${END}
>>  """)
>> @@ -278,7 +278,7 @@ EFI_STATUS
>>  EFIAPI
>>  ProcessModuleEntryPointList (
>>    IN EFI_HANDLE            ImageHandle,
>> -  IN EFI_SMM_SYSTEM_TABLE2 *MmSystemTable
>> +  IN EFI_MM_SYSTEM_TABLE   *MmSystemTable
>>    )
>>
>>  {
>> @@ -292,7 +292,7 @@ EFI_STATUS
>>  EFIAPI
>>  ProcessModuleEntryPointList (
>>    IN EFI_HANDLE            ImageHandle,
>> -  IN EFI_SMM_SYSTEM_TABLE2 *MmSystemTable
>> +  IN EFI_MM_SYSTEM_TABLE   *MmSystemTable
>>    )
>>
>>  {
>> @@ -307,7 +307,7 @@ EFI_STATUS
>>  EFIAPI
>>  ProcessModuleEntryPointList (
>>    IN EFI_HANDLE            ImageHandle,
>> -  IN EFI_SMM_SYSTEM_TABLE2 *MmSystemTable
>> +  IN EFI_MM_SYSTEM_TABLE   *MmSystemTable
>>    )
>>
>>  {
>> @@ -675,7 +675,7 @@ EFI_STATUS
>>  EFIAPI
>>  ${Function} (
>>    IN EFI_HANDLE            ImageHandle,
>> -  IN EFI_SMM_SYSTEM_TABLE2  *MmSystemTable
>> +  IN EFI_MM_SYSTEM_TABLE   *MmSystemTable
>>    );${END}
>>  """),
>>  }
>> @@ -755,7 +755,7 @@ VOID
>>  EFIAPI
>>  ProcessLibrary${Type}List (
>>    IN EFI_HANDLE            ImageHandle,
>> -  IN EFI_SMM_SYSTEM_TABLE2  *MmSystemTable
>> +  IN EFI_MM_SYSTEM_TABLE   *MmSystemTable
>>    )
>>  {
>>  ${BEGIN}  EFI_STATUS  Status;
>> @@ -779,8 +779,8 @@ gModuleTypeHeaderFile = {
>>      SUP_MODULE_UEFI_DRIVER       :   ["Uefi.h",  "Library/BaseLib.h",
>"Library/DebugLib.h",
>> "Library/UefiBootServicesTableLib.h", "Library/UefiDriverEntryPoint.h"],
>>      SUP_MODULE_UEFI_APPLICATION  :   ["Uefi.h",  "Library/BaseLib.h",
>"Library/DebugLib.h",
>> "Library/UefiBootServicesTableLib.h",
>"Library/UefiApplicationEntryPoint.h"],
>>      SUP_MODULE_SMM_CORE          :   ["PiDxe.h", "Library/BaseLib.h",
>"Library/DebugLib.h",
>> "Library/UefiDriverEntryPoint.h"],
>> -    SUP_MODULE_MM_STANDALONE     :   ["PiSmm.h", "Library/BaseLib.h",
>"Library/DebugLib.h",
>> "Library/SmmDriverStandaloneEntryPoint.h"],
>> -    SUP_MODULE_MM_CORE_STANDALONE :  ["PiSmm.h",
>"Library/BaseLib.h", "Library/DebugLib.h",
>> "Library/SmmCoreStandaloneEntryPoint.h"],
>> +    SUP_MODULE_MM_STANDALONE     :   ["PiMm.h", "Library/BaseLib.h",
>"Library/DebugLib.h",
>> "Library/StandaloneMmDriverEntryPoint.h"],
>> +    SUP_MODULE_MM_CORE_STANDALONE :  ["PiMm.h",
>"Library/BaseLib.h", "Library/DebugLib.h",
>> "Library/StandaloneMmCoreEntryPoint.h"],
>>      SUP_MODULE_USER_DEFINED      :   [gBasicHeaderFile]
>>  }
>>
>> --
>> 2.7.4
>>
>> _______________________________________________
>> edk2-devel mailing list
>> edk2-devel@lists.01.org
>> https://lists.01.org/mailman/listinfo/edk2-devel
>_______________________________________________
>edk2-devel mailing list
>edk2-devel@lists.01.org
>https://lists.01.org/mailman/listinfo/edk2-devel


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-07-23  3:13 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-03 10:00 [PATCH 0/1] BaseTools changes for Management Mode modules Supreeth Venkatesh
2018-07-03 10:00 ` [PATCH] BaseTools/AutoGen: Update header file for MM modules Supreeth Venkatesh
2018-07-03 11:56   ` Gao, Liming
2018-07-23  3:13     ` Gao, Liming

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox