From: "Gao, Liming" <liming.gao@intel.com>
To: "Marvin.Haeuser@outlook.com" <Marvin.Haeuser@outlook.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Ni, Ruiyu" <ruiyu.ni@intel.com>
Subject: Re: [PATCH] PcAtChipsetPkg/AcpiTimerLib: Do not restrict Base instance.
Date: Mon, 23 Jul 2018 06:34:22 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E2BF95D@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <VI1PR0801MB179009B8705AC466F64B922680570@VI1PR0801MB1790.eurprd08.prod.outlook.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
>-----Original Message-----
>From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
>Marvin H?user
>Sent: Monday, July 23, 2018 7:05 AM
>To: edk2-devel@lists.01.org
>Cc: Ni, Ruiyu <ruiyu.ni@intel.com>
>Subject: [edk2] [PATCH] PcAtChipsetPkg/AcpiTimerLib: Do not restrict Base
>instance.
>
>The current Base AcpiTimerLib instance restricts usage to SEC and PEI
>modules, for which there is no obvious reason. Lift this restriction.
>
>Contributed-under: TianoCore Contribution Agreement 1.1
>Signed-off-by: Marvin Haeuser <Marvin.Haeuser@outlook.com>
>---
> PcAtChipsetPkg/Library/AcpiTimerLib/BaseAcpiTimerLib.inf | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/PcAtChipsetPkg/Library/AcpiTimerLib/BaseAcpiTimerLib.inf
>b/PcAtChipsetPkg/Library/AcpiTimerLib/BaseAcpiTimerLib.inf
>index b7f737e30ac8..df9eecfdaeaa 100644
>--- a/PcAtChipsetPkg/Library/AcpiTimerLib/BaseAcpiTimerLib.inf
>+++ b/PcAtChipsetPkg/Library/AcpiTimerLib/BaseAcpiTimerLib.inf
>@@ -24,7 +24,7 @@ [Defines]
> FILE_GUID = 564DE85F-049E-4481-BF7A-CA04D2788CF9
> MODULE_TYPE = BASE
> VERSION_STRING = 1.0
>- LIBRARY_CLASS = TimerLib|SEC PEI_CORE PEIM
>+ LIBRARY_CLASS = TimerLib
> CONSTRUCTOR = AcpiTimerLibConstructor
> MODULE_UNI_FILE = BaseAcpiTimerLib.uni
>
>--
>2.18.0.windows.1
>
>_______________________________________________
>edk2-devel mailing list
>edk2-devel@lists.01.org
>https://lists.01.org/mailman/listinfo/edk2-devel
prev parent reply other threads:[~2018-07-23 6:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-22 23:05 [PATCH] PcAtChipsetPkg/AcpiTimerLib: Do not restrict Base instance Marvin Häuser
2018-07-23 6:34 ` Gao, Liming [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E2BF95D@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox