From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.88; helo=mga01.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id EA64F21B02845 for ; Sun, 22 Jul 2018 23:47:20 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Jul 2018 23:47:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,392,1526367600"; d="scan'208";a="248016789" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga006.fm.intel.com with ESMTP; 22 Jul 2018 23:46:22 -0700 Received: from fmsmsx157.amr.corp.intel.com (10.18.116.73) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 22 Jul 2018 23:46:22 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX157.amr.corp.intel.com (10.18.116.73) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 22 Jul 2018 23:46:21 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.81]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.100]) with mapi id 14.03.0319.002; Mon, 23 Jul 2018 14:46:20 +0800 From: "Gao, Liming" To: "Marvin.Haeuser@outlook.com" , "edk2-devel@lists.01.org" CC: "Ni, Ruiyu" Thread-Topic: [PATCH] PcAtChipsetPkg/AcpiTimerLib: Support Standalone MM. Thread-Index: AQHUIhB7GSTxFqqMxkmssOyakdK+N6ScW0XA Date: Mon, 23 Jul 2018 06:46:19 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E2BF982@SHSMSX104.ccr.corp.intel.com> References: <3e63e0c06e38886af03bfc7a7e90ce6608f44ce8.1532300587.git.Marvin.Haeuser@outlook.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] PcAtChipsetPkg/AcpiTimerLib: Support Standalone MM. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Jul 2018 06:47:21 -0000 Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Marvin: If this library supports standalone MM module only, I agree its source fi= le includes Standalone MM But, this library instance also supports DXE, SMM. I don't think Standalo= neMm name is good for them.=20 Besides, I want to know why you changes this library instance. Are there = the standalone MM module to depend on this AcpiTimerLib? Thanks Liming >-----Original Message----- >From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of >Marvin H?user >Sent: Monday, July 23, 2018 7:05 AM >To: edk2-devel@lists.01.org >Cc: Ni, Ruiyu >Subject: [edk2] [PATCH] PcAtChipsetPkg/AcpiTimerLib: Support Standalone >MM. > >To support Standalone MM, the current DXE implementation, which is >also used to support DXE SMM Drivers, has been modified. Its type was >changed to BASE to make the constructor function generic, >MM_STANDALONE modules types have been added to the support list and >the internal files were adapted to show support. > >"DxeAcpiTimerLib.inf" has not been renamed to not break packages. >This might be addressed with a separate patch. > >Contributed-under: TianoCore Contribution Agreement 1.1 >Signed-off-by: Marvin Haeuser >--- > PcAtChipsetPkg/Library/AcpiTimerLib/{DxeAcpiTimerLib.c =3D> >DxeStandaloneMmAcpiTimerLib.c} | 9 +++------ > PcAtChipsetPkg/Library/AcpiTimerLib/DxeAcpiTimerLib.inf >| 14 +++++++------- > PcAtChipsetPkg/Library/AcpiTimerLib/{DxeAcpiTimerLib.uni =3D> >StandaloneMmDxeAcpiTimerLib.uni} | 2 +- > 3 files changed, 11 insertions(+), 14 deletions(-) > >diff --git a/PcAtChipsetPkg/Library/AcpiTimerLib/DxeAcpiTimerLib.c >b/PcAtChipsetPkg/Library/AcpiTimerLib/DxeStandaloneMmAcpiTimerLib.c >similarity index 88% >rename from PcAtChipsetPkg/Library/AcpiTimerLib/DxeAcpiTimerLib.c >rename to >PcAtChipsetPkg/Library/AcpiTimerLib/DxeStandaloneMmAcpiTimerLib.c >index 9ed10ef2e297..784f33871d75 100644 >--- a/PcAtChipsetPkg/Library/AcpiTimerLib/DxeAcpiTimerLib.c >+++ >b/PcAtChipsetPkg/Library/AcpiTimerLib/DxeStandaloneMmAcpiTimerLib.c >@@ -13,6 +13,7 @@ > **/ > > #include >+#include > #include > #include > #include >@@ -78,17 +79,13 @@ InternalGetPerformanceCounterFrequency ( > /** > The constructor function enables ACPI IO space, and caches >PerformanceCounterFrequency. > >- @param ImageHandle The firmware allocated handle for the EFI image. >- @param SystemTable A pointer to the EFI System Table. >- > @retval EFI_SUCCESS The constructor always returns RETURN_SUCCESS. > > **/ > EFI_STATUS > EFIAPI >-DxeAcpiTimerLibConstructor ( >- IN EFI_HANDLE ImageHandle, >- IN EFI_SYSTEM_TABLE *SystemTable >+DxeStandaloneMmAcpiTimerLibConstructor ( >+ VOID > ) > { > EFI_HOB_GUID_TYPE *GuidHob; >diff --git a/PcAtChipsetPkg/Library/AcpiTimerLib/DxeAcpiTimerLib.inf >b/PcAtChipsetPkg/Library/AcpiTimerLib/DxeAcpiTimerLib.inf >index 601041c80137..f1f62247649e 100644 >--- a/PcAtChipsetPkg/Library/AcpiTimerLib/DxeAcpiTimerLib.inf >+++ b/PcAtChipsetPkg/Library/AcpiTimerLib/DxeAcpiTimerLib.inf >@@ -1,5 +1,5 @@ > ## @file >-# DXE ACPI Timer Library >+# DXE and Standalone MM ACPI Timer Library > # > # Provides basic timer support using the ACPI timer hardware. The >performance > # counter features are provided by the processors time stamp counter. >@@ -20,17 +20,17 @@ > > [Defines] > INF_VERSION =3D 0x00010005 >- BASE_NAME =3D DxeAcpiTimerLib >+ BASE_NAME =3D DxeStandaloneMmAcpiTimerLib > FILE_GUID =3D E624B98C-845A-4b94-9B50-B20475D552B9 >- MODULE_TYPE =3D DXE_DRIVER >+ MODULE_TYPE =3D BASE > VERSION_STRING =3D 1.0 >- LIBRARY_CLASS =3D TimerLib|DXE_CORE DXE_DRIVER >DXE_RUNTIME_DRIVER DXE_SMM_DRIVER UEFI_APPLICATION UEFI_DRIVER >SMM_CORE >- CONSTRUCTOR =3D DxeAcpiTimerLibConstructor >- MODULE_UNI_FILE =3D DxeAcpiTimerLib.uni >+ LIBRARY_CLASS =3D TimerLib|DXE_CORE DXE_DRIVER >DXE_RUNTIME_DRIVER DXE_SMM_DRIVER MM_STANDALONE >UEFI_APPLICATION UEFI_DRIVER SMM_CORE MM_CORE_STANDALONE >+ CONSTRUCTOR =3D DxeStandaloneMmAcpiTimerLibConstruct= or >+ MODULE_UNI_FILE =3D DxeStandaloneMmAcpiTimerLib.uni > > [Sources] > AcpiTimerLib.c >- DxeAcpiTimerLib.c >+ DxeStandaloneMmAcpiTimerLib.c > > [Packages] > MdePkg/MdePkg.dec >diff --git a/PcAtChipsetPkg/Library/AcpiTimerLib/DxeAcpiTimerLib.uni >b/PcAtChipsetPkg/Library/AcpiTimerLib/StandaloneMmDxeAcpiTimerLib.uni >similarity index 92% >rename from PcAtChipsetPkg/Library/AcpiTimerLib/DxeAcpiTimerLib.uni >rename to >PcAtChipsetPkg/Library/AcpiTimerLib/StandaloneMmDxeAcpiTimerLib.uni >index bf31abf81d68..6b3abb85ebc8 100644 >--- a/PcAtChipsetPkg/Library/AcpiTimerLib/DxeAcpiTimerLib.uni >+++ >b/PcAtChipsetPkg/Library/AcpiTimerLib/StandaloneMmDxeAcpiTimerLib.uni >@@ -1,5 +1,5 @@ > // /** @file >-// DXE ACPI Timer Library >+// DXE and Standalone MM ACPI Timer Library > // > // Provides basic timer support using the ACPI timer hardware. The >performance > // counter features are provided by the processors time stamp counter. >-- >2.18.0.windows.1 > >_______________________________________________ >edk2-devel mailing list >edk2-devel@lists.01.org >https://lists.01.org/mailman/listinfo/edk2-devel