From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.20; helo=mga02.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id F29A1210C1B7D for ; Tue, 24 Jul 2018 17:45:35 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Jul 2018 17:45:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,399,1526367600"; d="scan'208";a="59545694" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga008.jf.intel.com with ESMTP; 24 Jul 2018 17:44:51 -0700 Received: from fmsmsx115.amr.corp.intel.com (10.18.116.19) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 24 Jul 2018 17:44:51 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx115.amr.corp.intel.com (10.18.116.19) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 24 Jul 2018 17:44:51 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.81]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.57]) with mapi id 14.03.0319.002; Wed, 25 Jul 2018 08:44:48 +0800 From: "Gao, Liming" To: "Carsey, Jaben" , Laszlo Ersek , edk2-devel-01 Thread-Topic: [edk2] [PATCH] ArmVirtPkg: remove wrong and superfluous ResourcePublicationLib resolution Thread-Index: AQHUI1FAwwzI0nEiJESBWYHBI3Ijg6SebZaAgACspLA= Date: Wed, 25 Jul 2018 00:44:48 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E2C072D@SHSMSX104.ccr.corp.intel.com> References: <20180724132114.31505-1-lersek@redhat.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZGY4MGZmOGQtZjRiZC00NjZhLTliNzMtMzQ4NTkwZTg2NTI4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiT0ZoK2F5SXNOWm5uTjZZWlg3NlwvOStlcG5mZGM4aFVObm9ZS0lreVRIM1VtSlp0eU5nd3phV0c3Y1RJeU5BcWUifQ== dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] ArmVirtPkg: remove wrong and superfluous ResourcePublicationLib resolution X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Jul 2018 00:45:36 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Jaben: Yes. BaseTools can generate the error message for it. But, more checker i= n BaseTools parser phase will also increase the build performance. This is = the balance here.=20 Thanks Liming > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ca= rsey, Jaben > Sent: Wednesday, July 25, 2018 6:25 AM > To: Laszlo Ersek ; edk2-devel-01 > Subject: Re: [edk2] [PATCH] ArmVirtPkg: remove wrong and superfluous Reso= urcePublicationLib resolution >=20 > Laszlo, >=20 > Do you think that using the incorrect name for a library instance should = generate an error? I would have thought it would have... >=20 > -Jaben >=20 > > -----Original Message----- > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > > Laszlo Ersek > > Sent: Tuesday, July 24, 2018 6:21 AM > > To: edk2-devel-01 > > Subject: [edk2] [PATCH] ArmVirtPkg: remove wrong and superfluous > > ResourcePublicationLib resolution > > > > The class name for the "PeiResourcePublicationLib" instance is just > > "ResourcePublicationLib", not "PeiResourcePublicationLib". However, no > > module included in the ArmVirtPkg platforms depends on this lib class; > > remove its resolution. > > > > Cc: Ard Biesheuvel > > Cc: Julien Grall > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Laszlo Ersek > > --- > > > > Notes: > > built on all six platforms: > > > > ArmVirtQemu-AARCH64 > > ArmVirtQemu-ARM > > ArmVirtQemuKernel-AARCH64 > > ArmVirtQemuKernel-ARM > > ArmVirtXen-AARCH64 > > ArmVirtXen-ARM > > > > ArmVirtPkg/ArmVirt.dsc.inc | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc > > index 8bb54c5e6579..70a0ac4d786c 100644 > > --- a/ArmVirtPkg/ArmVirt.dsc.inc > > +++ b/ArmVirtPkg/ArmVirt.dsc.inc > > @@ -211,7 +211,6 @@ [LibraryClasses.common.PEIM] > > > > PerformanceLib|MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanc > > eLib.inf > > > > OemHookStatusCodeLib|MdeModulePkg/Library/OemHookStatusCodeLibN > > ull/OemHookStatusCodeLibNull.inf > > > > PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/Base > > PeCoffGetEntryPointLib.inf > > - > > PeiResourcePublicationLib|MdePkg/Library/PeiResourcePublicationLib/PeiR > > esourcePublicationLib.inf > > > > UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDeco > > mpressLib.inf > > > > ExtractGuidedSectionLib|MdePkg/Library/PeiExtractGuidedSectionLib/PeiEx > > tractGuidedSectionLib.inf > > > > -- > > 2.14.1.3.gb7cf6e02401b > > > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel