Re: [patch 2/2] SecurityPkg/Tcg: Add use case for new Perf macro

["Gao, Liming" <liming.gao@intel.com>]

Reviewed-by: Liming Gao <liming.gao@intel.com>

> -----Original Message-----
> From: Bi, Dandan
> Sent: Thursday, July 19, 2018 2:44 PM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming <liming.gao@intel.com>; Zhang, Chao B <chao.b.zhang@intel.com>
> Subject: [patch 2/2] SecurityPkg/Tcg: Add use case for new Perf macro
> 
> Add an example case for the usage of
> PERF_CALLBACK_BEGIN/PERF_CALLBACK_END
> 
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Chao Zhang <chao.b.zhang@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
>  SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c | 4 ++++
>  SecurityPkg/Tcg/TcgPei/TcgPei.c   | 5 +++++
>  SecurityPkg/Tcg/TcgPei/TcgPei.inf | 1 +
>  3 files changed, 10 insertions(+)
> 
> diff --git a/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c b/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c
> index 74cdd1fa88..09ef0c70a5 100644
> --- a/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c
> +++ b/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c
> @@ -159,10 +159,12 @@ EndofPeiSignalNotifyCallBack (
>  {
>    MEASURED_HOB_DATA *MeasuredHobData;
> 
>    MeasuredHobData = NULL;
> 
> +  PERF_CALLBACK_BEGIN (&gEfiEndOfPeiSignalPpiGuid);
> +
>    //
>    // Create a Guid hob to save all measured Fv
>    //
>    MeasuredHobData = BuildGuidHob(
>                        &gMeasuredFvHobGuid,
> @@ -184,10 +186,12 @@ EndofPeiSignalNotifyCallBack (
>      // Save measured child Fv info
>      //
>      CopyMem (&MeasuredHobData->MeasuredFvBuf[mMeasuredBaseFvIndex] , mMeasuredChildFvInfo,
> sizeof(EFI_PLATFORM_FIRMWARE_BLOB) * (mMeasuredChildFvIndex));
>    }
> 
> +  PERF_CALLBACK_END (&gEfiEndOfPeiSignalPpiGuid);
> +
>    return EFI_SUCCESS;
>  }
> 
>  /**
>    Make sure that the current PCR allocations, the TPM supported PCRs,
> diff --git a/SecurityPkg/Tcg/TcgPei/TcgPei.c b/SecurityPkg/Tcg/TcgPei/TcgPei.c
> index 1ed11a1b29..d07047580c 100644
> --- a/SecurityPkg/Tcg/TcgPei/TcgPei.c
> +++ b/SecurityPkg/Tcg/TcgPei/TcgPei.c
> @@ -39,10 +39,11 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
>  #include <Library/MemoryAllocationLib.h>
>  #include <Library/ReportStatusCodeLib.h>
>  #include <Library/Tpm12DeviceLib.h>
>  #include <Library/Tpm12CommandLib.h>
>  #include <Library/BaseCryptLib.h>
> +#include <Library/PerformanceLib.h>
> 
>  BOOLEAN                 mImageInMemory  = FALSE;
> 
>  EFI_PEI_PPI_DESCRIPTOR  mTpmInitializedPpiList = {
>    EFI_PEI_PPI_DESCRIPTOR_PPI | EFI_PEI_PPI_DESCRIPTOR_TERMINATE_LIST,
> @@ -168,10 +169,12 @@ EndofPeiSignalNotifyCallBack (
>  {
>    MEASURED_HOB_DATA *MeasuredHobData;
> 
>    MeasuredHobData = NULL;
> 
> +  PERF_CALLBACK_BEGIN (&gEfiEndOfPeiSignalPpiGuid);
> +
>    //
>    // Create a Guid hob to save all measured Fv
>    //
>    MeasuredHobData = BuildGuidHob(
>                        &gMeasuredFvHobGuid,
> @@ -193,10 +196,12 @@ EndofPeiSignalNotifyCallBack (
>      // Save measured child Fv info
>      //
>      CopyMem (&MeasuredHobData->MeasuredFvBuf[mMeasuredBaseFvIndex] , mMeasuredChildFvInfo,
> sizeof(EFI_PLATFORM_FIRMWARE_BLOB) * (mMeasuredChildFvIndex));
>    }
> 
> +  PERF_CALLBACK_END (&gEfiEndOfPeiSignalPpiGuid);
> +
>    return EFI_SUCCESS;
>  }
> 
>  /**
>  Single function calculates SHA1 digest value for all raw data. It
> diff --git a/SecurityPkg/Tcg/TcgPei/TcgPei.inf b/SecurityPkg/Tcg/TcgPei/TcgPei.inf
> index 0252511391..4c8a055c6c 100644
> --- a/SecurityPkg/Tcg/TcgPei/TcgPei.inf
> +++ b/SecurityPkg/Tcg/TcgPei/TcgPei.inf
> @@ -54,10 +54,11 @@
>    BaseLib
>    PcdLib
>    MemoryAllocationLib
>    ReportStatusCodeLib
>    Tpm12CommandLib
> +  PerformanceLib
> 
>  [Guids]
>    gTcgEventEntryHobGuid                                               ## PRODUCES               ## HOB
>    gTpmErrorHobGuid                                                    ## SOMETIMES_PRODUCES     ## HOB
>    gMeasuredFvHobGuid                                                  ## PRODUCES               ## HOB
> --
> 2.14.3.windows.1