From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.126; helo=mga18.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C65D4210D515D for ; Thu, 2 Aug 2018 08:40:14 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Aug 2018 08:40:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,436,1526367600"; d="scan'208";a="72797949" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga002.fm.intel.com with ESMTP; 02 Aug 2018 08:40:05 -0700 Received: from fmsmsx157.amr.corp.intel.com (10.18.116.73) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 2 Aug 2018 08:40:06 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX157.amr.corp.intel.com (10.18.116.73) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 2 Aug 2018 08:40:05 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.81]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.100]) with mapi id 14.03.0319.002; Thu, 2 Aug 2018 23:40:04 +0800 From: "Gao, Liming" To: Laszlo Ersek , edk2-devel-01 Thread-Topic: [PATCH 0/6] BaseTools/Source/C: take EXTRA_OPTFLAGS and EXTRA_LDFLAGS from the caller Thread-Index: AQHUJHnMlSWa3foRkkyt05fhKvbda6Ssopmg Date: Thu, 2 Aug 2018 15:40:03 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E2C4BDF@SHSMSX104.ccr.corp.intel.com> References: <20180726004415.13381-1-lersek@redhat.com> In-Reply-To: <20180726004415.13381-1-lersek@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiY2IwYmFiZWItN2JkZC00ZDcwLTk5ZTEtYTVjNjQ4MjJiMjg5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiT2pIK2JJeUJFWkdjcWdrR2YyZ1dIXC8zenNJUjA2WFlDWXZ4WjV4a3NJcjZxdzJkZG9vS0p5d0NsdmxHRWpJdncifQ== dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 0/6] BaseTools/Source/C: take EXTRA_OPTFLAGS and EXTRA_LDFLAGS from the caller X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Aug 2018 15:40:14 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Laszlo: I understand this patch set is to provide the way to append compile and l= ink option for BaseTools source build. If so, the extend flag name may be E= XTRA_CCFLAGS and EXTRA_LDFLAGS. And, the extend flags are appended in the t= ail.=20 Besides, Pccts is the internal tool to generate VfrCompiler syntax source= file. It is not used in build process. I am not sure why they also require= the additional CC and LD flags.=20 Thanks Liming > -----Original Message----- > From: Laszlo Ersek [mailto:lersek@redhat.com] > Sent: Thursday, July 26, 2018 8:44 AM > To: edk2-devel-01 > Cc: Gao, Liming ; Zhu, Yonghong > Subject: [PATCH 0/6] BaseTools/Source/C: take EXTRA_OPTFLAGS and EXTRA_LD= FLAGS from the caller >=20 > Repo: https://github.com/lersek/edk2.git > Branch: extra_flags_rhbz1540244 >=20 > In the Fedora distribution, we'd like to pass system-wide flags related > to optimization and linking when the C and C++ language base tools are > built. This series lets the outermost "make" command push the > EXTRA_OPTFLAGS and EXTRA_LDFLAGS macros into the BaseTools build. >=20 > Cc: Liming Gao > Cc: Yonghong Zhu >=20 > Thanks > Laszlo >=20 > Laszlo Ersek (6): > BaseTools/footer.makefile: expand BUILD_CFLAGS last for C files too > BaseTools/header.makefile: remove "-c" from BUILD_CFLAGS > BaseTools/Source/C: split "-O2" to BUILD_OPTFLAGS > BaseTools/Pccts: clean up antlr and dlg makefiles > BaseTools/Source/C: take EXTRA_OPTFLAGS from the caller > BaseTools/Source/C: take EXTRA_LDFLAGS from the caller >=20 > BaseTools/Source/C/Makefiles/footer.makefile | 2 +- > BaseTools/Source/C/Makefiles/header.makefile | 16 ++++++++--- > BaseTools/Source/C/VfrCompile/GNUmakefile | 11 +++++--- > BaseTools/Source/C/VfrCompile/Pccts/antlr/makefile | 22 ++++++++++----- > BaseTools/Source/C/VfrCompile/Pccts/dlg/makefile | 28 +++++++++++++---= ---- > 5 files changed, 56 insertions(+), 23 deletions(-) >=20 > -- > 2.14.1.3.gb7cf6e02401b