From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <liming.gao@intel.com>
Received-SPF: Pass (sender SPF authorized) identity=mailfrom;
 client-ip=192.55.52.43; helo=mga05.intel.com;
 envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org 
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id 7726D21CAD998
 for <edk2-devel@lists.01.org>; Mon,  6 Aug 2018 20:44:54 -0700 (PDT)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 06 Aug 2018 20:44:53 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.51,453,1526367600"; d="scan'208";a="74288618"
Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201])
 by fmsmga002.fm.intel.com with ESMTP; 06 Aug 2018 20:44:49 -0700
Received: from fmsmsx117.amr.corp.intel.com (10.18.116.17) by
 FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS)
 id 14.3.319.2; Mon, 6 Aug 2018 20:44:49 -0700
Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by
 fmsmsx117.amr.corp.intel.com (10.18.116.17) with Microsoft SMTP Server (TLS)
 id 14.3.319.2; Mon, 6 Aug 2018 20:44:49 -0700
Received: from shsmsx152.ccr.corp.intel.com ([169.254.6.150]) by
 SHSMSX104.ccr.corp.intel.com ([169.254.5.143]) with mapi id 14.03.0319.002;
 Tue, 7 Aug 2018 11:44:46 +0800
From: "Gao, Liming" <liming.gao@intel.com>
To: "Zhu, Yonghong" <yonghong.zhu@intel.com>, "edk2-devel@lists.01.org"
 <edk2-devel@lists.01.org>
CC: "Kinney, Michael D" <michael.d.kinney@intel.com>, "Shaw, Kevin W"
 <kevin.w.shaw@intel.com>
Thread-Topic: [Patch] DSC Spec: limit the VOID* PCD max size to UINT16
Thread-Index: AQHUKvEI7eybZGW+jUijL64IjGWEV6SzrAfg
Date: Tue, 7 Aug 2018 03:44:45 +0000
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E2CEF79@SHSMSX152.ccr.corp.intel.com>
References: <1533276741-13044-1-git-send-email-yonghong.zhu@intel.com>
In-Reply-To: <1533276741-13044-1-git-send-email-yonghong.zhu@intel.com>
Accept-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
MIME-Version: 1.0
Subject: Re: [Patch] DSC Spec: limit the VOID* PCD max size to UINT16
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Tue, 07 Aug 2018 03:44:54 -0000
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Reviewed-by: Liming Gao <liming.gao@intel.com>

>-----Original Message-----
>From: Zhu, Yonghong
>Sent: Friday, August 03, 2018 2:12 PM
>To: edk2-devel@lists.01.org
>Cc: Gao, Liming <liming.gao@intel.com>; Kinney, Michael D
><michael.d.kinney@intel.com>; Shaw, Kevin W <kevin.w.shaw@intel.com>
>Subject: [Patch] DSC Spec: limit the VOID* PCD max size to UINT16
>
>current the max size of VOID* PCD in the spec is a number that doesn't
>no limitation, now this patch update to limit the max size to UINT16,
>besides, also update some typo to make sure the format in chapter 2
>and chapter 3 are align.
>
>Cc: Liming Gao <liming.gao@intel.com>
>Cc: Michael Kinney <michael.d.kinney@intel.com>
>Cc: Kevin W Shaw <kevin.w.shaw@intel.com>
>Contributed-under: TianoCore Contribution Agreement 1.1
>Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
>---
> 2_dsc_overview/29_pcd_sections.md            | 6 +++---
> 3_edk_ii_dsc_file_format/310_pcd_sections.md | 8 ++++----
> 2 files changed, 7 insertions(+), 7 deletions(-)
>
>diff --git a/2_dsc_overview/29_pcd_sections.md
>b/2_dsc_overview/29_pcd_sections.md
>index 6547656..b33026c 100644
>--- a/2_dsc_overview/29_pcd_sections.md
>+++ b/2_dsc_overview/29_pcd_sections.md
>@@ -1,9 +1,9 @@
> <!--- @file
>   2.9 PCD Sections
>
>-  Copyright (c) 2006-2017, Intel Corporation. All rights reserved.<BR>
>+  Copyright (c) 2006-2018, Intel Corporation. All rights reserved.<BR>
>
>   Redistribution and use in source (original document form) and 'compiled=
'
>   forms (converted to PDF, epub, HTML and other formats) with or without
>   modification, are permitted provided that the following conditions are =
met:
>
>@@ -112,11 +112,11 @@ The following are typical examples of the
>`[PcdsFixedAtBuild]` section tag (the
> [PcdsFixedAtBuild.$(arch).$(SkuIdentifier)]
> ```
>
> Format of a point (VOID*) entry in this section is:
>
>-
>`PcdTokenSpaceGuidCName.PcdCName|Value[|DatumType|MaximumDatu
>mSize]]`
>+`PcdTokenSpaceGuidCName.PcdCName|Value[|DatumType|MaximumDatu
>mSize]`
>
> Format for Boolean and numeric entries in this section is:
>
> `PcdTokenSpaceGuidCName.PcdCName|Value`
>
>@@ -157,11 +157,11 @@ The following are typical examples of the
>`[PcdsPatchableInModule]` section tag
> [PcdsPatchableInModule.$(arch).$(SkuIdentifier)]
> ```
>
> Format of an entry in this section is:
>
>-
>`PcdTokenSpaceGuidCName.PcdCName|Value[|DatumType[|MaximumDatu
>mSize]]`
>+`PcdTokenSpaceGuidCName.PcdCName|Value[|DatumType|MaximumDatu
>mSize]`
>
> #### Example
>
> ```ini
> [PcdsPatchableInModule.common]
>diff --git a/3_edk_ii_dsc_file_format/310_pcd_sections.md
>b/3_edk_ii_dsc_file_format/310_pcd_sections.md
>index 607c479..1879923 100644
>--- a/3_edk_ii_dsc_file_format/310_pcd_sections.md
>+++ b/3_edk_ii_dsc_file_format/310_pcd_sections.md
>@@ -233,11 +233,11 @@ fields that are separated by the pipe character, "|"=
.
>                       {<NumValUint32>} {<Expression>}
>                     elif (pcddatumtype =3D=3D "UINT64"):
>                       {<NumValUint64>} {<Expression>}
>                     else:
>                       <StringValue> [<MaxSize>]
>-<MaxSize>       ::=3D <FS> "VOID*" <FS> {<Number>} {<Expression>}
>+<MaxSize>       ::=3D <FS> "VOID*" <FS> {<IntNum>} {<UINT16>}
> <StringValue>   ::=3D {<StringVal>} {<MACROVAL>} {<Expression>}
> ```
>
> #### Parameters
>
>@@ -341,11 +341,11 @@ of the DSC file.
>                       {<NumValUint32>} {<Expression>}
>                     elif (pcddatumtype =3D=3D "UINT64"):
>                       {<NumValUint64>} {<Expression>}
>                     else:
>                       <StringValue> [<MaxSize>]
>-<MaxSize>       ::=3D <FS> {<Number>} {<Expression>}
>+<MaxSize>       ::=3D <FS> "VOID*" <FS> {<IntNum>} {<UINT16>}
> <StringValue>   ::=3D {<StringVal>} {<MACROVAL>} {<Expression>}
> ```
>
> #### Parameters
>
>@@ -480,11 +480,11 @@ sections of the DSC file.
>                      elif (pcddatumtype =3D=3D "UINT64"):
>                        {<NumValUint64>} {<Expression>}
>                      else:
>                        <StringValue> [<MaxSize>]
> <MaxSize>        ::=3D <FS> "VOID*" [<FS> <SizeValue>]
>-<SizeValue>      ::=3D {<Number>} {<Expression>}
>+<SizeValue>      ::=3D {<IntNum>} {<UINT16>}
> <StringValue>    ::=3D {<StringVal>} {<MACROVAL>} {<Expression>}
> <VpdEntry>       ::=3D <PcdName> <FS> <VpdOffset> [<FS> <VpdData>] <EOL>
> <VpdOffset>      ::=3D {<Number>} {"*"}
> <VpdData>        ::=3D if (pcddatumtype =3D=3D "BOOLEAN"):
>                        {<BoolType>} {<Expression>}
>@@ -496,11 +496,11 @@ sections of the DSC file.
>                        {<NumValUint32>} {<Expression>}
>                      elif(pcddatumtype =3D=3D "UINT64"):
>                        {<NumValUint64>} {<Expression>}
>                      else:
>                        <VpdMaxSize>
>-<VpdMaxSize>     ::=3D {<LongNum>} {<UINT32>} [<FS> <StringValue>]
>+<VpdMaxSize>     ::=3D {<IntNum>} {<UINT16>} [<FS> <StringValue>]
> <HiiEntry>       ::=3D <PcdName> <FS> <HiiString> <Field2> <EOL>
> <HiiString>      ::=3D {<CArray>} {<UnicodeString>}
> <Field2>         ::=3D <FS> <VariableGuid> <FS> <VariableOffset> [<ValueF=
ield>]
> <VariableGuid>   ::=3D <CName>
> <ValueField>     ::=3D <FS> <DefaultValue> [<FS> <HiiAttrs>]
>--
>2.6.1.windows.1