From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.43; helo=mga05.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 280DD210DBE68 for ; Mon, 6 Aug 2018 20:45:08 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Aug 2018 20:45:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,453,1526367600"; d="scan'208";a="222518438" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga004.jf.intel.com with ESMTP; 06 Aug 2018 20:44:58 -0700 Received: from fmsmsx120.amr.corp.intel.com (10.18.124.208) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 6 Aug 2018 20:44:58 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx120.amr.corp.intel.com (10.18.124.208) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 6 Aug 2018 20:44:58 -0700 Received: from shsmsx152.ccr.corp.intel.com ([169.254.6.150]) by shsmsx102.ccr.corp.intel.com ([169.254.2.226]) with mapi id 14.03.0319.002; Tue, 7 Aug 2018 11:44:55 +0800 From: "Gao, Liming" To: "Zhu, Yonghong" , "edk2-devel@lists.01.org" CC: "Kinney, Michael D" , "Shaw, Kevin W" Thread-Topic: [Patch] Build Spec: Add rules for structure pcd display in the report Thread-Index: AQHUKUceazVJgCzpKUmnMpXBG9kMZqSzr3AQ Date: Tue, 7 Aug 2018 03:44:54 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E2CEF84@SHSMSX152.ccr.corp.intel.com> References: <1533093846-12772-1-git-send-email-yonghong.zhu@intel.com> In-Reply-To: <1533093846-12772-1-git-send-email-yonghong.zhu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] Build Spec: Add rules for structure pcd display in the report X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Aug 2018 03:45:08 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao >-----Original Message----- >From: Zhu, Yonghong >Sent: Wednesday, August 01, 2018 11:24 AM >To: edk2-devel@lists.01.org >Cc: Gao, Liming ; Kinney, Michael D >; Shaw, Kevin W >Subject: [Patch] Build Spec: Add rules for structure pcd display in the re= port > >Cc: Liming Gao >Cc: Michael Kinney >Cc: Kevin W Shaw >Contributed-under: TianoCore Contribution Agreement 1.1 >Signed-off-by: Yonghong Zhu >--- > 13_build_reports/136_global_pcd_section.md | 32 >+++++++++++++++++++++--------- > 1 file changed, 23 insertions(+), 9 deletions(-) > >diff --git a/13_build_reports/136_global_pcd_section.md >b/13_build_reports/136_global_pcd_section.md >index 64bda35..1a072b3 100644 >--- a/13_build_reports/136_global_pcd_section.md >+++ b/13_build_reports/136_global_pcd_section.md >@@ -142,44 +142,58 @@ These lines are formatted as: > ********** > **Note:** Global PCD section is present when **PCD** is specified in **- >Y** > option. > ********** > >-#### 13.6.2.4 Field value for Structure PCD >-If the Pcd is a Structure Pcd, every field value that user specified in D= SC/DEC >-file and build command will print out. The field value is from DSC/DEC fi= le or >-build command, not from the final structure byte array, and the field ord= er is >-same as it in DSC/DEC file. when the field value is from build command, t= ool >will >-additional print a *B Flag. >+#### 13.6.2.4 Rules for Structure PCD >+If the Pcd is a Structure Pcd, it display in the report file would have t= wo parts. >+One is the final Pcd value and its field value, the field value is from F= DF file, >+DSC file PCD Section or build option, not from the final structure byte a= rray, >+and the field order is sorted by the field name. When the field value fro= m >DSC file >+PCD Section, it will not have additional *P Flag, when the field value fr= om FDF >file, >+it will have additional *F Flag before the field name, when the field val= ue >from >+build option, it will have additional *B Flag before the field name. The = other >part >+is the DEC default value and its field value, this part is optional. The = field >value >+in this part is from DEC file, and the field order is sorted by the field= name. >+ >+********** >+**Note:** When the structure Pcd have some value from build option, no >matter whether >+the value is same with FDF or DSC file or DEC file, there will display a = *B Flag >before >+the PCD name. When the structure Pcd have some value from FDF file, no >matter whether >+the value is same with DSC file or DEC file, there will display a *F Flag= before >the >+PCD name. When the structure Pcd value have some value from DSC file PCD >section, no >+matter whether the value is same with DEC file, there will display a *P F= lag >before >+the PCD name. >+********** > > #### Example > > ``` > gEfiMdePkgTokenSpaceGuid > *B TestDynamicExHii : DEXHII (TEST) (SKU1) (STANDARD) = =3D { > >0xff,0x01,0x00,0x2e,0xf6,0x08,0x6f,0x19,0x5c,0x8e,0x49,0x91,0x57,0x00,0x00= , >0x00, > 0x00,0x64,0x00,0x00,0x00} > .A =3D 0x1 >- *B .C =3D 0x0 > .Array =3D {0x2e,0xf6,0x08,0x6f,0x19,0x5c,0x8e,0x49,0x= 91,0x57} >+ *B .C =3D 0x0 > .D =3D 0x64 > : DEXHII (TEST) (SKU1) (Manufacturin= g) =3D { > >0xff,0x02,0x00,0x2e,0xf6,0x08,0x6f,0x20,0x5c,0x8e,0x49,0x91,0x57,0x00,0x00= , >0x00, > 0x00,0x68,0x00,0x00,0x00} > .A =3D 0x2 >- *B .C =3D 0x0 > .Array =3D {0x2e,0xf6,0x08,0x6f,0x20,0x5c,0x8e,0x49,0x= 91,0x57} >+ *B .C =3D 0x0 > .D =3D 0x68 > DEC DEFAULT =3D {0xFF,0xFF} > .A =3D 0xF > .C =3D 0xF > *P TestFix : FIXED (TEST) =3D { > >0xff,0x02,0x00,0x2e,0xf6,0x08,0x6f,0x19,0x5c,0x8e,0x49,0x91,0x57,0x00,0x00= , >0x00, > 0x00,0x64,0x00,0x00,0x00} > .A =3D 0x2 >- .C =3D 0x0 > .Array =3D {0x2e,0xf6,0x08,0x6f,0x19,0x5c,0x8e,0x49,0x= 91,0x57} >+ .C =3D 0x0 > .D =3D 0x64 > DEC DEFAULT =3D {0xFF,0xFF} > .A =3D 0xF > .C =3D 0xF > ``` >-- >2.6.1.windows.1