public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gao, Liming" <liming.gao@intel.com>
To: "Zhu, Yonghong" <yonghong.zhu@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [Patch] BaseTools: Update Makefile for ECC tool
Date: Wed, 22 Aug 2018 16:21:42 +0000	[thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E2E773A@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <1534927272-7908-1-git-send-email-yonghong.zhu@intel.com>

Reviewed-by: Liming Gao <liming.gao@intel.com>

> -----Original Message-----
> From: Zhu, Yonghong
> Sent: Wednesday, August 22, 2018 1:41 AM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming <liming.gao@intel.com>
> Subject: [Patch] BaseTools: Update Makefile for ECC tool
> 
> Because Ecc.py was renamed to EccMain.py
> 
> Cc: Liming Gao <liming.gao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
> ---
>  BaseTools/Source/Python/Makefile | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/BaseTools/Source/Python/Makefile b/BaseTools/Source/Python/Makefile
> index d78b12d..36e8b20 100644
> --- a/BaseTools/Source/Python/Makefile
> +++ b/BaseTools/Source/Python/Makefile
> @@ -234,11 +234,11 @@ CMD_ECC=$(BASE_TOOLS_PATH)\Source\Python\Ecc\c.py \
>      $(BASE_TOOLS_PATH)\Source\Python\Ecc\CodeFragment.py \
>      $(BASE_TOOLS_PATH)\Source\Python\Ecc\CodeFragmentCollector.py \
>      $(BASE_TOOLS_PATH)\Source\Python\Ecc\Configuration.py \
>      $(BASE_TOOLS_PATH)\Source\Python\Ecc\CParser.py \
>      $(BASE_TOOLS_PATH)\Source\Python\Ecc\Database.py \
> -    $(BASE_TOOLS_PATH)\Source\Python\Ecc\Ecc.py \
> +    $(BASE_TOOLS_PATH)\Source\Python\Ecc\EccMain.py \
>      $(BASE_TOOLS_PATH)\Source\Python\Ecc\EccGlobalData.py \
>      $(BASE_TOOLS_PATH)\Source\Python\Ecc\EccToolError.py \
>      $(BASE_TOOLS_PATH)\Source\Python\Ecc\Exception.py \
>      $(BASE_TOOLS_PATH)\Source\Python\Ecc\FileProfile.py \
>      $(BASE_TOOLS_PATH)\Source\Python\Ecc\MetaDataParser.py \
> @@ -294,12 +294,12 @@ $(BIN_DIR)\TestSigningPrivateKey.pem: $(BASE_TOOLS_PATH)\Source\Python\Rsa2048Sh
>    @copy /Y /B $(BASE_TOOLS_PATH)\Source\Python\Rsa2048Sha256Sign\TestSigningPrivateKey.pem
> $(BIN_DIR)\TestSigningPrivateKey.pem
> 
>  $(BIN_DIR)\Rsa2048Sha256GenerateKeys.exe:
> $(BASE_TOOLS_PATH)\Source\Python\Rsa2048Sha256Sign\Rsa2048Sha256GenerateKeys.py
>    @$(FREEZE) --include-modules=$(MODULES) --install-dir=$(BIN_DIR) Rsa2048Sha256Sign\Rsa2048Sha256GenerateKeys.py
> 
> -$(BIN_DIR)\Ecc.exe: $(BASE_TOOLS_PATH)\Source\Python\Ecc\Ecc.py $(CMD_ECC) $(BIN_DIR)\config.ini $(BIN_DIR)\exception.xml
> -  @$(FREEZE) --include-modules=$(MODULES) --install-dir=$(BIN_DIR) Ecc\Ecc.py
> +$(BIN_DIR)\Ecc.exe: $(BASE_TOOLS_PATH)\Source\Python\Ecc\EccMain.py $(CMD_ECC) $(BIN_DIR)\config.ini
> $(BIN_DIR)\exception.xml
> +  @$(FREEZE) --include-modules=$(MODULES) --install-dir=$(BIN_DIR) Ecc\EccMain.py
> 
>  $(BIN_DIR)\config.ini: $(BASE_TOOLS_PATH)\Source\Python\Ecc\config.ini
>    @copy /Y /B $(BASE_TOOLS_PATH)\Source\Python\Ecc\config.ini $(BIN_DIR)\config.ini
> 
>  $(BIN_DIR)\exception.xml: $(BASE_TOOLS_PATH)\Source\Python\Ecc\exception.xml
> --
> 2.6.1.windows.1



      reply	other threads:[~2018-08-22 16:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-22  8:41 [Patch] BaseTools: Update Makefile for ECC tool Yonghong Zhu
2018-08-22 16:21 ` Gao, Liming [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E2E773A@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox