public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [Patch V2] BaseTools: Update Makefile for ECC tool
@ 2018-08-23  2:32 Yonghong Zhu
  2018-08-23  6:13 ` Gao, Liming
  0 siblings, 1 reply; 2+ messages in thread
From: Yonghong Zhu @ 2018-08-23  2:32 UTC (permalink / raw)
  To: edk2-devel; +Cc: Liming Gao

V2: Add --target-name to specify the file name to create

Because Ecc.py was renamed to EccMain.py

Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
---
 BaseTools/Source/Python/Makefile | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/BaseTools/Source/Python/Makefile b/BaseTools/Source/Python/Makefile
index d78b12d..ac99259 100644
--- a/BaseTools/Source/Python/Makefile
+++ b/BaseTools/Source/Python/Makefile
@@ -234,11 +234,11 @@ CMD_ECC=$(BASE_TOOLS_PATH)\Source\Python\Ecc\c.py \
     $(BASE_TOOLS_PATH)\Source\Python\Ecc\CodeFragment.py \
     $(BASE_TOOLS_PATH)\Source\Python\Ecc\CodeFragmentCollector.py \
     $(BASE_TOOLS_PATH)\Source\Python\Ecc\Configuration.py \
     $(BASE_TOOLS_PATH)\Source\Python\Ecc\CParser.py \
     $(BASE_TOOLS_PATH)\Source\Python\Ecc\Database.py \
-    $(BASE_TOOLS_PATH)\Source\Python\Ecc\Ecc.py \
+    $(BASE_TOOLS_PATH)\Source\Python\Ecc\EccMain.py \
     $(BASE_TOOLS_PATH)\Source\Python\Ecc\EccGlobalData.py \
     $(BASE_TOOLS_PATH)\Source\Python\Ecc\EccToolError.py \
     $(BASE_TOOLS_PATH)\Source\Python\Ecc\Exception.py \
     $(BASE_TOOLS_PATH)\Source\Python\Ecc\FileProfile.py \
     $(BASE_TOOLS_PATH)\Source\Python\Ecc\MetaDataParser.py \
@@ -294,12 +294,12 @@ $(BIN_DIR)\TestSigningPrivateKey.pem: $(BASE_TOOLS_PATH)\Source\Python\Rsa2048Sh
   @copy /Y /B $(BASE_TOOLS_PATH)\Source\Python\Rsa2048Sha256Sign\TestSigningPrivateKey.pem $(BIN_DIR)\TestSigningPrivateKey.pem
   
 $(BIN_DIR)\Rsa2048Sha256GenerateKeys.exe: $(BASE_TOOLS_PATH)\Source\Python\Rsa2048Sha256Sign\Rsa2048Sha256GenerateKeys.py
   @$(FREEZE) --include-modules=$(MODULES) --install-dir=$(BIN_DIR) Rsa2048Sha256Sign\Rsa2048Sha256GenerateKeys.py
 
-$(BIN_DIR)\Ecc.exe: $(BASE_TOOLS_PATH)\Source\Python\Ecc\Ecc.py $(CMD_ECC) $(BIN_DIR)\config.ini $(BIN_DIR)\exception.xml
-  @$(FREEZE) --include-modules=$(MODULES) --install-dir=$(BIN_DIR) Ecc\Ecc.py
+$(BIN_DIR)\Ecc.exe: $(BASE_TOOLS_PATH)\Source\Python\Ecc\EccMain.py $(CMD_ECC) $(BIN_DIR)\config.ini $(BIN_DIR)\exception.xml
+  @$(FREEZE) --include-modules=$(MODULES) --install-dir=$(BIN_DIR) Ecc\EccMain.py --target-name=Ecc.exe
 
 $(BIN_DIR)\config.ini: $(BASE_TOOLS_PATH)\Source\Python\Ecc\config.ini
   @copy /Y /B $(BASE_TOOLS_PATH)\Source\Python\Ecc\config.ini $(BIN_DIR)\config.ini
 
 $(BIN_DIR)\exception.xml: $(BASE_TOOLS_PATH)\Source\Python\Ecc\exception.xml
-- 
2.6.1.windows.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Patch V2] BaseTools: Update Makefile for ECC tool
  2018-08-23  2:32 [Patch V2] BaseTools: Update Makefile for ECC tool Yonghong Zhu
@ 2018-08-23  6:13 ` Gao, Liming
  0 siblings, 0 replies; 2+ messages in thread
From: Gao, Liming @ 2018-08-23  6:13 UTC (permalink / raw)
  To: Zhu, Yonghong, edk2-devel@lists.01.org

Reviewed-by: Liming Gao <liming.gao@intel.com>

> -----Original Message-----
> From: Zhu, Yonghong
> Sent: Wednesday, August 22, 2018 7:32 PM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming <liming.gao@intel.com>
> Subject: [Patch V2] BaseTools: Update Makefile for ECC tool
> 
> V2: Add --target-name to specify the file name to create
> 
> Because Ecc.py was renamed to EccMain.py
> 
> Cc: Liming Gao <liming.gao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
> ---
>  BaseTools/Source/Python/Makefile | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/BaseTools/Source/Python/Makefile b/BaseTools/Source/Python/Makefile
> index d78b12d..ac99259 100644
> --- a/BaseTools/Source/Python/Makefile
> +++ b/BaseTools/Source/Python/Makefile
> @@ -234,11 +234,11 @@ CMD_ECC=$(BASE_TOOLS_PATH)\Source\Python\Ecc\c.py \
>      $(BASE_TOOLS_PATH)\Source\Python\Ecc\CodeFragment.py \
>      $(BASE_TOOLS_PATH)\Source\Python\Ecc\CodeFragmentCollector.py \
>      $(BASE_TOOLS_PATH)\Source\Python\Ecc\Configuration.py \
>      $(BASE_TOOLS_PATH)\Source\Python\Ecc\CParser.py \
>      $(BASE_TOOLS_PATH)\Source\Python\Ecc\Database.py \
> -    $(BASE_TOOLS_PATH)\Source\Python\Ecc\Ecc.py \
> +    $(BASE_TOOLS_PATH)\Source\Python\Ecc\EccMain.py \
>      $(BASE_TOOLS_PATH)\Source\Python\Ecc\EccGlobalData.py \
>      $(BASE_TOOLS_PATH)\Source\Python\Ecc\EccToolError.py \
>      $(BASE_TOOLS_PATH)\Source\Python\Ecc\Exception.py \
>      $(BASE_TOOLS_PATH)\Source\Python\Ecc\FileProfile.py \
>      $(BASE_TOOLS_PATH)\Source\Python\Ecc\MetaDataParser.py \
> @@ -294,12 +294,12 @@ $(BIN_DIR)\TestSigningPrivateKey.pem: $(BASE_TOOLS_PATH)\Source\Python\Rsa2048Sh
>    @copy /Y /B $(BASE_TOOLS_PATH)\Source\Python\Rsa2048Sha256Sign\TestSigningPrivateKey.pem
> $(BIN_DIR)\TestSigningPrivateKey.pem
> 
>  $(BIN_DIR)\Rsa2048Sha256GenerateKeys.exe:
> $(BASE_TOOLS_PATH)\Source\Python\Rsa2048Sha256Sign\Rsa2048Sha256GenerateKeys.py
>    @$(FREEZE) --include-modules=$(MODULES) --install-dir=$(BIN_DIR) Rsa2048Sha256Sign\Rsa2048Sha256GenerateKeys.py
> 
> -$(BIN_DIR)\Ecc.exe: $(BASE_TOOLS_PATH)\Source\Python\Ecc\Ecc.py $(CMD_ECC) $(BIN_DIR)\config.ini $(BIN_DIR)\exception.xml
> -  @$(FREEZE) --include-modules=$(MODULES) --install-dir=$(BIN_DIR) Ecc\Ecc.py
> +$(BIN_DIR)\Ecc.exe: $(BASE_TOOLS_PATH)\Source\Python\Ecc\EccMain.py $(CMD_ECC) $(BIN_DIR)\config.ini
> $(BIN_DIR)\exception.xml
> +  @$(FREEZE) --include-modules=$(MODULES) --install-dir=$(BIN_DIR) Ecc\EccMain.py --target-name=Ecc.exe
> 
>  $(BIN_DIR)\config.ini: $(BASE_TOOLS_PATH)\Source\Python\Ecc\config.ini
>    @copy /Y /B $(BASE_TOOLS_PATH)\Source\Python\Ecc\config.ini $(BIN_DIR)\config.ini
> 
>  $(BIN_DIR)\exception.xml: $(BASE_TOOLS_PATH)\Source\Python\Ecc\exception.xml
> --
> 2.6.1.windows.1



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-08-23  6:14 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-23  2:32 [Patch V2] BaseTools: Update Makefile for ECC tool Yonghong Zhu
2018-08-23  6:13 ` Gao, Liming

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox