public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gao, Liming" <liming.gao@intel.com>
To: "Feng, Bob C" <bob.c.feng@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [Patch] BaseTools: Dynamic Pcd value override from command line.
Date: Wed, 29 Aug 2018 12:41:25 +0000	[thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E2EAB8C@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20180829084759.1032-1-bob.c.feng@intel.com>

Reviewed-by: Liming Gao <liming.gao@intel.com>

> -----Original Message-----
> From: Feng, Bob C
> Sent: Wednesday, August 29, 2018 4:48 PM
> To: edk2-devel@lists.01.org
> Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <liming.gao@intel.com>
> Subject: [Patch] BaseTools: Dynamic Pcd value override from command line.
> 
> Fixed the pcd value override issue when Dynamic Pcd is from
> command line but is not list in Dsc file.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Bob Feng <bob.c.feng@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> ---
>  BaseTools/Source/Python/Workspace/DscBuildData.py | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/BaseTools/Source/Python/Workspace/DscBuildData.py b/BaseTools/Source/Python/Workspace/DscBuildData.py
> index 748452623f..d553536961 100644
> --- a/BaseTools/Source/Python/Workspace/DscBuildData.py
> +++ b/BaseTools/Source/Python/Workspace/DscBuildData.py
> @@ -1268,13 +1268,18 @@ class DscBuildData(PlatformBuildClassObject):
>                  PcdInDec = self.DecPcds.get((Name, Guid))
>                  if PcdInDec:
>                      PcdInDec.PcdValueFromComm = NoFiledValues[(Guid, Name)][0]
>                      if PcdInDec.Type in [self._PCD_TYPE_STRING_[MODEL_PCD_FIXED_AT_BUILD],
>                                          self._PCD_TYPE_STRING_[MODEL_PCD_PATCHABLE_IN_MODULE],
> -                                        self._PCD_TYPE_STRING_[MODEL_PCD_FEATURE_FLAG]]:
> +                                        self._PCD_TYPE_STRING_[MODEL_PCD_FEATURE_FLAG],
> +                                        self._PCD_TYPE_STRING_[MODEL_PCD_DYNAMIC],
> +                                        self._PCD_TYPE_STRING_[MODEL_PCD_DYNAMIC_EX]]:
>                          self.Pcds[Name, Guid] = copy.deepcopy(PcdInDec)
>                          self.Pcds[Name, Guid].DefaultValue = NoFiledValues[( Guid, Name)][0]
> +                    if PcdInDec.Type in [self._PCD_TYPE_STRING_[MODEL_PCD_DYNAMIC],
> +                                        self._PCD_TYPE_STRING_[MODEL_PCD_DYNAMIC_EX]]:
> +                        self.Pcds[Name, Guid].SkuInfoList = {TAB_DEFAULT:SkuInfoClass(TAB_DEFAULT,
> self.SkuIds[TAB_DEFAULT][0], '', '', '', '', '', NoFiledValues[( Guid, Name)][0])}
>          return AllPcds
> 
>      def OverrideByFdfOverAll(self,AllPcds):
> 
>          if GlobalData.gFdfParser is None:
> --
> 2.16.2.windows.1



      reply	other threads:[~2018-08-29 12:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-29  8:47 [Patch] BaseTools: Dynamic Pcd value override from command line BobCF
2018-08-29 12:41 ` Gao, Liming [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E2EAB8C@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox