From: "Gao, Liming" <liming.gao@intel.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Laszlo Ersek <lersek@redhat.com>
Cc: "Carsey, Jaben" <jaben.carsey@intel.com>,
"Ni, Ruiyu" <ruiyu.ni@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH] ShellPkg Shell: Remove redundant functions
Date: Thu, 6 Sep 2018 15:22:24 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E2EE969@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <CAKv+Gu_24Z0qwxVsyiSTkOTKfW__32x_ENSp4xSUP-vg063WwQ@mail.gmail.com>
The build log shows the error message. I agree to remove this unused global variable InvalidChars in this patch.
/home/buildslave/workspace/leg-virt-tianocore-edk2-upstream/edk2/ShellPkg/Application/Shell/Shell.c:2754:21: error: unused variable 'InvalidChars' [-Werror,-Wunused-const-variable]
12:23:26 STATIC CONST UINT16 InvalidChars[] = {L'*', L'?', L'<', L'>', L'\\', L'/', L'\"', 0x0001, 0x0002};
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ard Biesheuvel
> Sent: Thursday, September 6, 2018 8:31 PM
> To: Laszlo Ersek <lersek@redhat.com>
> Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ruiyu <ruiyu.ni@intel.com>; edk2-devel@lists.01.org
> Subject: Re: [edk2] [PATCH] ShellPkg Shell: Remove redundant functions
>
> On 6 September 2018 at 14:24, Laszlo Ersek <lersek@redhat.com> wrote:
> > On 09/06/18 12:28, Ard Biesheuvel wrote:
> >> On 9 August 2018 at 17:41, <Jim.Dailey@dell.com> wrote:
> >>> The InvalidChars[] array is only used in function IsValidCommandName().
> >>> The array should be deleted also, I think.
> >>>
> >>
> >> Indeed, and for this reason this patch has now broken the build for
> >> clang. Please fix.
> >
> > I agree about InvalidChars being unused, post-22cf747fcf75. I just can't
> > reproduce the build error, with CLANG38 (3.8.1). The command
> >
> > build -a X64 -p ShellPkg/ShellPkg.dsc -b RELEASE -t CLANG38 \
> > -m ShellPkg/Application/Shell/Shell.inf
> >
> > seems to work for me, also with "-b DEBUG".
> >
> > What differs on your end?
> >
>
> Not sure what the exact difference is, but I am using CLANG35 profile:
>
> https://ci.linaro.org/job/leg-virt-tianocore-edk2-upstream/3176/consoleFull
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
next prev parent reply other threads:[~2018-09-06 15:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-09 5:41 [PATCH] ShellPkg Shell: Remove redundant functions shenglei
2018-08-09 15:34 ` Carsey, Jaben
2018-08-09 15:41 ` Jim.Dailey
2018-08-09 16:17 ` Laszlo Ersek
2018-09-06 10:28 ` Ard Biesheuvel
2018-09-06 12:24 ` Laszlo Ersek
2018-09-06 12:30 ` Ard Biesheuvel
2018-09-06 15:22 ` Gao, Liming [this message]
2018-09-06 16:18 ` Laszlo Ersek
2018-09-07 0:57 ` Gao, Liming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E2EE969@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox