From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.151; helo=mga17.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1111421122933 for ; Thu, 6 Sep 2018 08:22:27 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Sep 2018 08:22:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,338,1531810800"; d="scan'208";a="72129789" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga006.jf.intel.com with ESMTP; 06 Sep 2018 08:22:27 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 6 Sep 2018 08:22:27 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.143]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.16]) with mapi id 14.03.0319.002; Thu, 6 Sep 2018 23:22:23 +0800 From: "Gao, Liming" To: Ard Biesheuvel , Laszlo Ersek CC: "Carsey, Jaben" , "Ni, Ruiyu" , "edk2-devel@lists.01.org" Thread-Topic: [edk2] [PATCH] ShellPkg Shell: Remove redundant functions Thread-Index: AQHUL6POJgyayRDgZkmI+UZ3P5+v46S3CZ8AgCupr4CAACB9AIAAAamAgAC0GgA= Date: Thu, 6 Sep 2018 15:22:24 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E2EE969@SHSMSX104.ccr.corp.intel.com> References: <20180809054155.30244-1-shenglei.zhang@intel.com> <809ce67145704edeb41da02b7e5bdce5@ausx13mps335.AMER.DELL.COM> <17d57db5-c15a-b71b-3d82-39aaad39ece2@redhat.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTYxODNkZjktY2RkYS00ODEwLWI1NWMtNDZhMjJmZjRiMGE3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoidjdtVHA5bjZNWTRkaTRzOU14c0w0Zzg2ZVdYMFwvd21CT3d1SjVGUVJ2SXI0SmJZaVRXeUtsdjVYZEdZdlFkUXIifQ== dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] ShellPkg Shell: Remove redundant functions X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Sep 2018 15:22:28 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable The build log shows the error message. I agree to remove this unused global= variable InvalidChars in this patch.=20 /home/buildslave/workspace/leg-virt-tianocore-edk2-upstream/edk2/ShellPkg/A= pplication/Shell/Shell.c:2754:21: error: unused variable 'InvalidChars' [-W= error,-Wunused-const-variable] 12:23:26 STATIC CONST UINT16 InvalidChars[] =3D {L'*', L'?', L'<', L'>', L'= \\', L'/', L'\"', 0x0001, 0x0002}; > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ar= d Biesheuvel > Sent: Thursday, September 6, 2018 8:31 PM > To: Laszlo Ersek > Cc: Carsey, Jaben ; Ni, Ruiyu ; edk2-devel@lists.01.org > Subject: Re: [edk2] [PATCH] ShellPkg Shell: Remove redundant functions >=20 > On 6 September 2018 at 14:24, Laszlo Ersek wrote: > > On 09/06/18 12:28, Ard Biesheuvel wrote: > >> On 9 August 2018 at 17:41, wrote: > >>> The InvalidChars[] array is only used in function IsValidCommandName(= ). > >>> The array should be deleted also, I think. > >>> > >> > >> Indeed, and for this reason this patch has now broken the build for > >> clang. Please fix. > > > > I agree about InvalidChars being unused, post-22cf747fcf75. I just can'= t > > reproduce the build error, with CLANG38 (3.8.1). The command > > > > build -a X64 -p ShellPkg/ShellPkg.dsc -b RELEASE -t CLANG38 \ > > -m ShellPkg/Application/Shell/Shell.inf > > > > seems to work for me, also with "-b DEBUG". > > > > What differs on your end? > > >=20 > Not sure what the exact difference is, but I am using CLANG35 profile: >=20 > https://ci.linaro.org/job/leg-virt-tianocore-edk2-upstream/3176/consoleFu= ll > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel