public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gao, Liming" <liming.gao@intel.com>
To: "Zhao, ZhiqiangX" <zhiqiangx.zhao@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH] BaseTools:Fix issue caused by 84a52d4d030185a44f2d8736142c6f0b19c6e9b1
Date: Wed, 26 Sep 2018 14:25:39 +0000	[thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E31BF77@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20180926103026.20640-1-zhiqiangx.zhao@intel.com>

Reviewed-by: Liming Gao <liming.gao@intel.com>

> -----Original Message-----
> From: Zhao, ZhiqiangX
> Sent: Wednesday, September 26, 2018 6:30 PM
> To: edk2-devel@lists.01.org
> Cc: Zhao, ZhiqiangX <zhiqiangx.zhao@intel.com>; Gao, Liming <liming.gao@intel.com>; Zhu, Yonghong <yonghong.zhu@intel.com>;
> Feng, Bob C <bob.c.feng@intel.com>
> Subject: [PATCH] BaseTools:Fix issue caused by 84a52d4d030185a44f2d8736142c6f0b19c6e9b1
> 
> The commit 84a52d4d030185a44f2d8736142c6f0b19c6e9b1 will introduce
> the new issue "Invalid offset value for Dynamic Vpd PCD". This patch
> will fix the new issue, add 'DEFAULT' sku in to the AvailableSkuIdSet
> variable.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: ZhiqiangX Zhao <zhiqiangx.zhao@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Yonghong Zhu <yonghong.zhu@intel.com>
> Cc: Bob Feng <bob.c.feng@intel.com>
> ---
>  BaseTools/Source/Python/Workspace/DscBuildData.py | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/BaseTools/Source/Python/Workspace/DscBuildData.py b/BaseTools/Source/Python/Workspace/DscBuildData.py
> index ac0f0bee47..3ccfdbdb7b 100644
> --- a/BaseTools/Source/Python/Workspace/DscBuildData.py
> +++ b/BaseTools/Source/Python/Workspace/DscBuildData.py
> @@ -1388,6 +1388,7 @@ class DscBuildData(PlatformBuildClassObject):
>          Pcds = AllPcds
>          DefaultStoreMgr = DefaultStore(self.DefaultStores)
>          SkuIds = self.SkuIds
> +        self.SkuIdMgr.AvailableSkuIdSet.update({TAB_DEFAULT:0})
>          DefaultStores = {storename for pcdobj in AllPcds.values() for skuobj in pcdobj.SkuInfoList.values() for storename in
> skuobj.DefaultStoreDict}
> 
>          S_PcdSet = []
> --
> 2.14.1.windows.1



      reply	other threads:[~2018-09-26 14:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-26 10:30 [PATCH] BaseTools:Fix issue caused by 84a52d4d030185a44f2d8736142c6f0b19c6e9b1 Zhaozh1x
2018-09-26 14:25 ` Gao, Liming [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E31BF77@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox