From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.24; helo=mga09.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5022921161B05 for ; Sun, 7 Oct 2018 20:09:03 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Oct 2018 20:09:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,355,1534834800"; d="scan'208";a="269318669" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga005.fm.intel.com with ESMTP; 07 Oct 2018 20:08:10 -0700 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 7 Oct 2018 20:08:10 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx109.amr.corp.intel.com (10.18.116.9) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 7 Oct 2018 20:08:10 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.48]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.245]) with mapi id 14.03.0319.002; Mon, 8 Oct 2018 11:04:02 +0800 From: "Gao, Liming" To: Laszlo Ersek , "Tomas Pilar (tpilar)" , "edk2-devel@lists.01.org" Thread-Topic: [edk2] [PATCH] MdeModulePkg:disable wraning to pass gcc4.8 build Thread-Index: AQHUV5eBT1Tck7g+mUW2DT/krHtYQ6UJm4kAgACNI4CAAAO1gIAKiNwg Date: Mon, 8 Oct 2018 03:04:01 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E33302E@SHSMSX104.ccr.corp.intel.com> References: <1538186116-3792-1-git-send-email-dongao.guo@intel.com> <7b490137-3c8a-b5e3-9b48-c4ba1a3d588b@solarflare.com> <84933915-ca19-0c38-f772-953927a41144@redhat.com> In-Reply-To: <84933915-ca19-0c38-f772-953927a41144@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] MdeModulePkg:disable wraning to pass gcc4.8 build X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Oct 2018 03:09:03 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Laszlo: We meet with this failure in GCC4.8 and GCC4.9, but not in GCC5. We don= 't verify earlier version than GCC4.8.=20 GCC48 is the specific tool chain for GCC4.8. But, GCC49 is the general t= ool chain that can be used with GCC4.9 or the above GCC version for LTO dis= able. So, even if we specify this warning for GCC48 and GCC49, it may be ap= plied for GCC5 version. To be simplified, I suggest to disable this warning= in the general style. I suggest to add more comments here to describe this= warning for GCC4.8, GCC4.9 version. Not for GCC5.=20 =20 >>>> + # Oniguruma: tag_end in parse_callout_of_name >>>> + GCC:*_*_*_CC_FLAGS =3D -Wno-error=3Dmaybe-uninitialized Thanks Liming >-----Original Message----- >From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of >Laszlo Ersek >Sent: Tuesday, October 02, 2018 2:02 AM >To: Tomas Pilar (tpilar) ; edk2-devel@lists.01.org >Subject: Re: [edk2] [PATCH] MdeModulePkg:disable wraning to pass gcc4.8 >build > >Wait a sec: > >On 10/01/18 19:48, Laszlo Ersek wrote: > >> However, this (edk2) commit message seems to suggest that the warnings >> are only present with gcc-4.8 (and no later gcc releases). This in turn >> suggests that the warnings are spurious (presumably, later gcc releases >> recognize that none of the affected variables are actually read without >> a prior initialization or assignment.) >> >> Hence, upstream Oniguruma might argue that we should fix our compiler -- >> they might consider gcc-4.8 too old to care -- rather than litter their >> code with superfluous assignments, just to pacify gcc-4.8. > >[...] > >> So, I think I agree with this patch, but the commit message should be a >> *lot* more detailed. (Basically, include the analysis from above.) > >In fact, another improvement is possible: if the issue only affects >gcc-4.8, then: > >>> On 29/09/18 02:55, Dongao Guo wrote: >>>> Change-Id: I782962e4994a8edf14beb7ede8b1aabe233dc3a8 >>>> Contributed-under: TianoCore Contribution Agreement 1.1 >>>> --- >>>> >MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf | >3 +++ >>>> 1 file changed, 3 insertions(+) >>>> >>>> diff --git >a/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.in >f >b/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.in >f >>>> index 16e91bd..07bc02e 100644 >>>> --- >a/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.in >f >>>> +++ >b/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.in >f >>>> @@ -109,3 +109,6 @@ >>>> >>>> # Oniguruma: error: variable 'fp' set but not used >>>> GCC:*_*_*_CC_FLAGS =3D -Wno-error=3Dunused-but-set-variable >>>> + >>>> + # Oniguruma: tag_end in parse_callout_of_name >>>> + GCC:*_*_*_CC_FLAGS =3D -Wno-error=3Dmaybe-uninitialized > >this toolchain glob pattern is too general. It should be: > > GCC:*_GCC48_*_CC_FLAGS > >(or maybe spell it out for all GCC versions up to and including 4.8, >from the earliest we support, 4.4.) > >Thanks >Laszlo >_______________________________________________ >edk2-devel mailing list >edk2-devel@lists.01.org >https://lists.01.org/mailman/listinfo/edk2-devel