From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.100; helo=mga07.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2A4BB21130058 for ; Tue, 9 Oct 2018 00:11:37 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Oct 2018 00:11:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,359,1534834800"; d="scan'208";a="86862049" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by FMSMGA003.fm.intel.com with ESMTP; 09 Oct 2018 00:11:13 -0700 Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 9 Oct 2018 00:11:13 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX154.amr.corp.intel.com (10.18.116.70) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 9 Oct 2018 00:11:12 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.48]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.245]) with mapi id 14.03.0319.002; Tue, 9 Oct 2018 15:11:01 +0800 From: "Gao, Liming" To: Ard Biesheuvel CC: "edk2-devel@lists.01.org" Thread-Topic: [edk2] [Patch] BaseTools LzmaCompress: Fix GCC warning misleading-indentation Thread-Index: AQHUX56qaZRNCwLsXUSQgb/2XXg3GaUV+CiAgACGiyA= Date: Tue, 9 Oct 2018 07:11:00 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E335C1D@SHSMSX104.ccr.corp.intel.com> References: <20181009070614.20052-1-liming.gao@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZTc4MDZmMmQtMDhhZi00MTE2LTgzYWEtMzYzYjE2ZjE3NTI1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiNzlsZG1ZMWpHYXJmRlcrN1MzNzg2TmpUS1ZzTGpsZU92RmN0eThmK2VFdllsQnJqN05oeXV0WVwvNkdQcjF6bkcifQ== dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] BaseTools LzmaCompress: Fix GCC warning misleading-indentation X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Oct 2018 07:11:37 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable This issue in LzmaEnc.c is for encode. The copy SDK in MdeModulePkg and Int= elFrameworkModulepkg is for decode. So, other copy SDK has no this issue.=20 Thanks Liming > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ar= d Biesheuvel > Sent: Tuesday, October 9, 2018 3:08 PM > To: Gao, Liming > Cc: edk2-devel@lists.01.org > Subject: Re: [edk2] [Patch] BaseTools LzmaCompress: Fix GCC warning misle= ading-indentation >=20 > On 9 October 2018 at 09:06, Liming Gao wrote: > > GCC 6 or above reports the warning misleading-indentation. > > This patch fixes it. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Liming Gao > > Cc: Ard Biesheuvel > > --- > > BaseTools/Source/C/LzmaCompress/Sdk/C/LzmaEnc.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/BaseTools/Source/C/LzmaCompress/Sdk/C/LzmaEnc.c b/BaseTool= s/Source/C/LzmaCompress/Sdk/C/LzmaEnc.c > > index bebe664..e281716 100644 > > --- a/BaseTools/Source/C/LzmaCompress/Sdk/C/LzmaEnc.c > > +++ b/BaseTools/Source/C/LzmaCompress/Sdk/C/LzmaEnc.c > > @@ -1464,7 +1464,9 @@ static unsigned GetOptimum(CLzmaEnc *p, UInt32 po= sition) > > unsigned limit =3D p->numFastBytes + 1; > > if (limit > numAvailFull) > > limit =3D numAvailFull; > > - for (len =3D 3; len < limit && data[len] =3D=3D data2[len]; le= n++); > > + for (len =3D 3; len < limit && data[len] =3D=3D data2[len]; le= n++) > > + { > > + } > > > > { > > unsigned state2 =3D kLiteralNextStates[state]; >=20 > Thanks Liming. >=20 > Don't we need this change in all copies of the LZMA SDK? > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel