From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.20; helo=mga02.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id ED5C32112294F for ; Tue, 9 Oct 2018 03:25:39 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Oct 2018 03:25:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,360,1534834800"; d="scan'208";a="97770352" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga001.jf.intel.com with ESMTP; 09 Oct 2018 03:24:44 -0700 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 9 Oct 2018 03:24:43 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 9 Oct 2018 03:24:43 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.48]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.245]) with mapi id 14.03.0319.002; Tue, 9 Oct 2018 18:24:41 +0800 From: "Gao, Liming" To: Laszlo Ersek , "Zeng, Star" , "Ard Biesheuvel" CC: "edk2-devel@lists.01.org" Thread-Topic: [edk2] [Patch] BaseTools LzmaCompress: Fix GCC warning misleading-indentation Thread-Index: AQHUX56qaZRNCwLsXUSQgb/2XXg3GaUV+CiAgACGiyD//3rdgIAAE/kAgAAesYCAAIkQYA== Date: Tue, 9 Oct 2018 10:24:41 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E335F08@SHSMSX104.ccr.corp.intel.com> References: <20181009070614.20052-1-liming.gao@intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E335C1D@SHSMSX104.ccr.corp.intel.com> <0C09AFA07DD0434D9E2A0C6AEB0483103BC1372A@shsmsx102.ccr.corp.intel.com> <9bf7dad6-2b38-dd19-40fe-caf7e49fe362@redhat.com> In-Reply-To: <9bf7dad6-2b38-dd19-40fe-caf7e49fe362@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiY2VjMjk3MTQtZDI4Yi00OWE4LWI2NWQtMmFmNTRkNGRkODUwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoia1RBdGlIK1VqZnU5YlJtMFcrMjJjZkZXMUNyRlFkMWlMeWRxZk9jVmFJQXJhdmJ5bG1oanNQUXJGT3JOc05yRSJ9 dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] BaseTools LzmaCompress: Fix GCC warning misleading-indentation X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Oct 2018 10:25:40 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks! > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of La= szlo Ersek > Sent: Tuesday, October 9, 2018 6:14 PM > To: Zeng, Star ; Ard Biesheuvel ; Gao, Liming > Cc: edk2-devel@lists.01.org > Subject: Re: [edk2] [Patch] BaseTools LzmaCompress: Fix GCC warning misle= ading-indentation >=20 > On 10/09/18 10:24, Zeng, Star wrote: > > Reviewed-by: Star Zeng > > > > -----Original Message----- > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of = Ard Biesheuvel > > Sent: Tuesday, October 9, 2018 3:13 PM > > To: Gao, Liming > > Cc: edk2-devel@lists.01.org > > Subject: Re: [edk2] [Patch] BaseTools LzmaCompress: Fix GCC warning mis= leading-indentation > > > > On 9 October 2018 at 09:11, Gao, Liming wrote: > >> This issue in LzmaEnc.c is for encode. The copy SDK in MdeModulePkg an= d IntelFrameworkModulepkg is for decode. So, other copy > SDK has no this issue. > >> > > > > I understand. > > > > Thanks for the fix > > > > Acked-by: Ard Biesheuvel >=20 > In the commit message, I referenced > , which got > reported meanwhile. >=20 > Pushed as commit 50431b9cc70c. >=20 > Thanks > Laszlo >=20 > >>> -----Original Message----- > >>> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf O= f Ard Biesheuvel > >>> Sent: Tuesday, October 9, 2018 3:08 PM > >>> To: Gao, Liming > >>> Cc: edk2-devel@lists.01.org > >>> Subject: Re: [edk2] [Patch] BaseTools LzmaCompress: Fix GCC warning m= isleading-indentation > >>> > >>> On 9 October 2018 at 09:06, Liming Gao wrote: > >>>> GCC 6 or above reports the warning misleading-indentation. > >>>> This patch fixes it. > >>>> > >>>> Contributed-under: TianoCore Contribution Agreement 1.1 > >>>> Signed-off-by: Liming Gao > >>>> Cc: Ard Biesheuvel > >>>> --- > >>>> BaseTools/Source/C/LzmaCompress/Sdk/C/LzmaEnc.c | 4 +++- > >>>> 1 file changed, 3 insertions(+), 1 deletion(-) > >>>> > >>>> diff --git a/BaseTools/Source/C/LzmaCompress/Sdk/C/LzmaEnc.c b/BaseT= ools/Source/C/LzmaCompress/Sdk/C/LzmaEnc.c > >>>> index bebe664..e281716 100644 > >>>> --- a/BaseTools/Source/C/LzmaCompress/Sdk/C/LzmaEnc.c > >>>> +++ b/BaseTools/Source/C/LzmaCompress/Sdk/C/LzmaEnc.c > >>>> @@ -1464,7 +1464,9 @@ static unsigned GetOptimum(CLzmaEnc *p, UInt32= position) > >>>> unsigned limit =3D p->numFastBytes + 1; > >>>> if (limit > numAvailFull) > >>>> limit =3D numAvailFull; > >>>> - for (len =3D 3; len < limit && data[len] =3D=3D data2[len];= len++); > >>>> + for (len =3D 3; len < limit && data[len] =3D=3D data2[len];= len++) > >>>> + { > >>>> + } > >>>> > >>>> { > >>>> unsigned state2 =3D kLiteralNextStates[state]; > >>> > >>> Thanks Liming. > >>> > >>> Don't we need this change in all copies of the LZMA SDK? > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel