public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gao, Liming" <liming.gao@intel.com>
To: "Zhu, Yonghong" <yonghong.zhu@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH] BaseTools: increment build generate inf file lost .depex file
Date: Fri, 12 Oct 2018 13:31:43 +0000	[thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E3393E2@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <1539312792-11344-1-git-send-email-yonghong.zhu@intel.com>

Reviewed-by: Liming Gao <liming.gao@intel.com>

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Yonghong Zhu
> Sent: Friday, October 12, 2018 10:53 AM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming <liming.gao@intel.com>
> Subject: [edk2] [PATCH] BaseTools: increment build generate inf file lost .depex file
> 
> From: Yunhua Feng <yunhuax.feng@intel.com>
> 
> increment build generate inf file in output directory lost .depex file info.
> 
> Fixes: https://bugzilla.tianocore.org/show_bug.cgi?id=1244
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Yonghong Zhu <yonghong.zhu@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Yunhua Feng <yunhuax.feng@intel.com>
> ---
>  BaseTools/Source/Python/AutoGen/AutoGen.py | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/BaseTools/Source/Python/AutoGen/AutoGen.py b/BaseTools/Source/Python/AutoGen/AutoGen.py
> index 5778943512..2201ec8790 100644
> --- a/BaseTools/Source/Python/AutoGen/AutoGen.py
> +++ b/BaseTools/Source/Python/AutoGen/AutoGen.py
> @@ -3634,10 +3634,14 @@ class ModuleAutoGen(AutoGen):
>                  AsBuiltInfDict['binary_item'].append('ACPI|' + File)
>              elif Item.Target.Ext.lower() == '.efi':
>                  AsBuiltInfDict['binary_item'].append('PE32|' + self.Name + '.efi')
>              else:
>                  AsBuiltInfDict['binary_item'].append('BIN|' + File)
> +        if not self.DepexGenerated:
> +            DepexFile = os.path.join(self.OutputDir, self.Name + '.depex')
> +            if os.path.exists(DepexFile):
> +                self.DepexGenerated = True
>          if self.DepexGenerated:
>              self.OutputFile.add(self.Name + '.depex')
>              if self.ModuleType in [SUP_MODULE_PEIM]:
>                  AsBuiltInfDict['binary_item'].append('PEI_DEPEX|' + self.Name + '.depex')
>              elif self.ModuleType in [SUP_MODULE_DXE_DRIVER, SUP_MODULE_DXE_RUNTIME_DRIVER,
> SUP_MODULE_DXE_SAL_DRIVER, SUP_MODULE_UEFI_DRIVER]:
> --
> 2.12.2.windows.2
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel


      reply	other threads:[~2018-10-12 13:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-12  2:53 [PATCH] BaseTools: increment build generate inf file lost .depex file Yonghong Zhu
2018-10-12 13:31 ` Gao, Liming [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E3393E2@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox