From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.24; helo=mga09.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 98F3E2116DA08 for ; Fri, 12 Oct 2018 06:32:58 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Oct 2018 06:32:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,372,1534834800"; d="scan'208";a="94659048" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga002.fm.intel.com with ESMTP; 12 Oct 2018 06:32:51 -0700 Received: from fmsmsx158.amr.corp.intel.com (10.18.116.75) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 12 Oct 2018 06:32:51 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx158.amr.corp.intel.com (10.18.116.75) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 12 Oct 2018 06:32:50 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.48]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.245]) with mapi id 14.03.0319.002; Fri, 12 Oct 2018 21:32:48 +0800 From: "Gao, Liming" To: "Zhu, Yonghong" , "edk2-devel@lists.01.org" CC: "Kinney, Michael D" , "Shaw, Kevin W" Thread-Topic: [edk2] [Patch] Build Spec: Add description for Structure Pcd display in the module Thread-Index: AQHUYTdFjG8IWWdiGUqQ6P3FnbOw9qUbnatg Date: Fri, 12 Oct 2018 13:32:46 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E339403@SHSMSX104.ccr.corp.intel.com> References: <1539244258-10740-1-git-send-email-yonghong.zhu@intel.com> In-Reply-To: <1539244258-10740-1-git-send-email-yonghong.zhu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMmEyNzU3MWQtYjZjMC00YTE5LWJkNjgtOGZlYzY3YzVkOWQ0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiZXVuMkI2blBWemdcL09iSm5QT0xjXC9OM1lkXC9UZXgzWE5tN2h5UWVKSGorV1d5UkNOQlBDSjBGUjNmT3NGWmlTSiJ9 dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] Build Spec: Add description for Structure Pcd display in the module X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Oct 2018 13:32:58 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Zh= u, Yonghong > Sent: Thursday, October 11, 2018 3:51 PM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Shaw, Kevin W ; Gao, Liming > Subject: [edk2] [Patch] Build Spec: Add description for Structure Pcd dis= play in the module >=20 > The detail rules are totally same with Global Pcd section. >=20 > Cc: Liming Gao > Cc: Michael Kinney > Cc: Kevin W Shaw > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Yonghong Zhu > --- > 13_build_reports/136_global_pcd_section.md | 12 ++++++------ > 13_build_reports/138_module_section.md | 7 ++----- > 2 files changed, 8 insertions(+), 11 deletions(-) >=20 > diff --git a/13_build_reports/136_global_pcd_section.md b/13_build_report= s/136_global_pcd_section.md > index 0e3afa7..9a3b98e 100644 > --- a/13_build_reports/136_global_pcd_section.md > +++ b/13_build_reports/136_global_pcd_section.md > @@ -160,23 +160,23 @@ option. > #### 13.6.2.4 Rules for Structure PCD > If the Pcd is a Structure Pcd, it display in the report file would have = two parts. > One is the final Pcd value and its field value, the field value is from = FDF file, > DSC file PCD Section or build option, not from the final structure byte = array, > and the field order is sorted by the field name. When the field value fr= om DSC file > -PCD Section, it will not have additional *P Flag, when the field value f= rom FDF file, > -it will have additional *F Flag before the field name, when the field va= lue from > -build option, it will have additional *B Flag before the field name. The= other part > +PCD Section, it will not have additional `*P` Flag, when the field value= from FDF file, > +it will have additional `*F` Flag before the field name, when the field = value from > +build option, it will have additional `*B` Flag before the field name. T= he other part > is the DEC default value and its field value, this part is optional. The= field value > in this part is from DEC file, and the field order is sorted by the fiel= d name. >=20 > ********** > **Note:** When the structure Pcd have some value from build option, no m= atter whether > -the value is same with FDF or DSC file or DEC file, there will display a= *B Flag before > +the value is same with FDF or DSC file or DEC file, there will display a= `*B` Flag before > the PCD name. When the structure Pcd have some value from FDF file, no m= atter whether > -the value is same with DSC file or DEC file, there will display a *F Fla= g before the > +the value is same with DSC file or DEC file, there will display a `*F` F= lag before the > PCD name. When the structure Pcd value have some value from DSC file PCD= section, no > -matter whether the value is same with DEC file, there will display a *P = Flag before > +matter whether the value is same with DEC file, there will display a `*P= ` Flag before > the PCD name. > ********** >=20 > #### Example >=20 > diff --git a/13_build_reports/138_module_section.md b/13_build_reports/13= 8_module_section.md > index 843ad34..d457c24 100644 > --- a/13_build_reports/138_module_section.md > +++ b/13_build_reports/138_module_section.md > @@ -260,15 +260,12 @@ Each PCD may contain up to following lines: > *P PcdPlatformBootTimeOut : DYNHII (UINT16) =3D 0xA (10) > gEfiGlobalVariableGuid: L"Timeout": 0x0 > DEC DEFAULT =3D 0xffff (65535) > ``` >=20 > -4. Additional lines may exist if the PCD is Structure PCD. Every field v= alue > -that user specified in DSC/DEC file and build command will print out. Th= e field > -value is from DSC/DEC file or build command, not from the final structur= e byte > -array, and the field order is same as it in DSC/DEC file. when the field= value is > -from build command, tool will additional print a *B Flag. > +4. Additional lines may exist if the PCD is Structure PCD. Please refer = to > +13.6.2.4 Rules for Structure PCD for details. >=20 > ********** > **Note:** This sub-section is present when **PCD** is specified in **-Y*= * > option. > ********** > -- > 2.6.1.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel