From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.136; helo=mga12.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9BB022115C325 for ; Sat, 13 Oct 2018 01:44:44 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Oct 2018 01:44:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,376,1534834800"; d="scan'208";a="265365586" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga005.jf.intel.com with ESMTP; 13 Oct 2018 01:44:43 -0700 Received: from fmsmsx115.amr.corp.intel.com (10.18.116.19) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sat, 13 Oct 2018 01:44:43 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx115.amr.corp.intel.com (10.18.116.19) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sat, 13 Oct 2018 01:44:42 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.48]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.245]) with mapi id 14.03.0319.002; Sat, 13 Oct 2018 16:44:40 +0800 From: "Gao, Liming" To: Ard Biesheuvel , edk2-devel-01 , Laszlo Ersek , Leif Lindholm , "Kinney, Michael D" , "Zhu, Yonghong" , "stephano.cetola@linux.intel.com" Thread-Topic: [edk2] BaseTools/ build broken due to unreviewed patch - PLEASE FIX Thread-Index: AQHUYs1GqkKzZr7J30KIQycJKcKZ0KUc2kNQ Date: Sat, 13 Oct 2018 08:44:39 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E339880@SHSMSX104.ccr.corp.intel.com> References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZmRlMzVhMjktYTUwNS00N2I3LTljMmEtNjFhZmU0MTBmNTljIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiSmVwRDhxSWpyR0dSMFdUSlM0anlvS0swR0o3MlpJXC9TYXN5XC9TQ0NOdjNqaUNcL3VwdjNRNndsbk9STGp4c1hrSCJ9 dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: BaseTools/ build broken due to unreviewed patch - PLEASE FIX X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Oct 2018 08:44:44 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Ard: I pull the latest edk2 code. I can find RunTests.py in BaseTools/Tests. T= he below error message shows RunTests.py is not found. But, this file is in= BaseTools/Tests. I also run Make command in BaseTools directory. It can wo= rk in my Ubuntu machine. I install Python37. Do you install Python36 or Pyt= hon37 in your machine?=20 =20 Yonghong has sent the mail to notify BaseTools Python3 migration is done.= Python3.6 or the above is required.=20 =20 Thanks Liming > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ar= d Biesheuvel > Sent: Saturday, October 13, 2018 4:18 PM > To: edk2-devel-01 ; Gao, Liming ; Laszlo Ersek ; Leif Lindholm > ; Kinney, Michael D ; Zhu, Yonghong ; > stephano.cetola@linux.intel.com > Subject: [edk2] BaseTools/ build broken due to unreviewed patch - PLEASE = FIX >=20 > Commit ea787b6b55499e8f931201f8f49daaaeb2e4409f >=20 > "BaseTools: update Test scripts support python3" >=20 > [which has never been sent out for review to the mailing list, as far > as I can tell] is breaking the BaseTools build >=20 > make -C Tests > make[1]: Entering directory '/home/ard/build/edk2/BaseTools/Tests' > /bin/sh: 1: RunTests.py: not found > GNUmakefile:17: recipe for target 'test' failed > make[1]: *** [test] Error 127 > make[1]: Leaving directory '/home/ard/build/edk2/BaseTools/Tests' > GNUmakefile:25: recipe for target 'Tests' failed > make: *** [Tests] Error 2 > make: Leaving directory '/home/ard/build/edk2/BaseTools' >=20 > I tried reverting that patch alone, but that gives me >=20 > make -C Tests > make[1]: Entering directory '/home/ard/build/edk2/BaseTools/Tests' > Traceback (most recent call last): > File "RunTests.py", line 36, in > allTests =3D GetAllTestsSuite() > File "RunTests.py", line 33, in GetAllTestsSuite > return unittest.TestSuite([GetCTestSuite(), GetPythonTestSuite()]) > File "RunTests.py", line 30, in GetPythonTestSuite > return PythonToolsTests.TheTestSuite() > File "/home/ard/build/edk2/BaseTools/Tests/PythonToolsTests.py", > line 27, in TheTestSuite > import CheckUnicodeSourceFiles > File "/home/ard/build/edk2/BaseTools/Tests/CheckUnicodeSourceFiles.py", > line 25, in > from Common.Misc import PathClass > File "/home/ard/build/edk2/BaseTools/Source/Python/Common/Misc.py", > line 27, in > from collections import UserDict as IterableUserDict > ImportError: cannot import name UserDict > GNUmakefile:17: recipe for target 'test' failed > make[1]: *** [test] Error 1 > make[1]: Leaving directory '/home/ard/build/edk2/BaseTools/Tests' > GNUmakefile:25: recipe for target 'Tests' failed > make: *** [Tests] Error 2 > make: Leaving directory '/home/ard/build/edk2/BaseTools' >=20 > Breaking the build for everyone with an unreviewed patch 2 days before > the plugfest is NOT OK. >=20 > Please fix or revert ASAP >=20 > (I suppose that the failing test is a false negative in this case, but > that is not really the point - my CI jobs are broken due to this and > so are many others, I imagine) > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel