From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.151; helo=mga17.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 068D72116325D for ; Sat, 13 Oct 2018 10:04:03 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Oct 2018 10:04:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,377,1534834800"; d="scan'208";a="271074781" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga005.fm.intel.com with ESMTP; 13 Oct 2018 10:04:03 -0700 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sat, 13 Oct 2018 10:04:02 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sat, 13 Oct 2018 10:04:02 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.48]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.245]) with mapi id 14.03.0319.002; Sun, 14 Oct 2018 01:04:00 +0800 From: "Gao, Liming" To: Ard Biesheuvel , "Zhu, Yonghong" , Andrew Fish CC: "edk2-devel@lists.01.org" Thread-Topic: [edk2] [Patch] BaseTools: Remove the logic that check Python3 version larger than 3.6 Thread-Index: AQHUYxNWeE4BysoHhEyU8nXo3dPpQqUc3eOAgACIvAA= Date: Sat, 13 Oct 2018 17:03:59 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E339A58@SHSMSX104.ccr.corp.intel.com> References: <1539448768-12816-1-git-send-email-yonghong.zhu@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTc4ZTRhMmQtY2E3NS00OTdmLTk0ZWQtZmM4MjZkYTdkMDVlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoia2RXZUpvdlMzdG1DeVdIbmNDNXhsOVpWNUVpS2p0RkZ4VVhwUVlpTndNdjl3QlNTNjlpYkZQaVZRdzIrYm9lRiJ9 dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] BaseTools: Remove the logic that check Python3 version larger than 3.6 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Oct 2018 17:04:04 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Ard: Do you verify BaseTools with Python35 or Python36? Thanks Liming > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ar= d Biesheuvel > Sent: Sunday, October 14, 2018 12:52 AM > To: Zhu, Yonghong ; Andrew Fish > Cc: edk2-devel@lists.01.org > Subject: Re: [edk2] [Patch] BaseTools: Remove the logic that check Python= 3 version larger than 3.6 >=20 > On 13 October 2018 at 18:39, Yonghong Zhu wrote: > > Remove the logic that the Python3 version must larger than 3.6. > > We verified Python3 migration patches on version 3.6 and 3.7. > > for other version we not verified it. > > > > Cc: Ard Biesheuvel > > Cc: Leif Lindholm > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Yonghong Zhu >=20 > I will note that this does not solve Andrew's problem, but nonetheless: >=20 > Reviewed-by: Ard Biesheuvel > Tested-by: Ard Biesheuvel >=20 > > --- > > BaseTools/toolsetup.bat | 7 ------- > > edksetup.sh | 4 ++-- > > 2 files changed, 2 insertions(+), 9 deletions(-) > > > > diff --git a/BaseTools/toolsetup.bat b/BaseTools/toolsetup.bat > > index 0d4028d..d585431 100755 > > --- a/BaseTools/toolsetup.bat > > +++ b/BaseTools/toolsetup.bat > > @@ -314,17 +314,10 @@ set PYTHON3=3Dpy -3 > > echo. > > echo !!! ERROR !!! %PYTHON3% not install. > > echo. > > goto end > > ) > > - FOR /F "TOKENS=3D1,2" %%i IN ('%PYTHON3% --version') DO set VERSION= =3D%%j > > - if /I "%VERSION%" LSS "3.6" ( > > - echo. > > - echo !!! ERROR !!! python version should greater than or equal t= o version 3.6. > > - echo. > > - goto end > > - ) > > > > :check_freezer_path > > @REM We have Python, now test for FreezePython application > > if not defined PYTHON_FREEZER_PATH ( > > echo. > > diff --git a/edksetup.sh b/edksetup.sh > > index d4e577e..84b3e63 100755 > > --- a/edksetup.sh > > +++ b/edksetup.sh > > @@ -129,13 +129,13 @@ function SetupPython3() > > if [ "$ret" -eq 1 ]; then > > origin_version=3D$python_version > > export PYTHON3=3D$python > > fi > > done > > - if [ -z "$origin_version" ] || [ `echo "$origin_version < 3.6" |bc` = -eq 1 ]; then > > + if [ -z "$origin_version" ]; then > > echo > > - echo ERROR!!!, python version should greater than or equal to vers= ion 3.6. > > + echo ERROR!!!, Please install a Python 3 Tool. > > echo > > return 1 > > fi > > > > > > -- > > 2.6.1.windows.1 > > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel