From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.65; helo=mga03.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A60EC21163714 for ; Sun, 14 Oct 2018 07:51:10 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Oct 2018 07:51:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,381,1534834800"; d="scan'208";a="241237057" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga004.jf.intel.com with ESMTP; 14 Oct 2018 07:51:09 -0700 Received: from fmsmsx158.amr.corp.intel.com (10.18.116.75) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 14 Oct 2018 07:51:09 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx158.amr.corp.intel.com (10.18.116.75) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 14 Oct 2018 07:51:09 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.48]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.245]) with mapi id 14.03.0319.002; Sun, 14 Oct 2018 22:51:07 +0800 From: "Gao, Liming" To: Leif Lindholm , "Zhu, Yonghong" CC: Ard Biesheuvel , "edk2-devel@lists.01.org" Thread-Topic: [Patch] BaseTools/Tests: Update GNUmakefile to use python3 variable Thread-Index: AQHUYxVHnOlZX7EWlUeOWadtfLq9MKUdHaaAgAGwwVA= Date: Sun, 14 Oct 2018 14:51:06 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E339CD0@SHSMSX104.ccr.corp.intel.com> References: <1539448829-13824-1-git-send-email-yonghong.zhu@intel.com> <20181013204023.tz4bomxz7ds26du2@bivouac.eciton.net> In-Reply-To: <20181013204023.tz4bomxz7ds26du2@bivouac.eciton.net> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTU3N2VlMWEtMDMwNi00OGZhLWFjMDAtOTY2MTEzMWZiMmYxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiU0xXb0oxaUppRThqUkYwakZOTk9jc1FDYVRXakJsbFFTaGdxd1VhK1RDZHVkdkp1eExWcElQbnp5XC9oV0tZdHcifQ== dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] BaseTools/Tests: Update GNUmakefile to use python3 variable X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Oct 2018 14:51:10 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Leif: OK. I will move this patch set to edk2 staging repo for people verificati= on.=20 I will use git revert command to revert total 27 patches one by one. Then= , there will be 27 commit for the revert patches. Or, one commit to combine= all revert patches. One commit is enough. Do you agree it?=20 Below is the commit message for the revert patch. Could you help review i= t? Python3 migration is the fundamental change. It requires every developer = to install Python3. Before this migration, the well communication and wide = verification must be done. But now, most people is not aware of this change= , and not try it. So, Python3 migration is reverted and be moved to edk2-st= aging Python3 branch for the edk2 user evaluation.=20 Thanks Liming > -----Original Message----- > From: Leif Lindholm [mailto:leif.lindholm@linaro.org] > Sent: Sunday, October 14, 2018 4:40 AM > To: Zhu, Yonghong > Cc: Ard Biesheuvel ; edk2-devel@lists.01.org; = Gao, Liming > Subject: Re: [Patch] BaseTools/Tests: Update GNUmakefile to use python3 v= ariable >=20 > Hi Yonghong, >=20 > Please revert this patch. The broken state of the master branch must > be undone, not hacked on until individual bits seem to work. >=20 > Plese do no further work on the master branch until the contents of > the tree is identical to what it was at > 301402fa4797ac3a141e575329ca2ea91756414c. (I am not talking about a > git push -f, I am talking about a git revert.) >=20 > Best Regards, >=20 > Leif >=20 > On Sat, Oct 13, 2018 at 04:53:21PM +0000, Zhu, Yonghong wrote: > > Hi Ard, > > > > Thanks. I pushed this patch since it is critical block issue. > > Version SHA-1: 678f85131238622e576705117e299d81cff755c9 > > > > Best Regards, > > Zhu Yonghong > > > > -----Original Message----- > > From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] > > Sent: Sunday, October 14, 2018 12:44 AM > > To: Zhu, Yonghong > > Cc: edk2-devel@lists.01.org; Leif Lindholm > > Subject: Re: [Patch] BaseTools/Tests: Update GNUmakefile to use python3= variable > > > > On 13 October 2018 at 18:40, Yonghong Zhu wrot= e: > > > Cover the case use do make -C BaseTools before run the .edksetup.sh > > > file. > > > > > > Cc: Ard Biesheuvel > > > Cc: Leif Lindholm > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > > Signed-off-by: Yonghong Zhu > > > > Reviewed-by: Ard Biesheuvel > > Tested-by: Ard Biesheuvel > > > > > --- > > > BaseTools/Tests/GNUmakefile | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/BaseTools/Tests/GNUmakefile b/BaseTools/Tests/GNUmakefil= e > > > index af334a8a..536f0b7 100644 > > > --- a/BaseTools/Tests/GNUmakefile > > > +++ b/BaseTools/Tests/GNUmakefile > > > @@ -12,10 +12,10 @@ > > > # > > > > > > all: test > > > > > > test: > > > - @if command -v $(PYTHON3) >/dev/null 2>&1; then $(PYTHON3) Ru= nTests.py; else python RunTests.py; fi > > > + @if command -v python3 >/dev/null 2>&1; then python3 > > > + RunTests.py; else echo "Error: Please install a python 3 tool!"; fi > > > > > > clean: > > > find . -name '*.pyc' -exec rm '{}' ';' > > > > > > -- > > > 2.6.1.windows.1 > > >