From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.115; helo=mga14.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 85B8221163DE0 for ; Mon, 15 Oct 2018 18:32:35 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Oct 2018 18:32:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,386,1534834800"; d="scan'208";a="88618118" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by FMSMGA003.fm.intel.com with ESMTP; 15 Oct 2018 18:32:33 -0700 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 15 Oct 2018 18:32:33 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX113.amr.corp.intel.com (10.18.116.7) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 15 Oct 2018 18:32:33 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.48]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.245]) with mapi id 14.03.0319.002; Tue, 16 Oct 2018 09:32:03 +0800 From: "Gao, Liming" To: "Kinney, Michael D" , Laszlo Ersek CC: edk2-devel-01 Thread-Topic: [edk2] [PATCH 0/5] MdePkg/BaseSynchronizationLib GCC: fixes, cleanups Thread-Index: AQHUWEMHKXnZB2Jw0U6NVWFOTYAdgaUU44eAgAtI5oCAABevgIAA61Kw Date: Tue, 16 Oct 2018 01:32:01 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E33A7CB@SHSMSX104.ccr.corp.intel.com> References: <20180929222312.32150-1-lersek@redhat.com> <89c5af5b-a4a9-1e54-d982-f99feb7d449f@redhat.com> <9bac7fc8-532e-0b40-a11d-01a4092b731d@redhat.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 0/5] MdePkg/BaseSynchronizationLib GCC: fixes, cleanups X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2018 01:32:35 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Laszlo: Sorry for the delay. Your change is good.=20 Reviewed-by: Liming Gao Thanks Liming >-----Original Message----- >From: Kinney, Michael D >Sent: Tuesday, October 16, 2018 3:29 AM >To: Laszlo Ersek ; Gao, Liming ; >Kinney, Michael D >Cc: edk2-devel-01 >Subject: RE: [edk2] [PATCH 0/5] MdePkg/BaseSynchronizationLib GCC: fixes, >cleanups > >Laszlo, > >Thanks for the reminder. My knowledge of inline >GCC assembly syntax is very limited, so I am not >able to review this patch for correctness. I can >ack it. > >Acked-by: Michael D Kinney > >Perhaps Liming can do a more complete review. > >Mike > >> -----Original Message----- >> From: edk2-devel [mailto:edk2-devel- >> bounces@lists.01.org] On Behalf Of Laszlo Ersek >> Sent: Monday, October 15, 2018 11:05 AM >> To: Kinney, Michael D ; Gao, >> Liming >> Cc: edk2-devel-01 >> Subject: Re: [edk2] [PATCH 0/5] >> MdePkg/BaseSynchronizationLib GCC: fixes, cleanups >> >> On 10/08/18 15:44, Laszlo Ersek wrote: >> > On 09/30/18 00:23, Laszlo Ersek wrote: >> >> Repo: https://github.com/lersek/edk2.git >> >> Branch: inline_asm_rw_ops_1208 >> >> >> >> This series mainly fixes the operand constraints >> (missing input-output >> >> qualifications) in >> "BaseSynchronizationLib/*/GccInline.c". >> >> >> >> (It would be better to remove these files altogether >> in favor of the >> >> already existing NASM implementation, but due to >> >> , >> we can't generally >> >> do that in libraries yet.) >> >> >> >> Cc: Liming Gao >> >> Cc: Michael D Kinney >> >> >> >> Thanks, >> >> Laszlo >> >> >> >> Laszlo Ersek (5): >> >> MdePkg/BaseSynchronizationLib GCC: fix whitespace >> and comments >> >> MdePkg/BaseSynchronizationLib GCC: fix >> InternalSyncCompareExchange16() >> >> MdePkg/BaseSynchronizationLib GCC: fix >> InternalSyncCompareExchange32() >> >> MdePkg/BaseSynchronizationLib GCC: fix X64 >> >> InternalSyncCompareExchange64() >> >> MdePkg/BaseSynchronizationLib GCC: simplify IA32 >> >> InternalSyncCompareExchange64() >> >> >> >> >> MdePkg/Library/BaseSynchronizationLib/Ia32/GccInline.c | >> 42 +++++++---------- >> >> >> MdePkg/Library/BaseSynchronizationLib/X64/GccInline.c | >> 47 +++++++------------- >> >> 2 files changed, 34 insertions(+), 55 deletions(-) >> >> >> > >> > Ping :) >> >> Ping >> _______________________________________________ >> edk2-devel mailing list >> edk2-devel@lists.01.org >> https://lists.01.org/mailman/listinfo/edk2-devel